)]}'
{"nova/conf/console.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3e6ccd272c02d7fdd77d53930c34b66fbea45254","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    cfg.StrOpt(\u0027topic\u0027,"},{"line_number":33,"context_line":"                default\u003d\u0027console\u0027,"},{"line_number":34,"context_line":"                deprecated_name\u003d\u0027console_topic\u0027,"},{"line_number":35,"context_line":"                help\u003d\u0027The topic console proxy nodes listen on\u0027),"},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":37,"context_line":"                default\u003d\u0027nova.console.xvp.XVPConsoleProxy\u0027,"},{"line_number":38,"context_line":"                deprecated_name\u003d\u0027console_driver\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_467e7a6a","line":35,"updated":"2016-04-01 10:18:11.000000000","message":"we should look at deprecating all these topic options, but thats a separate change.","commit_id":"23703eb3ec4fadfd18eaf19746c15d1ee9dce06c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3e6ccd272c02d7fdd77d53930c34b66fbea45254","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                help\u003d\u0027The topic console proxy nodes listen on\u0027),"},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":37,"context_line":"                default\u003d\u0027nova.console.xvp.XVPConsoleProxy\u0027,"},{"line_number":38,"context_line":"                deprecated_name\u003d\u0027console_driver\u0027,"},{"line_number":39,"context_line":"                help\u003d\u0027Driver to use for the console proxy\u0027),"},{"line_number":40,"context_line":"    cfg.BoolOpt(\u0027stub_compute\u0027,"},{"line_number":41,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_c6b3aa4b","line":38,"updated":"2016-04-01 10:18:11.000000000","message":"We need to convert this to stevedoor entry points, but thats a follow up change.","commit_id":"23703eb3ec4fadfd18eaf19746c15d1ee9dce06c"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"d9cca183cbcba3262f7ea162922c151182038120","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":67,"context_line":"               default\u003d\u0027/usr/share/spice-html5\u0027,"},{"line_number":68,"context_line":"               help\u003d\u0027Run webserver on same port. Serve files from DIR.\u0027),"},{"line_number":69,"context_line":"]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_bd1db568","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":1},"updated":"2016-04-04 13:49:58.000000000","message":"IIRC When you move global options into a new group you need to add deprecated_group\u003d\"DEFAULT\" to every single option.","commit_id":"23703eb3ec4fadfd18eaf19746c15d1ee9dce06c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d53b8ddddd818ba466032071d68b275897e44489","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":67,"context_line":"               default\u003d\u0027/usr/share/spice-html5\u0027,"},{"line_number":68,"context_line":"               help\u003d\u0027Run webserver on same port. Serve files from DIR.\u0027),"},{"line_number":69,"context_line":"]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_cf94858c","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":1},"in_reply_to":"9a061dce_bd1db568","updated":"2016-04-07 08:58:20.000000000","message":"Ah, you do, I missed that :(","commit_id":"23703eb3ec4fadfd18eaf19746c15d1ee9dce06c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"9fa96a2abca2a28a4091d56cfd2f5ba946064e4b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":67,"context_line":"               default\u003d\u0027/usr/share/spice-html5\u0027,"},{"line_number":68,"context_line":"               help\u003d\u0027Run webserver on same port. Serve files from DIR.\u0027),"},{"line_number":69,"context_line":"]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_f842edac","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":1},"in_reply_to":"9a061dce_cf94858c","updated":"2016-04-07 12:29:43.000000000","message":"Oops, good catch!\n\nThe default is None and it\u0027s indeed filtered out later when processing deprecations: https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L764","commit_id":"23703eb3ec4fadfd18eaf19746c15d1ee9dce06c"}],"nova/tests/unit/console/test_rpcapi.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29546ecd274be9ed785e131cf9904242f7278970","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        rpcapi \u003d console_rpcapi.ConsoleAPI()"},{"line_number":34,"context_line":"        self.assertIsNotNone(rpcapi.client)"},{"line_number":35,"context_line":"        self.assertEqual(rpcapi.client.target.topic,"},{"line_number":36,"context_line":"                         CONF.console.topic)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        orig_prepare \u003d rpcapi.client.prepare"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_e0f17696","line":36,"range":{"start_line":36,"start_character":25,"end_line":36,"end_character":44},"updated":"2016-04-01 09:37:32.000000000","message":"nit: unnecessary whitespace change (line wrap)","commit_id":"23703eb3ec4fadfd18eaf19746c15d1ee9dce06c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"1e8e1082f3b40d3ed85a396cb607a5bbc8a82dd8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        rpcapi \u003d console_rpcapi.ConsoleAPI()"},{"line_number":34,"context_line":"        self.assertIsNotNone(rpcapi.client)"},{"line_number":35,"context_line":"        self.assertEqual(rpcapi.client.target.topic,"},{"line_number":36,"context_line":"                         CONF.console.topic)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        orig_prepare \u003d rpcapi.client.prepare"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_0dd0f752","line":36,"range":{"start_line":36,"start_character":25,"end_line":36,"end_character":44},"in_reply_to":"ba0121b8_66f29e07","updated":"2016-04-11 12:07:48.000000000","message":"Done","commit_id":"23703eb3ec4fadfd18eaf19746c15d1ee9dce06c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3e6ccd272c02d7fdd77d53930c34b66fbea45254","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        rpcapi \u003d console_rpcapi.ConsoleAPI()"},{"line_number":34,"context_line":"        self.assertIsNotNone(rpcapi.client)"},{"line_number":35,"context_line":"        self.assertEqual(rpcapi.client.target.topic,"},{"line_number":36,"context_line":"                         CONF.console.topic)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        orig_prepare \u003d rpcapi.client.prepare"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_66f29e07","line":36,"range":{"start_line":36,"start_character":25,"end_line":36,"end_character":44},"in_reply_to":"ba0121b8_e0f17696","updated":"2016-04-01 10:18:11.000000000","message":"+1","commit_id":"23703eb3ec4fadfd18eaf19746c15d1ee9dce06c"}]}