)]}'
{"nova/pci/devspec.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"aa93e3b1a4ea866a751f49a4d4aea501015aca9d","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        if self.address and self.dev_name:"},{"line_number":148,"context_line":"            raise exception.PciDeviceInvalidDeviceName()"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        if self.is_pci_str_empty(self.dev_name):"},{"line_number":151,"context_line":"            raise exception.PciDeviceInvalidEntryFormat()"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        if not self.dev_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_ec0a17d1","line":150,"range":{"start_line":150,"start_character":19,"end_line":150,"end_character":26},"updated":"2016-04-01 07:43:39.000000000","message":"can you change to is_dev_name_empty?","commit_id":"de0fc18602094de00c12347d032937c534dc4120"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"aa93e3b1a4ea866a751f49a4d4aea501015aca9d","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        if self.is_pci_str_empty(self.dev_name):"},{"line_number":151,"context_line":"            raise exception.PciDeviceInvalidEntryFormat()"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        if not self.dev_name:"},{"line_number":154,"context_line":"            if not self.address:"},{"line_number":155,"context_line":"                if self.vendor_id \u003d\u003d \u0027*\u0027 or self.product_id \u003d\u003d \u0027*\u0027:"},{"line_number":156,"context_line":"                    raise exception.PciDeviceInvalidEntryFormat()"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        pf \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_6ccc4789","line":155,"range":{"start_line":153,"start_character":0,"end_line":155,"end_character":67},"updated":"2016-04-01 07:43:39.000000000","message":"why not if not not self.dev_name and not self.address","commit_id":"de0fc18602094de00c12347d032937c534dc4120"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"aa93e3b1a4ea866a751f49a4d4aea501015aca9d","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        if not self.dev_name:"},{"line_number":154,"context_line":"            if not self.address:"},{"line_number":155,"context_line":"                if self.vendor_id \u003d\u003d \u0027*\u0027 or self.product_id \u003d\u003d \u0027*\u0027:"},{"line_number":156,"context_line":"                    raise exception.PciDeviceInvalidEntryFormat()"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        pf \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_ecd5f742","line":155,"range":{"start_line":155,"start_character":36,"end_line":155,"end_character":40},"updated":"2016-04-01 07:43:39.000000000","message":"why not using the ANY constant","commit_id":"de0fc18602094de00c12347d032937c534dc4120"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"aa93e3b1a4ea866a751f49a4d4aea501015aca9d","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    def is_pci_str_empty(self, pci_str):"},{"line_number":190,"context_line":"        if pci_str is None:"},{"line_number":191,"context_line":"            return False"},{"line_number":192,"context_line":"        else:"},{"line_number":193,"context_line":"            return not (pci_str and not pci_str.isspace())"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_0c614ba9","line":192,"range":{"start_line":192,"start_character":8,"end_line":192,"end_character":13},"updated":"2016-04-01 07:43:39.000000000","message":"you can remove the else","commit_id":"de0fc18602094de00c12347d032937c534dc4120"},{"author":{"_account_id":20444,"name":"gh159m","email":"gh159m@att.com","username":"gh159m"},"change_message_id":"2a6256fdeb18509ff383f204fd231c14f66d919d","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        get_pci_dev_info(self, \u0027vendor_id\u0027, MAX_VENDOR_ID, \u0027%04x\u0027)"},{"line_number":145,"context_line":"        get_pci_dev_info(self, \u0027product_id\u0027, MAX_PRODUCT_ID, \u0027%04x\u0027)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if self.address and self.dev_name:"},{"line_number":148,"context_line":"            raise exception.PciDeviceInvalidDeviceName()"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        if self.is_dev_name_empty():"},{"line_number":151,"context_line":"            raise exception.PciDeviceInvalidEntryFormat()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_db277410","line":148,"range":{"start_line":147,"start_character":0,"end_line":148,"end_character":56},"updated":"2016-04-13 21:00:49.000000000","message":"It\u0027s currently set to fail here already if the whitelist specifies both devname and address.  If we want to switch to just logging bad whitelist configurations, probably would want to open a different bug report to specify this.","commit_id":"91cf26c40c75d7cfbd093cd35123e7ab9964e19e"}]}