)]}'
{"nova/service.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"963bb4d044eecc57273b595571f2a92d192b3e44","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        flag_get \u003d FLAGS.get(flag, None)"},{"line_number":391,"context_line":"        # hide flag contents from log if contains a password"},{"line_number":392,"context_line":"        if flag \u003d\u003d \"rabbit_password\" or"},{"line_number":393,"context_line":"        (flag \u003d\u003d \"sql_connection\" and flag_get.find(\"mysql:\") \u003e\u003d 0):"},{"line_number":394,"context_line":"            logging.debug(\u0027%(flag)s : FLAG SET \u0027 % locals())"},{"line_number":395,"context_line":"        else:"},{"line_number":396,"context_line":"            logging.debug(\u0027%(flag)s : %(flag_get)s\u0027 % locals())"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAD3%2F%2F%2Bec%3D","line":393,"updated":"2012-01-12 23:30:01.000000000","message":"There may be other password flags to be added to this list...","commit_id":"05ab3d20d91dd03e68d0b34865407e29aace1a37"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"2d29471bef402bcba98c43df3eec4d2410a121d0","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        flag_get \u003d FLAGS.get(flag, None)"},{"line_number":396,"context_line":"        # hide flag contents from log if contains a password"},{"line_number":397,"context_line":"        # should use secret flag when switch over to openstack-common"},{"line_number":398,"context_line":"        if (\"_password\" or \"_key\") in flag  or"},{"line_number":399,"context_line":"        (flag \u003d\u003d \"sql_connection\" and \"mysql:\" in flag_get):"},{"line_number":400,"context_line":"            logging.debug(\u0027%(flag)s : FLAG SET \u0027 % locals())"},{"line_number":401,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAD3%2F%2F87s%3D","line":398,"updated":"2012-01-18 19:22:29.000000000","message":"Is the intent to match on \u0027foo_password\u0027 or \u0027foo_key\u0027?\n\nBecause this code doesn\u0027t appear to do that:\n\n\u003e\u003e\u003e (\"_password\" or \"_key\") in \"foo_key\"\nFalse\n\u003e\u003e\u003e (\"_password\" or \"_key\") in \"foo_password\"\nTrue","commit_id":"23fc5aca47289ad432cbbf6b355ebea3b2a02e9f"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"e7062ce760b8cff825f5618af7526b4df0bf0a44","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        # hide flag contents from log if contains a password"},{"line_number":397,"context_line":"        # should use secret flag when switch over to openstack-common"},{"line_number":398,"context_line":"        if \"_password\" in flag or \"_key\" in flag  or"},{"line_number":399,"context_line":"        (flag \u003d\u003d \"sql_connection\" and \"mysql:\" in flag_get):"},{"line_number":400,"context_line":"            logging.debug(\u0027%(flag)s : FLAG SET \u0027 % locals())"},{"line_number":401,"context_line":"        else:"},{"line_number":402,"context_line":"            logging.debug(\u0027%(flag)s : %(flag_get)s\u0027 % locals())"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAD3%2F%2F84Q%3D","line":399,"updated":"2012-01-18 21:01:31.000000000","message":"This \u0027if\u0027 is busted, I think.  Syntax error due to line ending in \u0027or\u0027.  Needs line continuation char.. or better: parens around the whole if args.  Continued part of the line should also be indented 2 levels and there\u0027s an extra space after \u0027in flag\u0027 right now.","commit_id":"4e999f64901eac4d3987a6823e52e0199e375c50"}]}