)]}'
{"nova/virt/hyperv/cluster/clusterops.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"2fcf4196779ea2ead7dbc21bf5d07bc302a1da6d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"               default\u003d2,"},{"line_number":40,"context_line":"               help\u003d\u0027The time interval at which the cluster should be queried\u0027"},{"line_number":41,"context_line":"                    \u0027for events.\u0027),"},{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":45,"context_line":"CONF.register_opts(hyperv_cluster_opts, \u0027hyperv\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_6c09a82c","line":42,"updated":"2016-04-12 11:25:32.000000000","message":"this will have to be moved to nova/conf/hyperv.py. All the config options have been moved there.","commit_id":"ab3abd4d75260d285ea57a28d860c453f4f8b95a"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"2fcf4196779ea2ead7dbc21bf5d07bc302a1da6d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        try:"},{"line_number":68,"context_line":"            self._clustutils.add_vm_to_cluster(instance.name)"},{"line_number":69,"context_line":"            self._instance_map[instance.name] \u003d instance.uuid"},{"line_number":70,"context_line":"        except os_win_exc.HyperVClusterException:"},{"line_number":71,"context_line":"            LOG.exception(_LE(\u0027Adding instance to cluster failed.\u0027),"},{"line_number":72,"context_line":"                          instance\u003dinstance)"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_8c3c0431","line":70,"updated":"2016-04-12 11:25:32.000000000","message":"wondering why we shouldn\u0027t just reraise this exception. If it failed to add to cluster, the instance will not have the desired \"clustered\" quality, which is erroneous.","commit_id":"ab3abd4d75260d285ea57a28d860c453f4f8b95a"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"2fcf4196779ea2ead7dbc21bf5d07bc302a1da6d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        try:"},{"line_number":76,"context_line":"            self._clustutils.delete(instance.name)"},{"line_number":77,"context_line":"            self._instance_map.pop(instance.name, None)"},{"line_number":78,"context_line":"        except os_win_exc.HyperVClusterException:"},{"line_number":79,"context_line":"            LOG.exception(_LE(\u0027Removing instance from cluster failed.\u0027),"},{"line_number":80,"context_line":"                          instance\u003dinstance)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_cc46fcbe","line":78,"updated":"2016-04-12 11:25:32.000000000","message":"ditto.","commit_id":"ab3abd4d75260d285ea57a28d860c453f4f8b95a"}],"nova/virt/hyperv/cluster/driver.py":[{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"ffbe14717a0175f6b234a602d79570b55ee5a4d0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        super(HyperVClusterDriver, self).spawn("},{"line_number":34,"context_line":"            context, instance, image_meta, injected_files, admin_password,"},{"line_number":35,"context_line":"            network_info, block_device_info)"},{"line_number":36,"context_line":"        self._clops.add_to_cluster(instance)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def destroy(self, context, instance, network_info, block_device_info\u003dNone,"},{"line_number":39,"context_line":"                destroy_disks\u003dTrue, migrate_data\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_d2120658","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":12},"updated":"2016-07-08 12:27:08.000000000","message":"Umm, this doesn\u0027t look safe. The super method will cleanup the resources if the instance spawn fails.\n\nIf the instance cannot be clustered, for some reason, we won\u0027t do any cleanup.","commit_id":"ab3abd4d75260d285ea57a28d860c453f4f8b95a"}],"nova/virt/hyperv/cluster/livemigrationops.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"2fcf4196779ea2ead7dbc21bf5d07bc302a1da6d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                  instance\u003dinstance_ref)"},{"line_number":74,"context_line":"        post_method(context, instance_ref, dest, block_migration)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def pre_live_migration(self, context, instance, block_device_info,"},{"line_number":77,"context_line":"                           network_info):"},{"line_number":78,"context_line":"        if self._is_instance_clustered(instance.name):"},{"line_number":79,"context_line":"            self._volumeops.connect_volumes(block_device_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_0c1d9473","line":76,"updated":"2016-04-12 11:25:32.000000000","message":"we probably need some comments as to why we do this.","commit_id":"ab3abd4d75260d285ea57a28d860c453f4f8b95a"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"2fcf4196779ea2ead7dbc21bf5d07bc302a1da6d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            super(ClusterLiveMigrationOps, self).pre_live_migration("},{"line_number":82,"context_line":"                context, instance, block_device_info, network_info)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def post_live_migration(self, context, instance, block_device_info):"},{"line_number":85,"context_line":"        if not self._is_instance_clustered(instance.name):"},{"line_number":86,"context_line":"            super(ClusterLiveMigrationOps, self).post_live_migration("},{"line_number":87,"context_line":"                context, instance, block_device_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_6c124864","line":84,"updated":"2016-04-12 11:25:32.000000000","message":"ditto.","commit_id":"ab3abd4d75260d285ea57a28d860c453f4f8b95a"}]}