)]}'
{"nova/conf/compute.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8503d3d3eed2a43a7fc21673d14a1fc7fd99d1cd","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        help\u003d\"\"\"Enable new services on this host automatically."},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"When a new service (for example \"nova-compute\") gets started, it gets"},{"line_number":351,"context_line":"registered in the database as an enabled service. Sometimes it can be useful"},{"line_number":352,"context_line":"to register new services in an disabled state to enabled them in a later"},{"line_number":353,"context_line":"point in time. This option can set this behavior for all services per host."},{"line_number":354,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_4c9be172","line":351,"range":{"start_line":351,"start_character":50,"end_line":351,"end_character":76},"updated":"2016-05-09 09:42:10.000000000","message":"The aim is so deployers can explicitly acknowledge the joining of any well behaved node into the cloud.","commit_id":"450163b247e710e77da05bb96f66321933e89d5c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2e361deed46d76f7b933c6ac20114a1249e36bc3","unresolved":false,"context_lines":[{"line_number":382,"context_line":""},{"line_number":383,"context_line":"Possible values:"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"* It is a string which either uses the instance database ID (like the"},{"line_number":386,"context_line":"  default)"},{"line_number":387,"context_line":"* or a string with a list of named database columns, for example ``%(id)d``"},{"line_number":388,"context_line":"  or ``%(uuid)s`` or ``%(hostname)s``."}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_153c06c7","line":385,"range":{"start_line":385,"start_character":2,"end_line":385,"end_character":8},"updated":"2016-05-16 09:50:35.000000000","message":"d/It is /","commit_id":"3e77d0d31c88a157c0342b73c69beeb9297c7b4c"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"6fcea4505d89cc33da768e7ce6ecad145e4ab439","unresolved":false,"context_lines":[{"line_number":382,"context_line":""},{"line_number":383,"context_line":"Possible values:"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"* It is a string which either uses the instance database ID (like the"},{"line_number":386,"context_line":"  default)"},{"line_number":387,"context_line":"* or a string with a list of named database columns, for example ``%(id)d``"},{"line_number":388,"context_line":"  or ``%(uuid)s`` or ``%(hostname)s``."}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_2d21a49e","line":385,"range":{"start_line":385,"start_character":2,"end_line":385,"end_character":8},"in_reply_to":"dab17558_153c06c7","updated":"2016-05-17 17:22:50.000000000","message":"Done","commit_id":"3e77d0d31c88a157c0342b73c69beeb9297c7b4c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2e361deed46d76f7b933c6ac20114a1249e36bc3","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":"* It is a string which either uses the instance database ID (like the"},{"line_number":386,"context_line":"  default)"},{"line_number":387,"context_line":"* or a string with a list of named database columns, for example ``%(id)d``"},{"line_number":388,"context_line":"  or ``%(uuid)s`` or ``%(hostname)s``."},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"Services which consume this:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_35182a75","line":387,"range":{"start_line":387,"start_character":2,"end_line":387,"end_character":5},"updated":"2016-05-16 09:50:35.000000000","message":"d/or /","commit_id":"3e77d0d31c88a157c0342b73c69beeb9297c7b4c"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"6fcea4505d89cc33da768e7ce6ecad145e4ab439","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":"* It is a string which either uses the instance database ID (like the"},{"line_number":386,"context_line":"  default)"},{"line_number":387,"context_line":"* or a string with a list of named database columns, for example ``%(id)d``"},{"line_number":388,"context_line":"  or ``%(uuid)s`` or ``%(hostname)s``."},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"Services which consume this:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_4d1ea85f","line":387,"range":{"start_line":387,"start_character":2,"end_line":387,"end_character":5},"in_reply_to":"dab17558_35182a75","updated":"2016-05-17 17:22:50.000000000","message":"Done","commit_id":"3e77d0d31c88a157c0342b73c69beeb9297c7b4c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2e361deed46d76f7b933c6ac20114a1249e36bc3","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":"Related options:"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"* ``multi_instance_display_name_template``: That option controls the creation"},{"line_number":397,"context_line":"  of the \"display name\" of simultaneously launched instances and shouldn\u0027t be"},{"line_number":398,"context_line":"  confused with this one here."},{"line_number":399,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_15436643","line":396,"range":{"start_line":396,"start_character":44,"end_line":396,"end_character":48},"updated":"2016-05-16 09:50:35.000000000","message":"s/That/This","commit_id":"3e77d0d31c88a157c0342b73c69beeb9297c7b4c"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"6fcea4505d89cc33da768e7ce6ecad145e4ab439","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":"Related options:"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"* ``multi_instance_display_name_template``: That option controls the creation"},{"line_number":397,"context_line":"  of the \"display name\" of simultaneously launched instances and shouldn\u0027t be"},{"line_number":398,"context_line":"  confused with this one here."},{"line_number":399,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_ad163446","line":396,"range":{"start_line":396,"start_character":44,"end_line":396,"end_character":48},"in_reply_to":"dab17558_15436643","updated":"2016-05-17 17:22:50.000000000","message":"Done","commit_id":"3e77d0d31c88a157c0342b73c69beeb9297c7b4c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"78a640a82b2a4139a649dad5506cc4bc77ecbe2a","unresolved":false,"context_lines":[{"line_number":309,"context_line":"\"\"\"),"},{"line_number":310,"context_line":"]"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"db_opts \u003d ["},{"line_number":313,"context_line":"    cfg.StrOpt(\u0027osapi_compute_unique_server_name_scope\u0027,"},{"line_number":314,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":315,"context_line":"               help\u003d\u0027When set, compute API will consider duplicate hostnames \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_0fc97026","side":"PARENT","line":312,"updated":"2016-06-24 13:31:18.000000000","message":"I much prefer keeping this, as described in here:\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency#fix_opt_registration_consistency","commit_id":"bb50389bb6dcf891ae1f1ec7bd037efc462ce517"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ccb8ffea8bca46cb522fbb79a33d731ca9333c48","unresolved":false,"context_lines":[{"line_number":309,"context_line":"\"\"\"),"},{"line_number":310,"context_line":"]"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"db_opts \u003d ["},{"line_number":313,"context_line":"    cfg.StrOpt(\u0027osapi_compute_unique_server_name_scope\u0027,"},{"line_number":314,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":315,"context_line":"               help\u003d\u0027When set, compute API will consider duplicate hostnames \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_84efb7af","side":"PARENT","line":312,"in_reply_to":"3aaa91ec_0fc97026","updated":"2016-08-08 13:16:18.000000000","message":"Done","commit_id":"bb50389bb6dcf891ae1f1ec7bd037efc462ce517"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"78a640a82b2a4139a649dad5506cc4bc77ecbe2a","unresolved":false,"context_lines":[{"line_number":309,"context_line":"\"\"\"),"},{"line_number":310,"context_line":"]"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"# TODO(markus_z): 2016-04-04: A new patch set should make use of the \"choices\""},{"line_number":313,"context_line":"# attribute of \"oslo.config\". A reno file is then necessary too."},{"line_number":314,"context_line":"# Example: ``choices \u003d [\u0027\u0027, \u0027project\u0027, \u0027global\u0027]``"},{"line_number":315,"context_line":"unique_server_name_scope_opt \u003d \\"},{"line_number":316,"context_line":"    cfg.StrOpt(\u0027osapi_compute_unique_server_name_scope\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_f33314f4","line":313,"range":{"start_line":312,"start_character":0,"end_line":313,"end_character":64},"updated":"2016-06-24 13:31:18.000000000","message":"we don\u0027t need a reno note, if the user is still setting the same conf values, in the same way.\n\ncan\u0027t we just add in choices here?","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ccb8ffea8bca46cb522fbb79a33d731ca9333c48","unresolved":false,"context_lines":[{"line_number":309,"context_line":"\"\"\"),"},{"line_number":310,"context_line":"]"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"# TODO(markus_z): 2016-04-04: A new patch set should make use of the \"choices\""},{"line_number":313,"context_line":"# attribute of \"oslo.config\". A reno file is then necessary too."},{"line_number":314,"context_line":"# Example: ``choices \u003d [\u0027\u0027, \u0027project\u0027, \u0027global\u0027]``"},{"line_number":315,"context_line":"unique_server_name_scope_opt \u003d \\"},{"line_number":316,"context_line":"    cfg.StrOpt(\u0027osapi_compute_unique_server_name_scope\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_26f53383","line":313,"range":{"start_line":312,"start_character":0,"end_line":313,"end_character":64},"in_reply_to":"7aa08908_f33314f4","updated":"2016-08-08 13:16:18.000000000","message":"@John: I was thinking about the (theoretical) case where one configures this option with a value like \"abcd\" for example. Right now this gets logged with a warning [1] but doesn\u0027t stop the service. I guess I was thinking in an overprotective way, I\u0027m going to change it to \"choices\" in ps8.\n\n[1] https://github.com/openstack/nova/blob/45317d6273d75fcca349ebc195538ec69fd9d024/nova/db/sqlalchemy/api.py#L1707-L1709","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63fefc0a907c5b6413a1e4dd4819a967add4afd1","unresolved":false,"context_lines":[{"line_number":332,"context_line":"  same project."},{"line_number":333,"context_line":"* \"global\": The instance name check is done for all instances regardless of"},{"line_number":334,"context_line":"  the project."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"Services which consume this:"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"* nova-compute"},{"line_number":339,"context_line":"* nova-cells"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"Related options:"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_3dd30a3a","line":339,"range":{"start_line":335,"start_character":0,"end_line":339,"end_character":12},"updated":"2016-05-25 16:26:51.000000000","message":"Are we have reached an agreement to drop this element of the conf messages? Someone needs to go through and delete the other cases, but it doesn\u0027t make much sense to keep what\u0027s here around IMO.","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ccb8ffea8bca46cb522fbb79a33d731ca9333c48","unresolved":false,"context_lines":[{"line_number":332,"context_line":"  same project."},{"line_number":333,"context_line":"* \"global\": The instance name check is done for all instances regardless of"},{"line_number":334,"context_line":"  the project."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"Services which consume this:"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"* nova-compute"},{"line_number":339,"context_line":"* nova-cells"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"Related options:"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_066d8f04","line":339,"range":{"start_line":335,"start_character":0,"end_line":339,"end_character":12},"in_reply_to":"7aa08908_13050010","updated":"2016-08-08 13:16:18.000000000","message":"@John: Agreed, ps8 will have dropped this.","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"78a640a82b2a4139a649dad5506cc4bc77ecbe2a","unresolved":false,"context_lines":[{"line_number":332,"context_line":"  same project."},{"line_number":333,"context_line":"* \"global\": The instance name check is done for all instances regardless of"},{"line_number":334,"context_line":"  the project."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"Services which consume this:"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"* nova-compute"},{"line_number":339,"context_line":"* nova-cells"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"Related options:"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_9c0e3c39","line":339,"range":{"start_line":335,"start_character":0,"end_line":339,"end_character":12},"in_reply_to":"7aa08908_f40a571f","updated":"2016-06-24 13:31:18.000000000","message":"I am torn, I think we should fix this up.","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"7aade6b7d206786ae5d8baebfeee4664a7ffe1f1","unresolved":false,"context_lines":[{"line_number":332,"context_line":"  same project."},{"line_number":333,"context_line":"* \"global\": The instance name check is done for all instances regardless of"},{"line_number":334,"context_line":"  the project."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"Services which consume this:"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"* nova-compute"},{"line_number":339,"context_line":"* nova-cells"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"Related options:"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_f40a571f","line":339,"range":{"start_line":335,"start_character":0,"end_line":339,"end_character":12},"in_reply_to":"9abb7d3a_58cacc50","updated":"2016-06-16 16:08:39.000000000","message":"Deadlines are coming and I am starting to have doubts if fixing consistency in next patch will make it on time. By fixing separate patches we will have at least few options that are consistent. \n\nI will provide patches for every inconsistent one that are merged.","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"78a640a82b2a4139a649dad5506cc4bc77ecbe2a","unresolved":false,"context_lines":[{"line_number":332,"context_line":"  same project."},{"line_number":333,"context_line":"* \"global\": The instance name check is done for all instances regardless of"},{"line_number":334,"context_line":"  the project."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"Services which consume this:"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"* nova-compute"},{"line_number":339,"context_line":"* nova-cells"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"Related options:"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_13050010","line":339,"range":{"start_line":335,"start_character":0,"end_line":339,"end_character":12},"in_reply_to":"9abb7d3a_58cacc50","updated":"2016-06-24 13:31:18.000000000","message":"I would say, lets just drop these.","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"f8847d2b5c4831ab28081a2a0601862fbea29e4c","unresolved":false,"context_lines":[{"line_number":332,"context_line":"  same project."},{"line_number":333,"context_line":"* \"global\": The instance name check is done for all instances regardless of"},{"line_number":334,"context_line":"  the project."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"Services which consume this:"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"* nova-compute"},{"line_number":339,"context_line":"* nova-cells"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"Related options:"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_58cacc50","line":339,"range":{"start_line":335,"start_character":0,"end_line":339,"end_character":12},"in_reply_to":"bab6814e_3dd30a3a","updated":"2016-05-27 09:21:34.000000000","message":"@Stephen: No one voted against John\u0027s proposal on the ML [1]. I\u0027d keep it here and remove it with the rest in other modules when we make it consistent. What do you think?\n\nReferences:\n[1] http://lists.openstack.org/pipermail/openstack-dev/2016-May/095538.html","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"78a640a82b2a4139a649dad5506cc4bc77ecbe2a","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"Related options:"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"* None"},{"line_number":344,"context_line":"\"\"\")"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"enable_new_services_opt \u003d cfg.BoolOpt(\u0027enable_new_services\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_7c0b902a","line":343,"updated":"2016-06-24 13:31:18.000000000","message":"Lets drop this bit too.","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ccb8ffea8bca46cb522fbb79a33d731ca9333c48","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"Related options:"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"* None"},{"line_number":344,"context_line":"\"\"\")"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"enable_new_services_opt \u003d cfg.BoolOpt(\u0027enable_new_services\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_265b7356","line":343,"in_reply_to":"3aaa91ec_7c0b902a","updated":"2016-08-08 13:16:18.000000000","message":"Done","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"bcd8435beb2e492aed23a98fa9eaa8a373dfcb89","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"When a new service (for example \"nova-compute\") gets started, it gets"},{"line_number":351,"context_line":"registered in the database as an enabled service. Sometimes it can be useful"},{"line_number":352,"context_line":"to register new services in an disabled state to enabled them in a later"},{"line_number":353,"context_line":"point in time. This option can set this behavior for all services per host."},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_9b807e48","line":352,"updated":"2016-05-24 17:24:34.000000000","message":"s/an disabled/disabled\n\nI think this looks better: \u0027Sometimes it can be useful\nto register new services in disabled state and then enable them in a later point in time.\u0027","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ccb8ffea8bca46cb522fbb79a33d731ca9333c48","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"When a new service (for example \"nova-compute\") gets started, it gets"},{"line_number":351,"context_line":"registered in the database as an enabled service. Sometimes it can be useful"},{"line_number":352,"context_line":"to register new services in an disabled state to enabled them in a later"},{"line_number":353,"context_line":"point in time. This option can set this behavior for all services per host."},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_0909202d","line":352,"in_reply_to":"bab6814e_9b807e48","updated":"2016-08-08 13:16:18.000000000","message":"Done","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"930cfbb973c0447650a4f793ed7c69a8538681c0","unresolved":false,"context_lines":[{"line_number":359,"context_line":"  with ``nova service-enable \u003chostname\u003e \u003cbinary\u003e``, otherwise they are not"},{"line_number":360,"context_line":"  ready to use."},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"Services which consume this:"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"* All on this host."},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"Related options:"},{"line_number":367,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_fdec74bc","line":364,"range":{"start_line":362,"start_character":0,"end_line":364,"end_character":19},"updated":"2016-07-21 15:26:52.000000000","message":"Drop this section.","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ccb8ffea8bca46cb522fbb79a33d731ca9333c48","unresolved":false,"context_lines":[{"line_number":359,"context_line":"  with ``nova service-enable \u003chostname\u003e \u003cbinary\u003e``, otherwise they are not"},{"line_number":360,"context_line":"  ready to use."},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"Services which consume this:"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"* All on this host."},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"Related options:"},{"line_number":367,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_691a5c70","line":364,"range":{"start_line":362,"start_character":0,"end_line":364,"end_character":19},"in_reply_to":"dada55a8_fdec74bc","updated":"2016-08-08 13:16:18.000000000","message":"Done","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"930cfbb973c0447650a4f793ed7c69a8538681c0","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"* All on this host."},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"Related options:"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"* None"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"\"\"\")"},{"line_number":371,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_ddfb7077","line":368,"range":{"start_line":366,"start_character":0,"end_line":368,"end_character":6},"updated":"2016-07-21 15:26:52.000000000","message":"Drop this section.","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ccb8ffea8bca46cb522fbb79a33d731ca9333c48","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"* All on this host."},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"Related options:"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"* None"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"\"\"\")"},{"line_number":371,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_2910644e","line":368,"range":{"start_line":366,"start_character":0,"end_line":368,"end_character":6},"in_reply_to":"dada55a8_ddfb7077","updated":"2016-08-08 13:16:18.000000000","message":"Done","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"78a640a82b2a4139a649dad5506cc4bc77ecbe2a","unresolved":false,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"# TODO(markus_z): 2016-04-04: This got introduced with commit 48fc6611d1"},{"line_number":373,"context_line":"# without any specified use-case. Maybe we can deprecate and"},{"line_number":374,"context_line":"# drop it after we asked the ops how important it is for them."},{"line_number":375,"context_line":"instance_name_template_opt \u003d cfg.StrOpt(\u0027instance_name_template\u0027,"},{"line_number":376,"context_line":"        default\u003d\u0027instance-%08x\u0027,"},{"line_number":377,"context_line":"        help\u003d\"\"\"Template string to be used to generate instance names."}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_8f4d6040","line":374,"updated":"2016-06-24 13:31:18.000000000","message":"So the current one is a bit odd, we really want to change it to the uuid rather than the database id, but that will break all existing deployments.","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ccb8ffea8bca46cb522fbb79a33d731ca9333c48","unresolved":false,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"# TODO(markus_z): 2016-04-04: This got introduced with commit 48fc6611d1"},{"line_number":373,"context_line":"# without any specified use-case. Maybe we can deprecate and"},{"line_number":374,"context_line":"# drop it after we asked the ops how important it is for them."},{"line_number":375,"context_line":"instance_name_template_opt \u003d cfg.StrOpt(\u0027instance_name_template\u0027,"},{"line_number":376,"context_line":"        default\u003d\u0027instance-%08x\u0027,"},{"line_number":377,"context_line":"        help\u003d\"\"\"Template string to be used to generate instance names."}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_89907097","line":374,"in_reply_to":"3aaa91ec_8f4d6040","updated":"2016-08-08 13:16:18.000000000","message":"I remove the TODO in ps8.","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"78a640a82b2a4139a649dad5506cc4bc77ecbe2a","unresolved":false,"context_lines":[{"line_number":378,"context_line":""},{"line_number":379,"context_line":"This template controls the creation of the database name of an instance. This"},{"line_number":380,"context_line":"is *not* the display name you enter when creating an instance (via Horizon"},{"line_number":381,"context_line":"or CLI). It is very unlikely that you have to change this option."},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"Possible values:"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_af15bce5","line":381,"range":{"start_line":381,"start_character":9,"end_line":381,"end_character":65},"updated":"2016-06-24 13:31:18.000000000","message":"so I think this used to break existing deployments, if you change it when you have instances in your deployment. We should probably warn about that. I think thats still true.","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ccb8ffea8bca46cb522fbb79a33d731ca9333c48","unresolved":false,"context_lines":[{"line_number":378,"context_line":""},{"line_number":379,"context_line":"This template controls the creation of the database name of an instance. This"},{"line_number":380,"context_line":"is *not* the display name you enter when creating an instance (via Horizon"},{"line_number":381,"context_line":"or CLI). It is very unlikely that you have to change this option."},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"Possible values:"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_c9e8a819","line":381,"range":{"start_line":381,"start_character":9,"end_line":381,"end_character":65},"in_reply_to":"3aaa91ec_af15bce5","updated":"2016-08-08 13:16:18.000000000","message":"I add a more explicit warning in ps8.","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"78a640a82b2a4139a649dad5506cc4bc77ecbe2a","unresolved":false,"context_lines":[{"line_number":389,"context_line":""},{"line_number":390,"context_line":"Services which consume this:"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"* nova-compute"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"Related options:"},{"line_number":395,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_0fd5f01a","line":392,"updated":"2016-06-24 13:31:18.000000000","message":"lets drop this.","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ccb8ffea8bca46cb522fbb79a33d731ca9333c48","unresolved":false,"context_lines":[{"line_number":389,"context_line":""},{"line_number":390,"context_line":"Services which consume this:"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"* nova-compute"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"Related options:"},{"line_number":395,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_69e41c3b","line":392,"in_reply_to":"3aaa91ec_0fd5f01a","updated":"2016-08-08 13:16:18.000000000","message":"Done","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"78a640a82b2a4139a649dad5506cc4bc77ecbe2a","unresolved":false,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":"* ``multi_instance_display_name_template``: This option controls the creation"},{"line_number":397,"context_line":"  of the \"display name\" of simultaneously launched instances and shouldn\u0027t be"},{"line_number":398,"context_line":"  confused with this one here."},{"line_number":399,"context_line":"\"\"\")"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"# TODO(markus_z): 2016-04-04: This is not used anymore. The class"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_efa7c4ba","line":398,"updated":"2016-06-24 13:31:18.000000000","message":"hmm, I am torn about mentioning this lack of a relationship.\n\nMaybe start this with \"not to be confused with: \"","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ccb8ffea8bca46cb522fbb79a33d731ca9333c48","unresolved":false,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":"* ``multi_instance_display_name_template``: This option controls the creation"},{"line_number":397,"context_line":"  of the \"display name\" of simultaneously launched instances and shouldn\u0027t be"},{"line_number":398,"context_line":"  confused with this one here."},{"line_number":399,"context_line":"\"\"\")"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"# TODO(markus_z): 2016-04-04: This is not used anymore. The class"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_89db501b","line":398,"in_reply_to":"3aaa91ec_efa7c4ba","updated":"2016-08-08 13:16:18.000000000","message":"Done","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"78a640a82b2a4139a649dad5506cc4bc77ecbe2a","unresolved":false,"context_lines":[{"line_number":406,"context_line":"# should remove it completely."},{"line_number":407,"context_line":"snapshot_name_template_opt \u003d cfg.StrOpt(\u0027snapshot_name_template\u0027,"},{"line_number":408,"context_line":"        default\u003d\u0027snapshot-%s\u0027,"},{"line_number":409,"context_line":"        help\u003d\"\"\"DEPRECATED: Template string to be used to generate snapshot"},{"line_number":410,"context_line":"names\"\"\","},{"line_number":411,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":412,"context_line":"        deprecated_reason\u003d\"\"\"This is not used anymore and will be removed"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_4f0a587a","line":409,"range":{"start_line":409,"start_character":16,"end_line":409,"end_character":28},"updated":"2016-06-24 13:31:18.000000000","message":"We should stop adding this.\n\nThe docs do a good job of outputting this info now, so it really easy to end up with this duplicated.","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"930cfbb973c0447650a4f793ed7c69a8538681c0","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        default\u003d\u0027snapshot-%s\u0027,"},{"line_number":409,"context_line":"        help\u003d\"\"\"DEPRECATED: Template string to be used to generate snapshot"},{"line_number":410,"context_line":"names\"\"\","},{"line_number":411,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":412,"context_line":"        deprecated_reason\u003d\"\"\"This is not used anymore and will be removed"},{"line_number":413,"context_line":"in the O release.\"\"\")"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"DB_OPTS \u003d [enable_new_services_opt,"},{"line_number":416,"context_line":"           instance_name_template_opt,"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_1d4ea8c0","line":413,"range":{"start_line":411,"start_character":8,"end_line":413,"end_character":21},"updated":"2016-07-21 15:26:52.000000000","message":"Please keep deprecated flags above help message, it is easy to skip these after reading help message.","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ccb8ffea8bca46cb522fbb79a33d731ca9333c48","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        default\u003d\u0027snapshot-%s\u0027,"},{"line_number":409,"context_line":"        help\u003d\"\"\"DEPRECATED: Template string to be used to generate snapshot"},{"line_number":410,"context_line":"names\"\"\","},{"line_number":411,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":412,"context_line":"        deprecated_reason\u003d\"\"\"This is not used anymore and will be removed"},{"line_number":413,"context_line":"in the O release.\"\"\")"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"DB_OPTS \u003d [enable_new_services_opt,"},{"line_number":416,"context_line":"           instance_name_template_opt,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_6946dcc0","line":413,"range":{"start_line":411,"start_character":8,"end_line":413,"end_character":21},"in_reply_to":"dada55a8_1d4ea8c0","updated":"2016-08-08 13:16:18.000000000","message":"Done","commit_id":"3e204e0646f584a99054ab4bba13767be50d199b"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"e54e019b15052060ee9d345473c82245d331e191","unresolved":false,"context_lines":[{"line_number":528,"context_line":""},{"line_number":529,"context_line":"This template controls the creation of the database name of an instance. This"},{"line_number":530,"context_line":"is *not* the display name you enter when creating an instance (via Horizon"},{"line_number":531,"context_line":"or CLI). It is very unlikely that you have to change this option. If you"},{"line_number":532,"context_line":"already have instances in your deployment when you change this, your"},{"line_number":533,"context_line":"deployment will break."},{"line_number":534,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_d42bcbe9","line":531,"range":{"start_line":531,"start_character":9,"end_line":531,"end_character":64},"updated":"2016-08-09 18:03:10.000000000","message":"While it is not necessary to change it I believe our default here is bad. But as the next line mentions we can\u0027t change the default without a lot of additional work.\n\nInstead of this line I would recommend that we encourage a different default. Something like \u0027instance-%(uuid)s\u0027 rather than the current default which uses the database autoincrement field in the name. And that field is an implementation detail that should not leak out of the database layer.","commit_id":"7d600f495d8ce256fbfd8c1632e7a783280963e1"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"47f291a75ba5ce627f94f353d345853b97dbf9e5","unresolved":false,"context_lines":[{"line_number":528,"context_line":""},{"line_number":529,"context_line":"This template controls the creation of the database name of an instance. This"},{"line_number":530,"context_line":"is *not* the display name you enter when creating an instance (via Horizon"},{"line_number":531,"context_line":"or CLI). It is very unlikely that you have to change this option. If you"},{"line_number":532,"context_line":"already have instances in your deployment when you change this, your"},{"line_number":533,"context_line":"deployment will break."},{"line_number":534,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_8945a271","line":531,"range":{"start_line":531,"start_character":9,"end_line":531,"end_character":64},"in_reply_to":"9ad45d7e_d42bcbe9","updated":"2016-08-10 07:46:12.000000000","message":"@alaski: Yep, good idea. I\u0027ll rephrase that in ps9.","commit_id":"7d600f495d8ce256fbfd8c1632e7a783280963e1"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c63d764a0a686c79260cde364c1ddfdf9d5e6f4b","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                help\u003d\"\"\""},{"line_number":509,"context_line":"Enable new services on this host automatically."},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"When a new service (for example \"nova-compute\") gets started, it gets"},{"line_number":512,"context_line":"registered in the database as an enabled service. Sometimes it can be useful"},{"line_number":513,"context_line":"to register new services in disabled state and then enabled them in a later"},{"line_number":514,"context_line":"point in time. This option can set this behavior for all services per host."}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_7cbf21aa","line":511,"updated":"2016-08-10 20:39:07.000000000","message":"s/gets started/starts up/","commit_id":"aec47d3cc5b9c5ed6b8c12ea8e5d21537bcf6350"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"04f98a3b27a2da4dbac19a8b8614bdddb636f158","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                help\u003d\"\"\""},{"line_number":509,"context_line":"Enable new services on this host automatically."},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"When a new service (for example \"nova-compute\") gets started, it gets"},{"line_number":512,"context_line":"registered in the database as an enabled service. Sometimes it can be useful"},{"line_number":513,"context_line":"to register new services in disabled state and then enabled them in a later"},{"line_number":514,"context_line":"point in time. This option can set this behavior for all services per host."}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_68e3bfd9","line":511,"in_reply_to":"9ad45d7e_7cbf21aa","updated":"2016-08-11 11:21:34.000000000","message":"Done","commit_id":"aec47d3cc5b9c5ed6b8c12ea8e5d21537bcf6350"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c63d764a0a686c79260cde364c1ddfdf9d5e6f4b","unresolved":false,"context_lines":[{"line_number":510,"context_line":""},{"line_number":511,"context_line":"When a new service (for example \"nova-compute\") gets started, it gets"},{"line_number":512,"context_line":"registered in the database as an enabled service. Sometimes it can be useful"},{"line_number":513,"context_line":"to register new services in disabled state and then enabled them in a later"},{"line_number":514,"context_line":"point in time. This option can set this behavior for all services per host."},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_dcde0d10","line":513,"updated":"2016-08-10 20:39:07.000000000","message":"s/enabled/enable/\ns/in a later/at a later/","commit_id":"aec47d3cc5b9c5ed6b8c12ea8e5d21537bcf6350"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"04f98a3b27a2da4dbac19a8b8614bdddb636f158","unresolved":false,"context_lines":[{"line_number":510,"context_line":""},{"line_number":511,"context_line":"When a new service (for example \"nova-compute\") gets started, it gets"},{"line_number":512,"context_line":"registered in the database as an enabled service. Sometimes it can be useful"},{"line_number":513,"context_line":"to register new services in disabled state and then enabled them in a later"},{"line_number":514,"context_line":"point in time. This option can set this behavior for all services per host."},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_88071381","line":513,"in_reply_to":"9ad45d7e_dcde0d10","updated":"2016-08-11 11:21:34.000000000","message":"Done","commit_id":"aec47d3cc5b9c5ed6b8c12ea8e5d21537bcf6350"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5a5e68e9581318b7467cae9ac447b0b0bccb21dd","unresolved":false,"context_lines":[{"line_number":522,"context_line":"\"\"\"),"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    cfg.StrOpt(\u0027instance_name_template\u0027,"},{"line_number":525,"context_line":"               default\u003d\u0027instance-%08x\u0027,"},{"line_number":526,"context_line":"               help\u003d\"\"\""},{"line_number":527,"context_line":"Template string to be used to generate instance names."},{"line_number":528,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_064874cb","line":525,"range":{"start_line":525,"start_character":23,"end_line":525,"end_character":38},"updated":"2016-08-10 11:21:05.000000000","message":"question: is it not possible to change the default to a more sensible option anyway? Surely this will only affect new users, as existing ones will have existing nova.conf files with the above setting?","commit_id":"aec47d3cc5b9c5ed6b8c12ea8e5d21537bcf6350"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"4340e7f067a67de25c21ad0daec81b3feaa82433","unresolved":false,"context_lines":[{"line_number":522,"context_line":"\"\"\"),"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    cfg.StrOpt(\u0027instance_name_template\u0027,"},{"line_number":525,"context_line":"               default\u003d\u0027instance-%08x\u0027,"},{"line_number":526,"context_line":"               help\u003d\"\"\""},{"line_number":527,"context_line":"Template string to be used to generate instance names."},{"line_number":528,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_7623d9a7","line":525,"range":{"start_line":525,"start_character":23,"end_line":525,"end_character":38},"in_reply_to":"9ad45d7e_064874cb","updated":"2016-08-10 12:35:33.000000000","message":"It would affect people who do not have this option explicitly set in their nova.conf.\n\nI\u0027ve mulled this over a bit before and at some point I would like to persist this value as part of an instance record so that changes to the config would not affect currently running instances. But doing that will take a bit of effort.","commit_id":"aec47d3cc5b9c5ed6b8c12ea8e5d21537bcf6350"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e1362207c862c83c87299b7c40684952a6b25f0b","unresolved":false,"context_lines":[{"line_number":522,"context_line":"\"\"\"),"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    cfg.StrOpt(\u0027instance_name_template\u0027,"},{"line_number":525,"context_line":"               default\u003d\u0027instance-%08x\u0027,"},{"line_number":526,"context_line":"               help\u003d\"\"\""},{"line_number":527,"context_line":"Template string to be used to generate instance names."},{"line_number":528,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_ccfcb174","line":525,"range":{"start_line":525,"start_character":23,"end_line":525,"end_character":38},"in_reply_to":"9ad45d7e_7623d9a7","updated":"2016-08-10 14:34:31.000000000","message":"+1 alaski\u0027s comment.","commit_id":"aec47d3cc5b9c5ed6b8c12ea8e5d21537bcf6350"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"7b5bf452efa19decf4a659502e8755f5dcfeb07f","unresolved":false,"context_lines":[{"line_number":554,"context_line":"    # should remove it completely."},{"line_number":555,"context_line":"    cfg.StrOpt(\u0027snapshot_name_template\u0027,"},{"line_number":556,"context_line":"               default\u003d\u0027snapshot-%s\u0027,"},{"line_number":557,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":558,"context_line":"               deprecated_reason\u003d\u0027This is not used anymore and will be \u0027"},{"line_number":559,"context_line":"                                 \u0027removed in the O release.\u0027,"},{"line_number":560,"context_line":"               help\u003d\u0027Template string to be used to generate snapshot names\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_9c7f75aa","line":557,"range":{"start_line":557,"start_character":15,"end_line":557,"end_character":37},"updated":"2016-08-10 20:47:04.000000000","message":"This option requires a reno to deprecate it.","commit_id":"aec47d3cc5b9c5ed6b8c12ea8e5d21537bcf6350"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"04f98a3b27a2da4dbac19a8b8614bdddb636f158","unresolved":false,"context_lines":[{"line_number":554,"context_line":"    # should remove it completely."},{"line_number":555,"context_line":"    cfg.StrOpt(\u0027snapshot_name_template\u0027,"},{"line_number":556,"context_line":"               default\u003d\u0027snapshot-%s\u0027,"},{"line_number":557,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":558,"context_line":"               deprecated_reason\u003d\u0027This is not used anymore and will be \u0027"},{"line_number":559,"context_line":"                                 \u0027removed in the O release.\u0027,"},{"line_number":560,"context_line":"               help\u003d\u0027Template string to be used to generate snapshot names\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_c8aaab84","line":557,"range":{"start_line":557,"start_character":15,"end_line":557,"end_character":37},"in_reply_to":"9ad45d7e_9c7f75aa","updated":"2016-08-11 11:21:34.000000000","message":"You\u0027re right, although it doesn\u0027t get used anywhere anymore, the upgrade process is impacted when this gets removed. Will add a reno in ps10.","commit_id":"aec47d3cc5b9c5ed6b8c12ea8e5d21537bcf6350"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c63d764a0a686c79260cde364c1ddfdf9d5e6f4b","unresolved":false,"context_lines":[{"line_number":557,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":558,"context_line":"               deprecated_reason\u003d\u0027This is not used anymore and will be \u0027"},{"line_number":559,"context_line":"                                 \u0027removed in the O release.\u0027,"},{"line_number":560,"context_line":"               help\u003d\u0027Template string to be used to generate snapshot names\u0027)"},{"line_number":561,"context_line":"]"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_bce359d8","line":560,"updated":"2016-08-10 20:39:07.000000000","message":"Nice catch :)","commit_id":"aec47d3cc5b9c5ed6b8c12ea8e5d21537bcf6350"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c63d764a0a686c79260cde364c1ddfdf9d5e6f4b","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            running_deleted_opts +"},{"line_number":571,"context_line":"            instance_cleaning_opts +"},{"line_number":572,"context_line":"            rpcapi_opts +"},{"line_number":573,"context_line":"            dp_opts)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_1ce545db","line":573,"updated":"2016-08-10 20:39:07.000000000","message":"Any reason you changed this to dp instead of db?","commit_id":"aec47d3cc5b9c5ed6b8c12ea8e5d21537bcf6350"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"04f98a3b27a2da4dbac19a8b8614bdddb636f158","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            running_deleted_opts +"},{"line_number":571,"context_line":"            instance_cleaning_opts +"},{"line_number":572,"context_line":"            rpcapi_opts +"},{"line_number":573,"context_line":"            dp_opts)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_e81e8f0a","line":573,"in_reply_to":"9ad45d7e_1ce545db","updated":"2016-08-11 11:21:34.000000000","message":"whops, no, that should definitely be \"db\". will fix it in ps10","commit_id":"aec47d3cc5b9c5ed6b8c12ea8e5d21537bcf6350"}]}