)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"5432d303411d408857cbce1ea38d5f889596a112","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The part of code responsible to release serial ports does not cover"},{"line_number":10,"context_line":"all the cases. This commit moves that part inside the method _destroy"},{"line_number":11,"context_line":"which is responsable to destroy the guest from a libvirt perspective"},{"line_number":12,"context_line":"which is when we want to release ports."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I24f2a1fa3b7ef3f2a3196f3689e5f2ba7d49bd87"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_cd015b3a","line":11,"range":{"start_line":11,"start_character":9,"end_line":11,"end_character":31},"updated":"2016-04-06 14:40:31.000000000","message":"responsible of destroying","commit_id":"9d57c0db5669ef5661f1cbf4f8b25176d463ea70"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"d889f98a14822d8d09b85311342694eb608e6f38","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-25 06:45:53 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: release serial console ports when before to destroy guests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The part of code responsible to release serial ports does not cover"},{"line_number":10,"context_line":"all the cases. This commit moves that part inside the method _destroy"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_76c28a54","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":43},"updated":"2016-04-27 09:01:32.000000000","message":"remove when","commit_id":"5c878de833a194a70491c7a8f1e5c3304881e650"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"0ca88e8fefa197a0063dd0c0c2e8c6906f9eb044","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-25 06:45:53 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: release serial console ports when before to destroy guests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The part of code responsible to release serial ports does not cover"},{"line_number":10,"context_line":"all the cases. This commit moves that part inside the method _destroy"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_37bd1503","line":7,"updated":"2016-05-03 14:18:40.000000000","message":"s/when before to detroy/when destroying/","commit_id":"5c878de833a194a70491c7a8f1e5c3304881e650"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"0ca88e8fefa197a0063dd0c0c2e8c6906f9eb044","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The part of code responsible to release serial ports does not cover"},{"line_number":10,"context_line":"all the cases. This commit moves that part inside the method _destroy"},{"line_number":11,"context_line":"which is responsable to destroy the guest from a libvirt perspective"},{"line_number":12,"context_line":"which is when we want to release ports."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I24f2a1fa3b7ef3f2a3196f3689e5f2ba7d49bd87"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_17ba990a","line":11,"updated":"2016-05-03 14:18:40.000000000","message":"s/to destroy/for destroying/","commit_id":"5c878de833a194a70491c7a8f1e5c3304881e650"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ac865c797bb457043cddb31886276cb2482c34a6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The part of code responsible to release serial ports does not cover"},{"line_number":10,"context_line":"all the cases. This commit moves that part inside the method _destroy"},{"line_number":11,"context_line":"which is responsable for destroying the guest from a libvirt"},{"line_number":12,"context_line":"perspective which is when we want to release ports."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I24f2a1fa3b7ef3f2a3196f3689e5f2ba7d49bd87"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_bc143c4d","line":11,"range":{"start_line":11,"start_character":9,"end_line":11,"end_character":20},"updated":"2016-05-04 13:47:04.000000000","message":"responsible","commit_id":"1e9e06bae972a5db4a126a7068f903e0328b84ed"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"fd60b29b88e76ec8f9974c66727647d9a4047076","unresolved":false,"context_lines":[{"line_number":3499,"context_line":"        mock_release_port.assert_has_calls("},{"line_number":3500,"context_line":"            [mock.call(host\u003d\u0027127.0.0.1\u0027, port\u003d10000),"},{"line_number":3501,"context_line":"             mock.call(host\u003d\u0027127.0.0.1\u0027, port\u003d10001)])"},{"line_number":3502,"context_line":""},{"line_number":3503,"context_line":"    @mock.patch(\u0027os.path.getsize\u0027, return_value\u003d0)  # size doesn\u0027t matter"},{"line_number":3504,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.storage.lvm.get_volume_size\u0027,"},{"line_number":3505,"context_line":"                return_value\u003d\u0027fake-size\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_d7164ff0","line":3502,"updated":"2016-04-05 13:12:40.000000000","message":"Would an additional test case which calls \"reboot\" multiple times make sense here? Without an increase of items in (a mocked) ``console.serial.ALLOCATED_PORTS`` as expected result?","commit_id":"9d57c0db5669ef5661f1cbf4f8b25176d463ea70"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"025fd620b7d0c7b4dd8cb210750fd624359ce00a","unresolved":false,"context_lines":[{"line_number":3499,"context_line":"        mock_release_port.assert_has_calls("},{"line_number":3500,"context_line":"            [mock.call(host\u003d\u0027127.0.0.1\u0027, port\u003d10000),"},{"line_number":3501,"context_line":"             mock.call(host\u003d\u0027127.0.0.1\u0027, port\u003d10001)])"},{"line_number":3502,"context_line":""},{"line_number":3503,"context_line":"    @mock.patch(\u0027os.path.getsize\u0027, return_value\u003d0)  # size doesn\u0027t matter"},{"line_number":3504,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.storage.lvm.get_volume_size\u0027,"},{"line_number":3505,"context_line":"                return_value\u003d\u0027fake-size\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_95dbef4e","line":3502,"in_reply_to":"9a061dce_d7164ff0","updated":"2016-04-06 13:39:05.000000000","message":"Yes, we can probably do something like that","commit_id":"9d57c0db5669ef5661f1cbf4f8b25176d463ea70"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"5432d303411d408857cbce1ea38d5f889596a112","unresolved":false,"context_lines":[{"line_number":899,"context_line":"            if CONF.serial_console.enabled:"},{"line_number":900,"context_line":"                # This method is called for several events like; destroy,"},{"line_number":901,"context_line":"                # rebuild, hard-reboot, power-off - For all of these"},{"line_number":902,"context_line":"                # events we want to release the serial ports acquires for"},{"line_number":903,"context_line":"                # the guest before to destroy it."},{"line_number":904,"context_line":"                serials \u003d self._get_serial_ports_from_guest(guest)"},{"line_number":905,"context_line":"                for hostname, port in serials:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_42e4faaa","line":902,"range":{"start_line":902,"start_character":61,"end_line":902,"end_character":69},"updated":"2016-04-06 14:40:31.000000000","message":"acquired","commit_id":"9d57c0db5669ef5661f1cbf4f8b25176d463ea70"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"5432d303411d408857cbce1ea38d5f889596a112","unresolved":false,"context_lines":[{"line_number":900,"context_line":"                # This method is called for several events like; destroy,"},{"line_number":901,"context_line":"                # rebuild, hard-reboot, power-off - For all of these"},{"line_number":902,"context_line":"                # events we want to release the serial ports acquires for"},{"line_number":903,"context_line":"                # the guest before to destroy it."},{"line_number":904,"context_line":"                serials \u003d self._get_serial_ports_from_guest(guest)"},{"line_number":905,"context_line":"                for hostname, port in serials:"},{"line_number":906,"context_line":"                    serial_console.release_port(host\u003dhostname, port\u003dport)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_0d5eb311","line":903,"range":{"start_line":903,"start_character":28,"end_line":903,"end_character":49},"updated":"2016-04-06 14:40:31.000000000","message":"I think a better wording would be \"before destroying it\".","commit_id":"9d57c0db5669ef5661f1cbf4f8b25176d463ea70"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"0ca88e8fefa197a0063dd0c0c2e8c6906f9eb044","unresolved":false,"context_lines":[{"line_number":903,"context_line":"        try:"},{"line_number":904,"context_line":"            guest \u003d self._host.get_guest(instance)"},{"line_number":905,"context_line":"            if CONF.serial_console.enabled:"},{"line_number":906,"context_line":"                # This method is called for several events like; destroy,"},{"line_number":907,"context_line":"                # rebuild, hard-reboot, power-off - For all of these"},{"line_number":908,"context_line":"                # events we want to release the serial ports acquires for"},{"line_number":909,"context_line":"                # the guest before to destroy it."}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_7735cda6","line":906,"updated":"2016-05-03 14:18:40.000000000","message":"s/events like; /events: /","commit_id":"5c878de833a194a70491c7a8f1e5c3304881e650"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"0ca88e8fefa197a0063dd0c0c2e8c6906f9eb044","unresolved":false,"context_lines":[{"line_number":905,"context_line":"            if CONF.serial_console.enabled:"},{"line_number":906,"context_line":"                # This method is called for several events like; destroy,"},{"line_number":907,"context_line":"                # rebuild, hard-reboot, power-off - For all of these"},{"line_number":908,"context_line":"                # events we want to release the serial ports acquires for"},{"line_number":909,"context_line":"                # the guest before to destroy it."},{"line_number":910,"context_line":"                serials \u003d self._get_serial_ports_from_guest(guest)"},{"line_number":911,"context_line":"                for hostname, port in serials:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_573a5199","line":908,"updated":"2016-05-03 14:18:40.000000000","message":"s/acquires/acquired/","commit_id":"5c878de833a194a70491c7a8f1e5c3304881e650"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"0ca88e8fefa197a0063dd0c0c2e8c6906f9eb044","unresolved":false,"context_lines":[{"line_number":906,"context_line":"                # This method is called for several events like; destroy,"},{"line_number":907,"context_line":"                # rebuild, hard-reboot, power-off - For all of these"},{"line_number":908,"context_line":"                # events we want to release the serial ports acquires for"},{"line_number":909,"context_line":"                # the guest before to destroy it."},{"line_number":910,"context_line":"                serials \u003d self._get_serial_ports_from_guest(guest)"},{"line_number":911,"context_line":"                for hostname, port in serials:"},{"line_number":912,"context_line":"                    serial_console.release_port(host\u003dhostname, port\u003dport)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_b73f6586","line":909,"updated":"2016-05-03 14:18:40.000000000","message":"s/to destroy/destroying/","commit_id":"5c878de833a194a70491c7a8f1e5c3304881e650"}]}