)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d0c8d0e6294305915dedb5c81dc37472c48cf1ec","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"As a convenience, we add two properties to the PciDevice object that"},{"line_number":15,"context_line":"take care of fetching related objects without worrying about missing or"},{"line_number":16,"context_line":"unset values."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"We also clarify a bit more how to use PciDevTracker.pci_devs attribute"},{"line_number":19,"context_line":"and why we can\u0027t just randomly fish PciDevices out of the DB for the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"bab6814e_07a0c19e","line":16,"updated":"2016-05-18 15:59:37.000000000","message":"Remove the above part of the commit message since this was done in a previous patch.","commit_id":"c1bfb2bdd63128f405096c39c89b6f419cebbc37"}],"nova/objects/pci_device.py":[{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"b7b1e458b258d49efd3bc2c628cb536e14c5064c","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                if parent.status \u003d\u003d fields.PciDeviceStatus.AVAILABLE:"},{"line_number":309,"context_line":"                    parent.status \u003d fields.PciDeviceStatus.UNCLAIMABLE"},{"line_number":310,"context_line":"            else:"},{"line_number":311,"context_line":"                LOG.debug(\u0027Physical function addr: %(pf_addr)s parent of \u0027"},{"line_number":312,"context_line":"                            \u0027VF addr: %(vf_addr)s was not found\u0027,"},{"line_number":313,"context_line":"                            {\u0027pf_addr\u0027: self.parent_addr,"},{"line_number":314,"context_line":"                                \u0027vf_addr\u0027: self.address})"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_da7d0fe9","line":311,"updated":"2016-04-15 16:56:45.000000000","message":"Is this a debug ?  Maybe I\u0027m wrong, I haven\u0027t following closely the implementation of PF-VF relationship.\n\nIf the device is SRIOV_VF I think it should have a valid parent.  In this case and error should be reported.","commit_id":"13438f46a05cd9baa4332ec46a902f699ae0ff14"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"71ae80dcc3dd49c776ec60c67f43844ff8265e60","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                if parent.status \u003d\u003d fields.PciDeviceStatus.AVAILABLE:"},{"line_number":309,"context_line":"                    parent.status \u003d fields.PciDeviceStatus.UNCLAIMABLE"},{"line_number":310,"context_line":"            else:"},{"line_number":311,"context_line":"                LOG.debug(\u0027Physical function addr: %(pf_addr)s parent of \u0027"},{"line_number":312,"context_line":"                            \u0027VF addr: %(vf_addr)s was not found\u0027,"},{"line_number":313,"context_line":"                            {\u0027pf_addr\u0027: self.parent_addr,"},{"line_number":314,"context_line":"                                \u0027vf_addr\u0027: self.address})"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_31fc8571","line":311,"in_reply_to":"1a122d0e_da7d0fe9","updated":"2016-04-20 10:54:51.000000000","message":"Not necessarily - the parent may not be whitelisted and therefore not be in the pci_devs","commit_id":"13438f46a05cd9baa4332ec46a902f699ae0ff14"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"94c2543491ed439493f6dc9a9e9266923c852fba","unresolved":false,"context_lines":[{"line_number":410,"context_line":"            if not parent:"},{"line_number":411,"context_line":"                LOG.debug(\u0027Physical function addr: %(pf_addr)s parent of \u0027"},{"line_number":412,"context_line":"                          \u0027VF addr: %(vf_addr)s was not found\u0027,"},{"line_number":413,"context_line":"                           {\u0027pf_addr\u0027: self.parent_addr,"},{"line_number":414,"context_line":"                            \u0027vf_addr\u0027: self.address})"},{"line_number":415,"context_line":"            else:"},{"line_number":416,"context_line":"                vfs_list \u003d parent.child_devices"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_e9fc8840","line":413,"updated":"2016-05-18 11:27:02.000000000","message":"Hum perhaps the problem comes from here, if we don\"t have a parent the field parent_addr won\u0027t probably be set","commit_id":"147badfb697a5f92bc51b7fd1a94a8886da87266"}]}
