)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"66cf711f79357d2110db53c81caef3ff5dda0b7f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The get_by_project_id method of InstanceMappingList was not previously"},{"line_number":10,"context_line":"updated to account for backrefs being added. This fixes that, and brings"},{"line_number":11,"context_line":"the actual method in line with the unit test. The method was broken"},{"line_number":12,"context_line":"before but it was not exposed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5ca7549bdb1a91011494bc9eb64ca350ca275b54"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_fa551c50","line":12,"updated":"2016-04-05 20:56:28.000000000","message":"The method is used in the next patch in this series which would fail if the method was still broken.","commit_id":"011ee16b12cf4a59594278335d783c61395adc9d"}],"nova/objects/instance_mapping.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c3b0ff46507036353d096148c8e5b211a48610e8","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    @db_api.api_context_manager.reader"},{"line_number":144,"context_line":"    def _get_by_project_id_from_db(context, project_id):"},{"line_number":145,"context_line":"        return (context.session.query(api_models.InstanceMapping)"},{"line_number":146,"context_line":"                .options(joinedload(\u0027cell_mapping\u0027))"},{"line_number":147,"context_line":"                .filter("},{"line_number":148,"context_line":"                    api_models.InstanceMapping.project_id \u003d\u003d project_id)).all()"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_cc9bf816","line":146,"updated":"2016-04-20 11:13:56.000000000","message":"fixing a problem missing an UT is okay, but I\u0027d like to see it providing the test then honestly...","commit_id":"a7464120c78d4c3dae0ca39077b2e28e42f4b87f"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"908f2655bb00f818fdd034881cd70a727a3d4131","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    @db_api.api_context_manager.reader"},{"line_number":144,"context_line":"    def _get_by_project_id_from_db(context, project_id):"},{"line_number":145,"context_line":"        return (context.session.query(api_models.InstanceMapping)"},{"line_number":146,"context_line":"                .options(joinedload(\u0027cell_mapping\u0027))"},{"line_number":147,"context_line":"                .filter("},{"line_number":148,"context_line":"                    api_models.InstanceMapping.project_id \u003d\u003d project_id)).all()"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_26f2719a","line":146,"in_reply_to":"1a122d0e_c6ad7dea","updated":"2016-04-20 17:56:35.000000000","message":"Yes, this is functionally tested in the followup change. There\u0027s a unit test that tests the caller of this method and mocks it out, but the mock return didn\u0027t match what this is actually returning. It\u0027s not going to be easy to unit test at the level of mocking out what sqlalchemy returns, that\u0027s more the realm of a functional test. Which is what the next patch provides.\n\nReally this method was added too soon since nothing was using it yet. The failure was in not waiting until it was needed, and therefore used.","commit_id":"a7464120c78d4c3dae0ca39077b2e28e42f4b87f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"522fe9729861947eaeb903c24ecdb3753caf6f37","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    @db_api.api_context_manager.reader"},{"line_number":144,"context_line":"    def _get_by_project_id_from_db(context, project_id):"},{"line_number":145,"context_line":"        return (context.session.query(api_models.InstanceMapping)"},{"line_number":146,"context_line":"                .options(joinedload(\u0027cell_mapping\u0027))"},{"line_number":147,"context_line":"                .filter("},{"line_number":148,"context_line":"                    api_models.InstanceMapping.project_id \u003d\u003d project_id)).all()"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_c6ad7dea","line":146,"in_reply_to":"1a122d0e_cc9bf816","updated":"2016-04-20 17:47:10.000000000","message":"I think the point is that this is used in the following change.","commit_id":"a7464120c78d4c3dae0ca39077b2e28e42f4b87f"}]}