)]}'
{"nova/network/security_group/neutron_driver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0a2691f6a4e0eea3cae27192f97ac93e12d8cfc3","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            group \u003d neutron.show_security_group(id).get(\u0027security_group\u0027)"},{"line_number":147,"context_line":"            # requested name should match with the server\u0027s security group name"},{"line_number":148,"context_line":"            if name and name !\u003d group[\u0027name\u0027]:"},{"line_number":149,"context_line":"                return None"},{"line_number":150,"context_line":"            return self._convert_to_nova_security_group_format(group)"},{"line_number":151,"context_line":"        except n_exc.NeutronClientNoUniqueMatch as e:"},{"line_number":152,"context_line":"            raise exception.NoUniqueMatch(six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_2e115eb0","line":149,"updated":"2016-07-08 15:42:13.000000000","message":"This seems odd here, we should either raise like we didn\u0027t find it SecurityGroupNotFound or just make sure we use the updated name in future.\n\nReturning None doesn\u0027t quite make sense to me.","commit_id":"91708a1c600e8dabfd34cc107e411216c6914298"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dd9d562d3636ca05d152bc4320c7c0e741487281","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            group \u003d neutron.show_security_group(id).get(\u0027security_group\u0027)"},{"line_number":147,"context_line":"            # requested name should match with the server\u0027s security group name"},{"line_number":148,"context_line":"            if name and name !\u003d group[\u0027name\u0027]:"},{"line_number":149,"context_line":"                return None"},{"line_number":150,"context_line":"            return self._convert_to_nova_security_group_format(group)"},{"line_number":151,"context_line":"        except n_exc.NeutronClientNoUniqueMatch as e:"},{"line_number":152,"context_line":"            raise exception.NoUniqueMatch(six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_42e8fb16","line":149,"in_reply_to":"1aa78d24_2e115eb0","updated":"2016-07-08 15:46:40.000000000","message":"I don\u0027t like this either, it\u0027s relying on this:\n\nhttps://github.com/openstack/nova/blob/master/nova/compute/api.py#L416\n\nWhich is pretty nasty tight coupling IMO.","commit_id":"91708a1c600e8dabfd34cc107e411216c6914298"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"20ee0f3153ffa53c91ac442243a96ab9bd32b8e5","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            group \u003d neutron.show_security_group(id).get(\u0027security_group\u0027)"},{"line_number":147,"context_line":"            # requested name should match with the server\u0027s security group name"},{"line_number":148,"context_line":"            if name and name !\u003d group[\u0027name\u0027]:"},{"line_number":149,"context_line":"                return None"},{"line_number":150,"context_line":"            return self._convert_to_nova_security_group_format(group)"},{"line_number":151,"context_line":"        except n_exc.NeutronClientNoUniqueMatch as e:"},{"line_number":152,"context_line":"            raise exception.NoUniqueMatch(six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_623ff7d6","line":149,"in_reply_to":"1aa78d24_42e8fb16","updated":"2016-07-08 15:58:25.000000000","message":"yuck, I was worried thats what it was doing. I see that now.","commit_id":"91708a1c600e8dabfd34cc107e411216c6914298"}]}