)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"974a6ec3f2789e51531919e4efb8add59872d59d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Config options: Centralize vif \u0026 vol_utils options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change moves config options from"},{"line_number":10,"context_line":"vif.py and volume_utils.py"},{"line_number":11,"context_line":"to centralize location"},{"line_number":12,"context_line":"nova/conf/xenserver.py"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a122d0e_26732d17","line":10,"updated":"2016-05-03 13:28:51.000000000","message":"Please also move \"use_join_force\" from [1]. That\u0027s the last xen related config option which needs to move.\n\n[1] https://github.com/openstack/nova/blob/master/nova/virt/xenapi/pool.py#L35","commit_id":"126783f875b88db836dcc9fdbaa68c2e89fbadda"}],"nova/conf/xenserver.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"112f61d553b375bddaf605720c1af60d183b471a","unresolved":false,"context_lines":[{"line_number":362,"context_line":"    default\u003d\u0027xapi1\u0027,"},{"line_number":363,"context_line":"    help\u003d\u0027Name of Integration Bridge used by Open vSwitch\u0027)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"xenapi_ovs_integration_bridge_opts \u003d [ovs_integration_bridge]"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"xenapi_pool_opts \u003d ["},{"line_number":368,"context_line":"    cfg.BoolOpt(\u0027use_join_force\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_d59e5462","line":365,"range":{"start_line":365,"start_character":37,"end_line":365,"end_character":61},"updated":"2016-05-03 16:54:00.000000000","message":"nit: You could just use this in line 381 instead of creating a new variable.","commit_id":"39f0e067c25ba4fc491033a12cd872bd3244825a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2de966be633b0b6922ae69a6b9a5adcc69e8b040","unresolved":false,"context_lines":[{"line_number":362,"context_line":"    default\u003d\u0027xapi1\u0027,"},{"line_number":363,"context_line":"    help\u003d\u0027Name of Integration Bridge used by Open vSwitch\u0027)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"xenapi_ovs_integration_bridge_opts \u003d [ovs_integration_bridge]"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"xenapi_pool_opts \u003d ["},{"line_number":368,"context_line":"    cfg.BoolOpt(\u0027use_join_force\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_b45d7aee","line":365,"range":{"start_line":365,"start_character":37,"end_line":365,"end_character":61},"in_reply_to":"1a122d0e_d59e5462","updated":"2016-05-04 12:07:27.000000000","message":"+1, but we can tidy that later.","commit_id":"39f0e067c25ba4fc491033a12cd872bd3244825a"}],"nova/virt/opts.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"974a6ec3f2789e51531919e4efb8add59872d59d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"             nova.virt.libvirt.volume.scality.volume_opts,"},{"line_number":58,"context_line":"             nova.virt.libvirt.volume.smbfs.volume_opts,"},{"line_number":59,"context_line":"         )),"},{"line_number":60,"context_line":"        (\u0027xenserver\u0027,"},{"line_number":61,"context_line":"         itertools.chain("},{"line_number":62,"context_line":"             nova.virt.xenapi.pool.xenapi_pool_opts,"},{"line_number":63,"context_line":"         )),"},{"line_number":64,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_86c5e10b","line":63,"range":{"start_line":60,"start_character":0,"end_line":63,"end_character":12},"updated":"2016-05-03 13:28:51.000000000","message":"This whole block can be removed when you move \"use_join_force\" too.","commit_id":"126783f875b88db836dcc9fdbaa68c2e89fbadda"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2de966be633b0b6922ae69a6b9a5adcc69e8b040","unresolved":false,"context_lines":[{"line_number":59,"context_line":"             nova.virt.libvirt.volume.scality.volume_opts,"},{"line_number":60,"context_line":"             nova.virt.libvirt.volume.smbfs.volume_opts,"},{"line_number":61,"context_line":"         )),"},{"line_number":62,"context_line":"        (\u0027xenserver\u0027,"},{"line_number":63,"context_line":"         itertools.chain("},{"line_number":64,"context_line":"             [nova.virt.xenapi.vif.xenapi_ovs_integration_bridge_opt],"},{"line_number":65,"context_line":"             nova.virt.xenapi.pool.xenapi_pool_opts,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_741ac218","side":"PARENT","line":62,"updated":"2016-05-04 12:07:27.000000000","message":"we might need to rebase on top of the libvirt chain of patches, lets see who wins.","commit_id":"b69296eb74edab12de161fce50e3a65ea18172f0"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"5c16538af6c8a75c646360ece2ecb273d5d9fd78","unresolved":false,"context_lines":[{"line_number":59,"context_line":"             nova.virt.libvirt.volume.scality.volume_opts,"},{"line_number":60,"context_line":"             nova.virt.libvirt.volume.smbfs.volume_opts,"},{"line_number":61,"context_line":"         )),"},{"line_number":62,"context_line":"        (\u0027xenserver\u0027,"},{"line_number":63,"context_line":"         itertools.chain("},{"line_number":64,"context_line":"             [nova.virt.xenapi.vif.xenapi_ovs_integration_bridge_opt],"},{"line_number":65,"context_line":"             nova.virt.xenapi.pool.xenapi_pool_opts,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_d28121fd","side":"PARENT","line":62,"in_reply_to":"1a122d0e_741ac218","updated":"2016-05-04 14:06:54.000000000","message":"As the libvirt change series is bigger, I\u0027d prefer that libvirt wins. Should be the less overall effort.","commit_id":"b69296eb74edab12de161fce50e3a65ea18172f0"}]}