)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"33eba31e085edae8a907429f067ef1c0df8446ff","unresolved":false,"context_lines":[{"line_number":405,"context_line":"            local_instances \u003d self.conductor_api.instance_get_all_by_filters("},{"line_number":406,"context_line":"                    context, filters, columns_to_join\u003d[])"},{"line_number":407,"context_line":"            local_instance_uuids \u003d [inst[\u0027uuid\u0027] for inst in local_instances]"},{"line_number":408,"context_line":"            for uuid in set(driver_uuids) - set(local_instance_uuids):"},{"line_number":409,"context_line":"                LOG.error(_(\u0027Instance %(uuid)s found in the hypervisor, but \u0027"},{"line_number":410,"context_line":"                            \u0027not in the database\u0027), locals())"},{"line_number":411,"context_line":"            return local_instances"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASn%2F%2F%2B7k%3D","side":"PARENT","line":408,"updated":"2013-08-27 07:57:44.000000000","message":"I met an issue: https://bugs.launchpad.net/nova/+bug/1217222","commit_id":"e06ab5877462c83f6574b0304331e3ff906ddb14"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"960bd6ae2d4aef45e8dc27e1f78b8e771b4f2a26","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            local_instance_uuids \u003d [inst[\u0027uuid\u0027] for inst in local_instances]"},{"line_number":408,"context_line":"            for uuid in set(driver_uuids) - set(local_instance_uuids):"},{"line_number":409,"context_line":"                LOG.error(_(\u0027Instance %(uuid)s found in the hypervisor, but \u0027"},{"line_number":410,"context_line":"                            \u0027not in the database\u0027), locals())"},{"line_number":411,"context_line":"            return local_instances"},{"line_number":412,"context_line":"        except NotImplementedError:"},{"line_number":413,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FeXo%3D","side":"PARENT","line":410,"updated":"2013-06-02 23:37:09.000000000","message":"So if the issue is that the instance is running, but it may be deleted, perhaps the wording should just be tweaked?\n\n\"but not listed as a running instance in the database\" ?","commit_id":"e06ab5877462c83f6574b0304331e3ff906ddb14"},{"author":{"_account_id":1882,"name":"dave-mcnally","email":"dave.mcnally@hpe.com","username":"dave-mcnally"},"change_message_id":"968102f881df63219e9704154ed5732ebb5072a4","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            local_instance_uuids \u003d [inst[\u0027uuid\u0027] for inst in local_instances]"},{"line_number":408,"context_line":"            for uuid in set(driver_uuids) - set(local_instance_uuids):"},{"line_number":409,"context_line":"                LOG.error(_(\u0027Instance %(uuid)s found in the hypervisor, but \u0027"},{"line_number":410,"context_line":"                            \u0027not in the database\u0027), locals())"},{"line_number":411,"context_line":"            return local_instances"},{"line_number":412,"context_line":"        except NotImplementedError:"},{"line_number":413,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fd%2B0%3D","side":"PARENT","line":410,"in_reply_to":"AAAAPH%2F%2FeXo%3D","updated":"2013-06-03 07:56:56.000000000","message":"That\u0027s only the issue if the calling function specifies deleted\u003dtrue in the filters. And in both of the functions that currently call this method they log if the results they get back don\u0027t match expectations.\n\nThis function (without additional logic) would never know if it was filtering for deleted instances, or any other type, or even if the results it got were not as expected. So it could only ever provide a vague info type message and could never reliably log a definite error.","commit_id":"e06ab5877462c83f6574b0304331e3ff906ddb14"}]}