)]}'
{"nova/tests/virt/vmwareapi/test_vmwareapi.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"d1d90787cdc6ac6f6eef9bdf19965744ce949e56","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        vm_util.get_vm_state_from_name(mox.IgnoreArg(),"},{"line_number":349,"context_line":"            self.instance[\u0027name\u0027]).AndReturn(\"poweredOff\")"},{"line_number":350,"context_line":"        self.conn.reboot(mox.IgnoreArg(), self.instance, \u0027network_info\u0027,"},{"line_number":351,"context_line":"        \u0027hard\u0027, None)"},{"line_number":352,"context_line":"        self.mox.ReplayAll()"},{"line_number":353,"context_line":"        self.conn.resume_state_on_host_boot(context, self.instance,"},{"line_number":354,"context_line":"            \u0027network_info\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F5QU%3D","line":351,"updated":"2013-06-06 15:41:47.000000000","message":"indent","commit_id":"bd7d3c757b34e388265e229e33580c3dae1ee255"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"186ee77705554ca420c673b5b00c049d3100778f","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        self.mox.StubOutWithMock(vm_util, \u0027get_vm_state_from_name\u0027)"},{"line_number":360,"context_line":"        vm_util.get_vm_state_from_name(mox.IgnoreArg(),"},{"line_number":361,"context_line":"            self.instance[\u0027name\u0027]).AndReturn(\"poweredOn\")"},{"line_number":362,"context_line":"        self.mox.ReplayAll()"},{"line_number":363,"context_line":"        self.conn.resume_state_on_host_boot(context, self.instance,"},{"line_number":364,"context_line":"            \u0027network_info\u0027)"},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2Fy2Y%3D","line":362,"updated":"2013-06-10 14:46:32.000000000","message":"Nice tests.  But I think you need the \u0027self.mox.StubOutWithMock(self.conn, \"reboot\")\u0027 line or mox won\u0027t complain if you call reboot().","commit_id":"b48618723815b3ba4f953252bfd3b3424f67796b"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4d952a526c3b4f53c759793c40b831aeefab27b9","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        # Check if the instance is running already and avoid doing"},{"line_number":229,"context_line":"        # anything if it is."},{"line_number":230,"context_line":"        instances \u003d self.list_instances()"},{"line_number":231,"context_line":"        print instances"},{"line_number":232,"context_line":"        if instance[\u0027uuid\u0027] not in instances:"},{"line_number":233,"context_line":"            LOG.warn(_(\u0027Instance can not be found in host, or in an unknown\u0027"},{"line_number":234,"context_line":"                \u0027state.\u0027), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPn%2F%2Fvh4%3D","line":231,"updated":"2013-06-23 12:59:05.000000000","message":"please remove the print out","commit_id":"43f93f63521f3b6bc48d424b30048cbc322b3842"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a640c334685298ad4b481d3b7af5b27564f65baa","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        # anything if it is."},{"line_number":237,"context_line":"        instances \u003d self.list_instances()"},{"line_number":238,"context_line":"        if instance[\u0027uuid\u0027] not in instances:"},{"line_number":239,"context_line":"            LOG.warn(_(\u0027Instance can not be found in host, or in an unknown\u0027"},{"line_number":240,"context_line":"                \u0027state.\u0027), instance\u003dinstance)"},{"line_number":241,"context_line":"        else:"},{"line_number":242,"context_line":"            state \u003d vm_util.get_vm_state_from_name(self._session,"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAPn%2F%2Ff84%3D","line":239,"updated":"2013-06-29 05:59:58.000000000","message":"nit: cannot","commit_id":"dbe0e2b0b1551793a55da09d45e45163a0b878b3"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a640c334685298ad4b481d3b7af5b27564f65baa","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        instances \u003d self.list_instances()"},{"line_number":238,"context_line":"        if instance[\u0027uuid\u0027] not in instances:"},{"line_number":239,"context_line":"            LOG.warn(_(\u0027Instance can not be found in host, or in an unknown\u0027"},{"line_number":240,"context_line":"                \u0027state.\u0027), instance\u003dinstance)"},{"line_number":241,"context_line":"        else:"},{"line_number":242,"context_line":"            state \u003d vm_util.get_vm_state_from_name(self._session,"},{"line_number":243,"context_line":"                instance[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAPn%2F%2Ff80%3D","line":240,"updated":"2013-06-29 05:59:58.000000000","message":"instance\u003dinstance?","commit_id":"dbe0e2b0b1551793a55da09d45e45163a0b878b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"dd18ce477f90a45a46cfe9be8c80d8a0e51f1e5e","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        instances \u003d self.list_instances()"},{"line_number":238,"context_line":"        if instance[\u0027uuid\u0027] not in instances:"},{"line_number":239,"context_line":"            LOG.warn(_(\u0027Instance can not be found in host, or in an unknown\u0027"},{"line_number":240,"context_line":"                \u0027state.\u0027), instance\u003dinstance)"},{"line_number":241,"context_line":"        else:"},{"line_number":242,"context_line":"            state \u003d vm_util.get_vm_state_from_name(self._session,"},{"line_number":243,"context_line":"                instance[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAPn%2F%2Ff4g%3D","line":240,"in_reply_to":"AAAAPn%2F%2Ff80%3D","updated":"2013-06-29 06:22:22.000000000","message":"https://github.com/openstack/oslo-incubator/blob/master/openstack/common/log.py#L262","commit_id":"dbe0e2b0b1551793a55da09d45e45163a0b878b3"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"5ba959f4a930b67c29f534ea9e077874372a910d","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"def get_vm_state_from_name(session, vm_name):"},{"line_number":503,"context_line":"    vm_ref \u003d get_vm_ref_from_name(session, vm_name)"},{"line_number":504,"context_line":"    vm_state \u003d session._call_method(vim_util, \"get_dynamic_property\","},{"line_number":505,"context_line":"                vm_ref, \"VirtualMachine\", \"runtime.powerState\")"},{"line_number":506,"context_line":"    return vm_state"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FrCo%3D","line":503,"updated":"2013-05-27 23:33:01.000000000","message":"This might be a dumb question but can\u0027t there be duplicate names?","commit_id":"c72dca892a511a22f4a2cf5d82ad6e3f035908d6"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"021fd278482fb82b15d3b62ee9de50b9277d976d","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"def get_vm_state_from_name(session, vm_name):"},{"line_number":503,"context_line":"    vm_ref \u003d get_vm_ref_from_name(session, vm_name)"},{"line_number":504,"context_line":"    vm_state \u003d session._call_method(vim_util, \"get_dynamic_property\","},{"line_number":505,"context_line":"                vm_ref, \"VirtualMachine\", \"runtime.powerState\")"},{"line_number":506,"context_line":"    return vm_state"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F9YU%3D","line":503,"in_reply_to":"AAAAPH%2F%2FgIw%3D","updated":"2013-06-05 05:07:37.000000000","message":"i see the first name that matches returns. In get_vm_ref_from_name() above... out of scope for the patch though.","commit_id":"c72dca892a511a22f4a2cf5d82ad6e3f035908d6"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"e2b077cec8681c5915cb80508351701bd38afdcd","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"def get_vm_state_from_name(session, vm_name):"},{"line_number":503,"context_line":"    vm_ref \u003d get_vm_ref_from_name(session, vm_name)"},{"line_number":504,"context_line":"    vm_state \u003d session._call_method(vim_util, \"get_dynamic_property\","},{"line_number":505,"context_line":"                vm_ref, \"VirtualMachine\", \"runtime.powerState\")"},{"line_number":506,"context_line":"    return vm_state"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FgIw%3D","line":503,"in_reply_to":"AAAAPH%2F%2FrCo%3D","updated":"2013-05-31 18:42:44.000000000","message":"If so, that situation doesn\u0027t seem to be changed by this patch","commit_id":"c72dca892a511a22f4a2cf5d82ad6e3f035908d6"}]}