)]}'
{"tox.ini":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17ecf1ce218aee2b56aa516532d0ed8230775f74","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# there is also secret magic in pretty_tox.sh which lets you run in a fail only"},{"line_number":26,"context_line":"# mode. To do this define the TRACE_FAILONLY environmental variable."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"[tox:jenkins]"},{"line_number":29,"context_line":"downloadcache \u003d ~/cache/pip"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[testenv:common-constraints]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9a061dce_5708ad28","side":"PARENT","line":28,"updated":"2016-04-08 15:42:36.000000000","message":"This is an unrelated removal from a separate change in mitaka, I\u0027d be OK with backporting it, but technically it shouldn\u0027t be in here unless we want to call it out or squash them or something.","commit_id":"eec8bb9c04e6096379ff31907e40228f062211fb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17ecf1ce218aee2b56aa516532d0ed8230775f74","unresolved":false,"context_lines":[{"line_number":152,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":153,"context_line":"       OS_TEST_PATH\u003d./nova/tests/functional"},{"line_number":154,"context_line":"       LANGUAGE\u003den_US"},{"line_number":155,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":156,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":157,"context_line":"commands \u003d"},{"line_number":158,"context_line":"  find . -type f -name \"*.pyc\" -delete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9a061dce_f79e21b7","side":"PARENT","line":155,"updated":"2016-04-08 15:42:36.000000000","message":"Looks like this is coming from some other change too.","commit_id":"eec8bb9c04e6096379ff31907e40228f062211fb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"669ebfa5c39df2c6b000f7f1bb211b711db87654","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 1.8"},{"line_number":3,"context_line":"envlist \u003d py34,py27,functional,pep8,pip-missing-reqs"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"9a061dce_cbc09e2d","line":2,"updated":"2016-04-08 14:52:11.000000000","message":"Per https://review.openstack.org/#/c/267095/ this should be 2.0 so we should also backport https://review.openstack.org/#/c/267095/ right?","commit_id":"6511ffabd7680605439fb6b66339e484f9a34696"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17ecf1ce218aee2b56aa516532d0ed8230775f74","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 1.8"},{"line_number":3,"context_line":"envlist \u003d py34,py27,functional,pep8,pip-missing-reqs"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"9a061dce_172595ad","line":2,"in_reply_to":"9a061dce_cbc09e2d","updated":"2016-04-08 15:42:36.000000000","message":"OK that change is stacked on top of this series now.","commit_id":"6511ffabd7680605439fb6b66339e484f9a34696"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"0b73d2cdc1384217e3cec4d18f110e40f223ba46","unresolved":false,"context_lines":[{"line_number":9,"context_line":"whitelist_externals \u003d bash"},{"line_number":10,"context_line":"                      find"},{"line_number":11,"context_line":"                      rm"},{"line_number":12,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":13,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":14,"context_line":"         OS_TEST_PATH\u003d./nova/tests/unit"},{"line_number":15,"context_line":"         LANGUAGE\u003den_US"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9a061dce_cdf42989","line":12,"range":{"start_line":12,"start_character":98,"end_line":12,"end_character":151},"updated":"2016-04-08 17:58:02.000000000","message":"Oh, the CI system overrides this, it would be broken on local though.","commit_id":"6511ffabd7680605439fb6b66339e484f9a34696"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17ecf1ce218aee2b56aa516532d0ed8230775f74","unresolved":false,"context_lines":[{"line_number":9,"context_line":"whitelist_externals \u003d bash"},{"line_number":10,"context_line":"                      find"},{"line_number":11,"context_line":"                      rm"},{"line_number":12,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":13,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":14,"context_line":"         OS_TEST_PATH\u003d./nova/tests/unit"},{"line_number":15,"context_line":"         LANGUAGE\u003den_US"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9a061dce_9c5d4a4b","line":12,"updated":"2016-04-08 15:42:36.000000000","message":"Why doesn\u0027t this have ?h\u003dstable/liberty on the URL?","commit_id":"6511ffabd7680605439fb6b66339e484f9a34696"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"098e6db36e9e399ab3dd4ba6ffd7ca0e9adaacf6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"whitelist_externals \u003d bash"},{"line_number":10,"context_line":"                      find"},{"line_number":11,"context_line":"                      rm"},{"line_number":12,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":13,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":14,"context_line":"         OS_TEST_PATH\u003d./nova/tests/unit"},{"line_number":15,"context_line":"         LANGUAGE\u003den_US"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9a061dce_37aff995","line":12,"in_reply_to":"9a061dce_9c5d4a4b","updated":"2016-04-08 15:45:54.000000000","message":"It must work without it because of env:UPPER_CONSTRAINTS_FILE in the Jenkins CI jobs because I see in the py27 job it\u0027s pulling in oslo.messaging 2.5.0 which is stable/liberty upper-constraints and master is way newer, but still, it\u0027d be wrong if you ran this locally and didn\u0027t have that env var.","commit_id":"6511ffabd7680605439fb6b66339e484f9a34696"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17ecf1ce218aee2b56aa516532d0ed8230775f74","unresolved":false,"context_lines":[{"line_number":167,"context_line":"commands \u003d bandit -c bandit.yaml -r nova -n 5 -ll"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"[testenv:releasenotes]"},{"line_number":170,"context_line":"install_command \u003d pip install -U --force-reinstall {opts} {packages}"},{"line_number":171,"context_line":"commands \u003d sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/ht"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"[flake8]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9a061dce_b78ca980","line":170,"updated":"2016-04-08 15:42:36.000000000","message":"We should include the note from the original change:\n\n# NOTE(sdague): this target does not use constraints because\n# upstream infra does not yet support it. Once that\u0027s fixed, we can\n# drop the install_command.","commit_id":"6511ffabd7680605439fb6b66339e484f9a34696"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"210f9d3283969d3cb72e6da0d71f259d746d4911","unresolved":false,"context_lines":[{"line_number":9,"context_line":"whitelist_externals \u003d bash"},{"line_number":10,"context_line":"                      find"},{"line_number":11,"context_line":"                      rm"},{"line_number":12,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":13,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":14,"context_line":"         OS_TEST_PATH\u003d./nova/tests/unit"},{"line_number":15,"context_line":"         LANGUAGE\u003den_US"}],"source_content_type":"text/x-properties","patch_set":3,"id":"9a061dce_9cd9c086","line":12,"updated":"2016-04-08 18:34:33.000000000","message":"You dropped the stable/liberty from the URL in ps2.","commit_id":"70f30db42bbf37e2aa4acf1218fd6b566ac4afa6"}]}