)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"d02cb0434e096122afd839dfa79b71c2916278ae","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Power architectures (arch.PPC64LE and arch.PPC64) support huge pages and"},{"line_number":10,"context_line":"transparent huge page. This patch just enable it on nova libvirt driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"As requested in the first review, this patch also includes a reno"},{"line_number":13,"context_line":"feature entry."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This feature also fix a bug in launchpad:"},{"line_number":16,"context_line":"https://bugs.launchpad.net/nova/+bug/1617081"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_8b482089","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":14},"updated":"2016-08-29 08:10:00.000000000","message":"It will be enough to say that reno note was also added","commit_id":"cf1f1b5d55db3176c820b418671de2dc62ec683f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d456e1ce4af67aca713d0750d15179eb3108cfa","unresolved":false,"context_lines":[{"line_number":12,"context_line":"As requested in the first review, this patch also includes a reno"},{"line_number":13,"context_line":"feature entry."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This feature also fix a bug in launchpad:"},{"line_number":16,"context_line":"https://bugs.launchpad.net/nova/+bug/1617081"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I22bc57a0b244667c716a54ca37c175f26a87a1e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_bb71ab78","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":44},"updated":"2016-08-29 10:56:47.000000000","message":"Instead of this, add the below line after the \u0027Change-Id\u0027 line\n\n    Closes-bug: #1617801\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"cf1f1b5d55db3176c820b418671de2dc62ec683f"},{"author":{"_account_id":12340,"name":"Vincent Jardin","email":"vincent.jardin@6wind.com","username":"vjardin"},"change_message_id":"42eec62818b68fe6daac4fb37dd8cd1c785b2bd1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This change also enables the test_does_want_hugepages unit test to run on the"},{"line_number":14,"context_line":"architectures that support huge pages."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-bug: #1617801"},{"line_number":17,"context_line":"Change-Id: I22bc57a0b244667c716a54ca37c175f26a87a1e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa7ab95a_3a1c2077","line":16,"updated":"2016-08-31 10:10:09.000000000","message":"There is a typo here, it is not the right bug:\n\nhttps://launchpad.net/bugs/1617801\n  vs\nhttps://launchpad.net/bugs/1617081","commit_id":"84f5a2e73ab7f631a41134c27598f7760565bf35"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"d02cb0434e096122afd839dfa79b71c2916278ae","unresolved":false,"context_lines":[{"line_number":5113,"context_line":"    def _has_hugepage_support(self):"},{"line_number":5114,"context_line":"        # This means that the host can support multiple values for the size"},{"line_number":5115,"context_line":"        # field in LibvirtConfigGuestMemoryBackingPage"},{"line_number":5116,"context_line":"        supported_archs \u003d [arch.I686, arch.X86_64, arch.PPC64LE, arch.PPC64]"},{"line_number":5117,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5118,"context_line":"        return ((caps.host.cpu.arch in supported_archs) and"},{"line_number":5119,"context_line":"                self._host.has_min_version(MIN_LIBVIRT_HUGEPAGE_VERSION,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_4eed4624","line":5116,"range":{"start_line":5116,"start_character":8,"end_line":5116,"end_character":76},"updated":"2016-08-29 08:10:00.000000000","message":"I wonder, do we have unit tests for that?","commit_id":"cf1f1b5d55db3176c820b418671de2dc62ec683f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d456e1ce4af67aca713d0750d15179eb3108cfa","unresolved":false,"context_lines":[{"line_number":5113,"context_line":"    def _has_hugepage_support(self):"},{"line_number":5114,"context_line":"        # This means that the host can support multiple values for the size"},{"line_number":5115,"context_line":"        # field in LibvirtConfigGuestMemoryBackingPage"},{"line_number":5116,"context_line":"        supported_archs \u003d [arch.I686, arch.X86_64, arch.PPC64LE, arch.PPC64]"},{"line_number":5117,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5118,"context_line":"        return ((caps.host.cpu.arch in supported_archs) and"},{"line_number":5119,"context_line":"                self._host.has_min_version(MIN_LIBVIRT_HUGEPAGE_VERSION,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_5b241f5f","line":5116,"range":{"start_line":5116,"start_character":8,"end_line":5116,"end_character":76},"in_reply_to":"fa7ab95a_4eed4624","updated":"2016-08-29 10:56:47.000000000","message":"Could you move this to a constant at the top of the file?","commit_id":"cf1f1b5d55db3176c820b418671de2dc62ec683f"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"e5ed1fa47303b4508bc5671edf62e81a77ef4c84","unresolved":false,"context_lines":[{"line_number":5113,"context_line":"    def _has_hugepage_support(self):"},{"line_number":5114,"context_line":"        # This means that the host can support multiple values for the size"},{"line_number":5115,"context_line":"        # field in LibvirtConfigGuestMemoryBackingPage"},{"line_number":5116,"context_line":"        supported_archs \u003d [arch.I686, arch.X86_64, arch.PPC64LE, arch.PPC64]"},{"line_number":5117,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5118,"context_line":"        return ((caps.host.cpu.arch in supported_archs) and"},{"line_number":5119,"context_line":"                self._host.has_min_version(MIN_LIBVIRT_HUGEPAGE_VERSION,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_ccf873c6","line":5116,"range":{"start_line":5116,"start_character":8,"end_line":5116,"end_character":76},"in_reply_to":"fa7ab95a_4eed4624","updated":"2016-08-29 11:54:08.000000000","message":"Easy enough to check. No, there are no tests for this method in nova/tests/unit/virt/libvirt/test_driver.py","commit_id":"cf1f1b5d55db3176c820b418671de2dc62ec683f"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"e5ed1fa47303b4508bc5671edf62e81a77ef4c84","unresolved":false,"context_lines":[{"line_number":5113,"context_line":"    def _has_hugepage_support(self):"},{"line_number":5114,"context_line":"        # This means that the host can support multiple values for the size"},{"line_number":5115,"context_line":"        # field in LibvirtConfigGuestMemoryBackingPage"},{"line_number":5116,"context_line":"        supported_archs \u003d [arch.I686, arch.X86_64, arch.PPC64LE, arch.PPC64]"},{"line_number":5117,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5118,"context_line":"        return ((caps.host.cpu.arch in supported_archs) and"},{"line_number":5119,"context_line":"                self._host.has_min_version(MIN_LIBVIRT_HUGEPAGE_VERSION,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_a10ed838","line":5116,"range":{"start_line":5116,"start_character":8,"end_line":5116,"end_character":76},"in_reply_to":"fa7ab95a_5b241f5f","updated":"2016-08-29 11:54:08.000000000","message":"I don\u0027t think that this should be moved in this patch. It is only used here, and already exists here.","commit_id":"cf1f1b5d55db3176c820b418671de2dc62ec683f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"294d53e674b820cd2abe7eb9b05d6749ce5c9b6a","unresolved":false,"context_lines":[{"line_number":5113,"context_line":"    def _has_hugepage_support(self):"},{"line_number":5114,"context_line":"        # This means that the host can support multiple values for the size"},{"line_number":5115,"context_line":"        # field in LibvirtConfigGuestMemoryBackingPage"},{"line_number":5116,"context_line":"        supported_archs \u003d [arch.I686, arch.X86_64, arch.PPC64LE, arch.PPC64]"},{"line_number":5117,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5118,"context_line":"        return ((caps.host.cpu.arch in supported_archs) and"},{"line_number":5119,"context_line":"                self._host.has_min_version(MIN_LIBVIRT_HUGEPAGE_VERSION,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_5e2015f8","line":5116,"range":{"start_line":5116,"start_character":51,"end_line":5116,"end_character":75},"updated":"2016-09-13 17:22:34.000000000","message":"These aren\u0027t restricted by version, or at least, a different version from x86?","commit_id":"abc24acfa1982a0ffccbe08a006ac7c7a9f4ecda"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"bed48310bd2dea4683a0b480995c27e9096b1fa3","unresolved":false,"context_lines":[{"line_number":5113,"context_line":"    def _has_hugepage_support(self):"},{"line_number":5114,"context_line":"        # This means that the host can support multiple values for the size"},{"line_number":5115,"context_line":"        # field in LibvirtConfigGuestMemoryBackingPage"},{"line_number":5116,"context_line":"        supported_archs \u003d [arch.I686, arch.X86_64, arch.PPC64LE, arch.PPC64]"},{"line_number":5117,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5118,"context_line":"        return ((caps.host.cpu.arch in supported_archs) and"},{"line_number":5119,"context_line":"                self._host.has_min_version(MIN_LIBVIRT_HUGEPAGE_VERSION,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_ec1d9ebe","line":5116,"range":{"start_line":5116,"start_character":51,"end_line":5116,"end_character":75},"in_reply_to":"7a8ec9b2_5e2015f8","updated":"2016-09-14 07:36:26.000000000","message":"A quick check of qemu 2.1.0 (MIN_QEMU_PPC64_VERSION) and libvirt 1.2.12 (MIN_LIBVIRT_KVM_PPC64_VERSION) looks like they\u0027ll work with huge pages.\n\nWe\u0027re kinda lucky because:\n MIN_QEMU_PPC64_VERSION  \u003d\u003d  MIN_QEMU_NUMA_HUGEPAGE_VERSION ; and\n MIN_LIBVIRT_KVM_PPC64_VERSION \u003e MIN_LIBVIRT_HUGEPAGE_VERSION\n\nSo we wont even start on ppc64 if we don\u0027t meet the hugepage minimum requirements.","commit_id":"abc24acfa1982a0ffccbe08a006ac7c7a9f4ecda"}],"releasenotes/notes/libvirt_ppc64le_hugepage_support-b9fd39cf20c8e91d.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d456e1ce4af67aca713d0750d15179eb3108cfa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - This is a feature to enable huge page for POWER architectures. Both PPC64"},{"line_number":4,"context_line":"    and PPC64LE architectures support both Huge Page, as transparent huge"},{"line_number":5,"context_line":"    pages, thus, it is time to enable it on libvirt driver. driver. driver."},{"line_number":6,"context_line":"    driver. driver. driver."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa7ab95a_bb952b88","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":31},"updated":"2016-08-29 10:56:47.000000000","message":"nit: Just say \u0027Enable huge pages for...\u0027","commit_id":"cf1f1b5d55db3176c820b418671de2dc62ec683f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d456e1ce4af67aca713d0750d15179eb3108cfa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - This is a feature to enable huge page for POWER architectures. Both PPC64"},{"line_number":4,"context_line":"    and PPC64LE architectures support both Huge Page, as transparent huge"},{"line_number":5,"context_line":"    pages, thus, it is time to enable it on libvirt driver. driver. driver."},{"line_number":6,"context_line":"    driver. driver. driver."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa7ab95a_3bd75b4c","line":4,"range":{"start_line":4,"start_character":30,"end_line":4,"end_character":53},"updated":"2016-08-29 10:56:47.000000000","message":"nit: support hugepages as...?","commit_id":"cf1f1b5d55db3176c820b418671de2dc62ec683f"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"d02cb0434e096122afd839dfa79b71c2916278ae","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - This is a feature to enable huge page for POWER architectures. Both PPC64"},{"line_number":4,"context_line":"    and PPC64LE architectures support both Huge Page, as transparent huge"},{"line_number":5,"context_line":"    pages, thus, it is time to enable it on libvirt driver. driver. driver."},{"line_number":6,"context_line":"    driver. driver. driver."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa7ab95a_2b647420","line":6,"range":{"start_line":5,"start_character":52,"end_line":6,"end_character":27},"updated":"2016-08-29 08:10:00.000000000","message":"what is it?:)","commit_id":"cf1f1b5d55db3176c820b418671de2dc62ec683f"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"e5ed1fa47303b4508bc5671edf62e81a77ef4c84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa7ab95a_cc94f344","line":7,"updated":"2016-08-29 11:54:08.000000000","message":"Suggested wording:\n\n\"Added hugepage support for POWER architectures.\"","commit_id":"cf1f1b5d55db3176c820b418671de2dc62ec683f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"137f6688e1b6817dc490efeb337fad2eb2bdb3da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa7ab95a_ca5ad0f1","line":7,"in_reply_to":"fa7ab95a_cc94f344","updated":"2016-08-30 09:48:32.000000000","message":"Yeah, much better :)","commit_id":"cf1f1b5d55db3176c820b418671de2dc62ec683f"}]}