)]}'
{"nova/api/ec2/cloud.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"b238f9da30a57b1d2e19e5cd379d92e07c48777e","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def delete_snapshot(self, context, snapshot_id, **kwargs):"},{"line_number":371,"context_line":"        snapshot_id \u003d ec2utils.ec2_id_to_id(snapshot_id)"},{"line_number":372,"context_line":"        snapshot \u003d self.volume_api.get(context, snapshot_id)"},{"line_number":373,"context_line":"        self.volume_api.delete_snapshot(context, snapshot)"},{"line_number":374,"context_line":"        return True"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2BME%3D","line":372,"updated":"2012-01-13 22:16:03.000000000","message":"should be get_snapshot()","commit_id":"dded0b72bb2f456e8da0ea31b3c597feadb733f3"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"3180cd91f0465e48d38466339e4278a96ee2d365","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def delete_snapshot(self, context, snapshot_id, **kwargs):"},{"line_number":371,"context_line":"        snapshot_id \u003d ec2utils.ec2_id_to_id(snapshot_id)"},{"line_number":372,"context_line":"        snapshot \u003d self.volume_api.get(context, snapshot_id)"},{"line_number":373,"context_line":"        self.volume_api.delete_snapshot(context, snapshot)"},{"line_number":374,"context_line":"        return True"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2BLI%3D","line":372,"in_reply_to":"AAAAD3%2F%2F%2BME%3D","updated":"2012-01-13 23:26:47.000000000","message":"Done","commit_id":"dded0b72bb2f456e8da0ea31b3c597feadb733f3"}],"nova/compute/manager.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"b238f9da30a57b1d2e19e5cd379d92e07c48777e","unresolved":false,"context_lines":[{"line_number":1871,"context_line":"        # Restore volume state"},{"line_number":1872,"context_line":"        for volume_ref in instance_ref[\u0027volumes\u0027]:"},{"line_number":1873,"context_line":"            volume_id \u003d volume_ref[\u0027id\u0027]"},{"line_number":1874,"context_line":"            self.volume_api.update(ctxt, volume_id, {\u0027status\u0027: \u0027in-use\u0027})"},{"line_number":1875,"context_line":""},{"line_number":1876,"context_line":"        # No instance booting at source host, but instance dir"},{"line_number":1877,"context_line":"        # must be deleted for preparing next block migration"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2BLU%3D","line":1874,"updated":"2012-01-13 22:16:03.000000000","message":"You changed this to accept a ref in volume_api.","commit_id":"dded0b72bb2f456e8da0ea31b3c597feadb733f3"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"3180cd91f0465e48d38466339e4278a96ee2d365","unresolved":false,"context_lines":[{"line_number":1871,"context_line":"        # Restore volume state"},{"line_number":1872,"context_line":"        for volume_ref in instance_ref[\u0027volumes\u0027]:"},{"line_number":1873,"context_line":"            volume_id \u003d volume_ref[\u0027id\u0027]"},{"line_number":1874,"context_line":"            self.volume_api.update(ctxt, volume_id, {\u0027status\u0027: \u0027in-use\u0027})"},{"line_number":1875,"context_line":""},{"line_number":1876,"context_line":"        # No instance booting at source host, but instance dir"},{"line_number":1877,"context_line":"        # must be deleted for preparing next block migration"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2BLE%3D","line":1874,"in_reply_to":"AAAAD3%2F%2F%2BLU%3D","updated":"2012-01-13 23:26:47.000000000","message":"Done","commit_id":"dded0b72bb2f456e8da0ea31b3c597feadb733f3"}],"nova/volume/api.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"b238f9da30a57b1d2e19e5cd379d92e07c48777e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                 {\"method\": \"delete_volume\","},{"line_number":114,"context_line":"                  \"args\": {\"volume_id\": volume_id}})"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def update(self, context, volume, fields):"},{"line_number":117,"context_line":"        self.db.volume_update(context, volume[\u0027id\u0027], fields)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def get(self, context, volume_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2BLk%3D","line":116,"updated":"2012-01-13 22:16:03.000000000","message":"this one is still being called with volume_id i saw.","commit_id":"dded0b72bb2f456e8da0ea31b3c597feadb733f3"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"3180cd91f0465e48d38466339e4278a96ee2d365","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                 {\"method\": \"delete_volume\","},{"line_number":114,"context_line":"                  \"args\": {\"volume_id\": volume_id}})"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def update(self, context, volume, fields):"},{"line_number":117,"context_line":"        self.db.volume_update(context, volume[\u0027id\u0027], fields)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def get(self, context, volume_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2BLA%3D","line":116,"in_reply_to":"AAAAD3%2F%2F%2BLk%3D","updated":"2012-01-13 23:26:47.000000000","message":"I don\u0027t see any more places that volume.api.API.update is being called with an id. However, the db methods do still use id. Maybe you got the two mixed up?","commit_id":"dded0b72bb2f456e8da0ea31b3c597feadb733f3"}],"nova/vsa/manager.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"b238f9da30a57b1d2e19e5cd379d92e07c48777e","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                        locals())"},{"line_number":137,"context_line":"            if status \u003d\u003d \u0027available\u0027:"},{"line_number":138,"context_line":"                try:"},{"line_number":139,"context_line":"                    # self.volume_api.update(context, volume,"},{"line_number":140,"context_line":"                    #                   dict(attach_status\u003d\"attached\"))"},{"line_number":141,"context_line":"                    pass"},{"line_number":142,"context_line":"                except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2BLg%3D","line":139,"updated":"2012-01-13 22:16:03.000000000","message":"Ah, here\u0027s a case where you\u0027re passing the ref, not the id.","commit_id":"dded0b72bb2f456e8da0ea31b3c597feadb733f3"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"3180cd91f0465e48d38466339e4278a96ee2d365","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                        locals())"},{"line_number":137,"context_line":"            if status \u003d\u003d \u0027available\u0027:"},{"line_number":138,"context_line":"                try:"},{"line_number":139,"context_line":"                    # self.volume_api.update(context, volume,"},{"line_number":140,"context_line":"                    #                   dict(attach_status\u003d\"attached\"))"},{"line_number":141,"context_line":"                    pass"},{"line_number":142,"context_line":"                except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2BK8%3D","line":139,"in_reply_to":"AAAAD3%2F%2F%2BLg%3D","updated":"2012-01-13 23:26:47.000000000","message":"Right...that\u0027s the idea. And this appears to be dead code... What should I do here?","commit_id":"dded0b72bb2f456e8da0ea31b3c597feadb733f3"}]}