)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f401490f8adc9fc806409f9578b16da75fded5d4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix swap_volume to use attached vol_id to get BDM"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently swap_volume uses the \"serial\" of the connection as"},{"line_number":10,"context_line":"the volume_id to use when retrieving the BDM. The serial will never"},{"line_number":11,"context_line":"change from the *original* volume that was attached, so after the"},{"line_number":12,"context_line":"the first swap, the volume_id being used won\u0027t match anything that\u0027s"},{"line_number":13,"context_line":"attached to the VM and the BDM retrieval will fail. Instead we should"},{"line_number":14,"context_line":"always use the ID of the volume that was attached at the time swap"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a18252c_9dfae741","line":11,"range":{"start_line":10,"start_character":46,"end_line":11,"end_character":51},"updated":"2016-04-14 14:02:20.000000000","message":"Isn\u0027t that the bug really, which is actually a problem here?\n\nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4892\n\ni.e. should we just always set this?\n\n  old_cinfo[\u0027serial\u0027] \u003d old_volume_id\n\nRather than check to see if it\u0027s in old_cinfo first?\n\nThe problem I have with this change is that it\u0027s working around a bug in the compute manager code for the libvirt driver, but if other virt drivers in nova implemented swap_volume they could have the same issue.","commit_id":"1bb29a450ae4bb5e2f3719d99592289131e08475"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"dbf721b8d1508cf2b86eaa7e003019344fef6867","unresolved":false,"context_lines":[{"line_number":16,"context_line":"previously attached volume_id."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I594801d110f5a81142d6840cc4c6efe58ad71be3"},{"line_number":19,"context_line":"Closes-Bug: #1569419"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_57834398","line":19,"range":{"start_line":19,"start_character":12,"end_line":19,"end_character":20},"updated":"2016-04-19 01:38:29.000000000","message":"This bug report has been marked as duplicate.","commit_id":"8aa8f34b80f7a4ae92a42f302c642fcdd982c42a"}]}