)]}'
{"nova/tests/unit/api/openstack/compute/legacy_v2/test_extensions.py":[{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"ade9abba287a1831b7b858aa8168ed22f359ee9f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    def test_extension_authorizer_throws_exception_if_policy_fails(self,"},{"line_number":150,"context_line":"                                                             mock_enforce):"},{"line_number":151,"context_line":"        rule \u003d \"compute_extension:used_limits_for_admin\""},{"line_number":152,"context_line":"        mock_enforce.side_effect \u003d exception.PolicyNotAuthorized(action\u003drule)"},{"line_number":153,"context_line":"        authorize \u003d base_extensions.extension_authorizer("},{"line_number":154,"context_line":"            \u0027compute\u0027, \u0027used_limits_for_admin\u0027)"},{"line_number":155,"context_line":"        self.assertRaises(exception.PolicyNotAuthorized, authorize,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_c1b9277b","line":152,"updated":"2016-04-19 18:55:36.000000000","message":"Can we move the common code to a method. I see that only rule and authorize parameters are changing for the tests.\n\nBoth ways work, but I think this makes the code look more neat.","commit_id":"02c1d9b1fa45313c2e1981fe0beac3151df0d88e"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"94bc5f839813d4f0c60bb440ea81427ecff854ff","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    def test_extension_authorizer_throws_exception_if_policy_fails(self,"},{"line_number":150,"context_line":"                                                             mock_enforce):"},{"line_number":151,"context_line":"        rule \u003d \"compute_extension:used_limits_for_admin\""},{"line_number":152,"context_line":"        mock_enforce.side_effect \u003d exception.PolicyNotAuthorized(action\u003drule)"},{"line_number":153,"context_line":"        authorize \u003d base_extensions.extension_authorizer("},{"line_number":154,"context_line":"            \u0027compute\u0027, \u0027used_limits_for_admin\u0027)"},{"line_number":155,"context_line":"        self.assertRaises(exception.PolicyNotAuthorized, authorize,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_77e6d6e8","line":152,"in_reply_to":"1a122d0e_c1b9277b","updated":"2016-04-20 17:19:10.000000000","message":"Done","commit_id":"02c1d9b1fa45313c2e1981fe0beac3151df0d88e"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"7edfaa0a57ce965612361151561fca579a578495","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            ext_list.append(fox)"},{"line_number":143,"context_line":"            self.flags(osapi_compute_extension\u003dext_list)"},{"line_number":144,"context_line":"        self.fake_context \u003d nova.context.RequestContext(\u0027fake\u0027, \u0027fake\u0027)"},{"line_number":145,"context_line":"        self.target \u003d {\u0027project_id\u0027: \u00271234\u0027,"},{"line_number":146,"context_line":"                       \u0027user_id\u0027: \u00275678\u0027}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _test_authorizer_throws_exception_if_policy_fails(self,"},{"line_number":149,"context_line":"                                               rule, authorize):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_53b89775","line":146,"range":{"start_line":145,"start_character":0,"end_line":146,"end_character":41},"updated":"2016-05-03 20:23:47.000000000","message":"Logic looks fine, but I would we can define target variable local to_test_authorizer_throws_exception_if_policy_fails() method. Is there any particular reason for declaring it at as a class/instance variable?","commit_id":"860416c7fa1ad647026c9dc0393204f32a2fe80e"}]}