)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"107db067b79d17cab53706651c1a8f070e599efa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Riedemann \u003cmriedem@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-05-24 14:18:45 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set resized instance back to original vm_state (1 of 2)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"You can resize an instance when it\u0027s in the ACTIVE or STOPPED state but"},{"line_number":10,"context_line":"the code currently always finishes the resize (either confirmed or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPH%2F%2FtCo%3D","line":7,"updated":"2013-05-24 22:50:18.000000000","message":"This (and the rest of the commit message) Should indicate what you\u0027re doing here. That would be \"adding a power_on flag to the virt resize blah blah method\". You can mention that it\u0027s needed for bug 1177811 or whatever, but the fact that the other is dependent on this one is plenty.","commit_id":"00100546c99dc58b6b47bf8e0ab949cc982597ef"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b664ce95991eb1d25247098ddbe7bce98b739e7b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Riedemann \u003cmriedem@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-05-24 14:18:45 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set resized instance back to original vm_state (1 of 2)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"You can resize an instance when it\u0027s in the ACTIVE or STOPPED state but"},{"line_number":10,"context_line":"the code currently always finishes the resize (either confirmed or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPH%2F%2Fs80%3D","line":7,"in_reply_to":"AAAAPH%2F%2FtCo%3D","updated":"2013-05-25 01:23:04.000000000","message":"Done","commit_id":"00100546c99dc58b6b47bf8e0ab949cc982597ef"}],"nova/tests/test_vmwareapi.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"107db067b79d17cab53706651c1a8f070e599efa","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        pass"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def instance_type_get(self, context, instance_type_id):"},{"line_number":94,"context_line":"        pass"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"class VMwareAPIConfTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FtC0%3D","line":94,"updated":"2013-05-24 22:50:18.000000000","message":"Why replicate this here? Use the FakeVirtAPI already provided in virt.fake.","commit_id":"00100546c99dc58b6b47bf8e0ab949cc982597ef"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b56360c82d878a86d2c555e336a94ab9ecf155bf","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        pass"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def instance_type_get(self, context, instance_type_id):"},{"line_number":94,"context_line":"        pass"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"class VMwareAPIConfTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fs70%3D","line":94,"in_reply_to":"AAAAPH%2F%2FtC0%3D","updated":"2013-05-25 01:49:40.000000000","message":"Not sure that I knew about it, but will use it now.","commit_id":"00100546c99dc58b6b47bf8e0ab949cc982597ef"},{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"be8b2f180382480cfe898e2e61e7f09ee1c2c336","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        vmwareapi_fake.reset()"},{"line_number":153,"context_line":"        db_fakes.stub_out_db_instance_api(self.stubs)"},{"line_number":154,"context_line":"        stubs.set_stubs(self.stubs)"},{"line_number":155,"context_line":"        self.conn \u003d driver.VMwareVCDriver(FakeVirtAPI())"},{"line_number":156,"context_line":"        # NOTE(vish): none of the network plugging code is actually"},{"line_number":157,"context_line":"        #             being tested"},{"line_number":158,"context_line":"        self.network_info \u003d utils.get_test_network_info(legacy_model\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FtHk%3D","line":155,"updated":"2013-05-24 22:07:13.000000000","message":"Doesn\u0027t this mean you are switching out the driver you are testing...?","commit_id":"00100546c99dc58b6b47bf8e0ab949cc982597ef"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"107db067b79d17cab53706651c1a8f070e599efa","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        vmwareapi_fake.reset()"},{"line_number":153,"context_line":"        db_fakes.stub_out_db_instance_api(self.stubs)"},{"line_number":154,"context_line":"        stubs.set_stubs(self.stubs)"},{"line_number":155,"context_line":"        self.conn \u003d driver.VMwareVCDriver(FakeVirtAPI())"},{"line_number":156,"context_line":"        # NOTE(vish): none of the network plugging code is actually"},{"line_number":157,"context_line":"        #             being tested"},{"line_number":158,"context_line":"        self.network_info \u003d utils.get_test_network_info(legacy_model\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FtCw%3D","line":155,"in_reply_to":"AAAAPH%2F%2FtHk%3D","updated":"2013-05-24 22:50:18.000000000","message":"Howso?","commit_id":"00100546c99dc58b6b47bf8e0ab949cc982597ef"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b664ce95991eb1d25247098ddbe7bce98b739e7b","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        vmwareapi_fake.reset()"},{"line_number":153,"context_line":"        db_fakes.stub_out_db_instance_api(self.stubs)"},{"line_number":154,"context_line":"        stubs.set_stubs(self.stubs)"},{"line_number":155,"context_line":"        self.conn \u003d driver.VMwareVCDriver(FakeVirtAPI())"},{"line_number":156,"context_line":"        # NOTE(vish): none of the network plugging code is actually"},{"line_number":157,"context_line":"        #             being tested"},{"line_number":158,"context_line":"        self.network_info \u003d utils.get_test_network_info(legacy_model\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fs8w%3D","line":155,"in_reply_to":"AAAAPH%2F%2FtHk%3D","updated":"2013-05-25 01:23:04.000000000","message":"No, the VCDriver extends the ESXDriver so you still get all the same test coverage as before.  The thing is the VCDriver is the one that implements the finish_migrate/finish_revert_migrate methods, so I just changed the driver here so I could re-use the existing test setup and add my new methods.  There was no vmware test coverage before this for resize/migrate.","commit_id":"00100546c99dc58b6b47bf8e0ab949cc982597ef"}]}