)]}'
{"nova/notifications/__init__.py":[{"author":{"_account_id":20411,"name":"Julian","email":"julian.sy@att.com","username":"syjulian"},"change_message_id":"0f5b7f4f582a627e6e66e595ed3e1703de080dcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bab6814e_317adcf1","line":28,"updated":"2016-05-26 15:58:38.000000000","message":"what does this file do?","commit_id":"1dfa8b4733a6a3260226c6fb3d63989bfd3322c2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4c5ac163729146076a24bddf0e97d712a5d24e29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7aa08908_28d67ec5","line":28,"in_reply_to":"bab6814e_317adcf1","updated":"2016-06-06 07:45:12.000000000","message":"It exports the above names to the nova.notifications namespace so that the legacy notification code can find the it in the same space as before the moving.","commit_id":"1dfa8b4733a6a3260226c6fb3d63989bfd3322c2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1b1c1ba5ad8c964b23a8745c4e2f37a18a49e561","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Note(gibi): Importing publicly called functions so the caller code does not"},{"line_number":17,"context_line":"# need to be changed after we moved these function inside the package"},{"line_number":18,"context_line":"# Todo(gibi): remove these imports after legacy notifications using these are"},{"line_number":19,"context_line":"# transformed to versioned notifications"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_d2479d49","line":16,"range":{"start_line":16,"start_character":2,"end_line":16,"end_character":6},"updated":"2016-06-09 21:49:51.000000000","message":"Generally NOTE","commit_id":"5e074a59d276fa869797e0e6b7584e992e5bc3cf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1b1c1ba5ad8c964b23a8745c4e2f37a18a49e561","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Note(gibi): Importing publicly called functions so the caller code does not"},{"line_number":17,"context_line":"# need to be changed after we moved these function inside the package"},{"line_number":18,"context_line":"# Todo(gibi): remove these imports after legacy notifications using these are"},{"line_number":19,"context_line":"# transformed to versioned notifications"},{"line_number":20,"context_line":"from nova.notifications.base import audit_period_bounds  # noqa"},{"line_number":21,"context_line":"from nova.notifications.base import bandwidth_usage  # noqa"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_52728dae","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":6},"updated":"2016-06-09 21:49:51.000000000","message":"TODO","commit_id":"5e074a59d276fa869797e0e6b7584e992e5bc3cf"}],"nova/objects/service.py":[{"author":{"_account_id":20411,"name":"Julian","email":"julian.sy@att.com","username":"syjulian"},"change_message_id":"0f5b7f4f582a627e6e66e595ed3e1703de080dcc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from nova import db"},{"line_number":20,"context_line":"from nova import exception"},{"line_number":21,"context_line":"from nova.i18n import _LW"},{"line_number":22,"context_line":"from nova.notifications.objects import base as notification"},{"line_number":23,"context_line":"from nova import objects"},{"line_number":24,"context_line":"from nova.objects import base"},{"line_number":25,"context_line":"from nova.objects import fields"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_d466deb9","line":22,"updated":"2016-05-26 15:58:38.000000000","message":"same comment about alphabetical arrangement","commit_id":"1dfa8b4733a6a3260226c6fb3d63989bfd3322c2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4c5ac163729146076a24bddf0e97d712a5d24e29","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from nova import db"},{"line_number":20,"context_line":"from nova import exception"},{"line_number":21,"context_line":"from nova.i18n import _LW"},{"line_number":22,"context_line":"from nova.notifications.objects import base as notification"},{"line_number":23,"context_line":"from nova import objects"},{"line_number":24,"context_line":"from nova.objects import base"},{"line_number":25,"context_line":"from nova.objects import fields"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_529bb8c9","line":22,"in_reply_to":"bab6814e_d466deb9","updated":"2016-06-06 07:45:12.000000000","message":"pep8 force me to put it this way","commit_id":"1dfa8b4733a6a3260226c6fb3d63989bfd3322c2"}],"nova/tests/unit/notifications/objects/test_notification.py":[{"author":{"_account_id":20411,"name":"Julian","email":"julian.sy@att.com","username":"syjulian"},"change_message_id":"0f5b7f4f582a627e6e66e595ed3e1703de080dcc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import mock"},{"line_number":16,"context_line":"from oslo_utils import timeutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from nova.notifications.objects import base as notification"},{"line_number":19,"context_line":"from nova import objects"},{"line_number":20,"context_line":"from nova.objects import base"},{"line_number":21,"context_line":"from nova.objects import fields"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_94c29683","line":18,"updated":"2016-05-26 15:58:38.000000000","message":"should this be moved after line 19 to be alphabetical?","commit_id":"1dfa8b4733a6a3260226c6fb3d63989bfd3322c2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4c5ac163729146076a24bddf0e97d712a5d24e29","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import mock"},{"line_number":16,"context_line":"from oslo_utils import timeutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from nova.notifications.objects import base as notification"},{"line_number":19,"context_line":"from nova import objects"},{"line_number":20,"context_line":"from nova.objects import base"},{"line_number":21,"context_line":"from nova.objects import fields"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_b265bce2","line":18,"in_reply_to":"bab6814e_94c29683","updated":"2016-06-06 07:45:12.000000000","message":"pep8 force me this way. Your suggested order results in \n\n./nova/tests/unit/notifications/objects/test_notification.py:19:1: H306  imports not in alphabetical order (nova.objects, nova.notifications.objects.base)","commit_id":"1dfa8b4733a6a3260226c6fb3d63989bfd3322c2"}],"nova/tests/unit/objects/test_objects.py":[{"author":{"_account_id":20411,"name":"Julian","email":"julian.sy@att.com","username":"syjulian"},"change_message_id":"0f5b7f4f582a627e6e66e595ed3e1703de080dcc","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from nova import context"},{"line_number":34,"context_line":"from nova import exception"},{"line_number":35,"context_line":"from nova.notifications.objects import base as notification"},{"line_number":36,"context_line":"from nova import objects"},{"line_number":37,"context_line":"from nova.objects import base"},{"line_number":38,"context_line":"from nova.objects import fields"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_14886670","line":35,"updated":"2016-05-26 15:58:38.000000000","message":"should this be moved after line 36 to be alphabetical?","commit_id":"1dfa8b4733a6a3260226c6fb3d63989bfd3322c2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4c5ac163729146076a24bddf0e97d712a5d24e29","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from nova import context"},{"line_number":34,"context_line":"from nova import exception"},{"line_number":35,"context_line":"from nova.notifications.objects import base as notification"},{"line_number":36,"context_line":"from nova import objects"},{"line_number":37,"context_line":"from nova.objects import base"},{"line_number":38,"context_line":"from nova.objects import fields"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_d2afa8e1","line":35,"in_reply_to":"bab6814e_14886670","updated":"2016-06-06 07:45:12.000000000","message":"pep8 force me to put it here","commit_id":"1dfa8b4733a6a3260226c6fb3d63989bfd3322c2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1b1c1ba5ad8c964b23a8745c4e2f37a18a49e561","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"                         \u0027versions have been bumped, and then update their \u0027"},{"line_number":1227,"context_line":"                         \u0027hashes here.\u0027)"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"    def test_notification_payload_version_depends_on_the_schema(self):"},{"line_number":1230,"context_line":"        @base.NovaObjectRegistry.register_if(False)"},{"line_number":1231,"context_line":"        class TestNotificationPayload(notification.NotificationPayloadBase):"},{"line_number":1232,"context_line":"            VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_d28cbd81","line":1229,"range":{"start_line":1229,"start_character":8,"end_line":1229,"end_character":63},"updated":"2016-06-09 21:49:51.000000000","message":"Seems this and any tests that were using notification objects should go in their own test module like nova.tests.unit.notifications.objects? But then you have to duplicate some test infra here so maybe it\u0027s not worth it right now.","commit_id":"5e074a59d276fa869797e0e6b7584e992e5bc3cf"}]}