)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"4a7201da6a16073f517f4c22087ea6808c6eb3c4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sirisha \u003csirisha.1@tcs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-13 18:16:19 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changed the nova/image/glance.py file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To prevent nova image-show 500 Error"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a18252c_4347171d","line":7,"updated":"2016-04-13 13:10:15.000000000","message":"I think it is not good practice to enumerate files that was changed in patch. This is a nice instruction about commit messages https://wiki.openstack.org/wiki/GitCommitMessages .","commit_id":"b591e91ab83d466f32acf5402de3ac6685c318e2"},{"author":{"_account_id":21395,"name":"Sirisha","email":"sirisha.1@tcs.com","username":"Sirisha"},"change_message_id":"3fb7960491075a4c8144f2ab753da4e2f2062553","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sirisha \u003csirisha.1@tcs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-13 18:16:19 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changed the nova/image/glance.py file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To prevent nova image-show 500 Error"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a18252c_be29e28b","line":7,"in_reply_to":"5a18252c_4347171d","updated":"2016-04-13 13:23:16.000000000","message":"Done","commit_id":"b591e91ab83d466f32acf5402de3ac6685c318e2"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"94a9c9dae1f459f0740f0220badcca55d14a1462","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updated the function call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The changes prevent nova image-show 500 Error"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I41371649482cd27b1dd0b9e230af38291b7d439c"},{"line_number":12,"context_line":"Closes-Bug: #1569122"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a18252c_feb99a7a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":45},"updated":"2016-04-13 14:11:58.000000000","message":"Would be better if you could explain it why was it happening and what change you made it to fix it.","commit_id":"8020e9a0e1e9f84a4b42435c1e81983e402de58e"}],"nova/image/glance.py":[{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"94a9c9dae1f459f0740f0220badcca55d14a1462","unresolved":false,"context_lines":[{"line_number":594,"context_line":"                output[attr] \u003d getattr(image, attr, None)"},{"line_number":595,"context_line":"        # NOTE(mdorman): \u0027size\u0027 attribute must not be \u0027None\u0027, so use 0 instead"},{"line_number":596,"context_line":"        elif attr \u003d\u003d \u0027size\u0027:"},{"line_number":597,"context_line":"            output[attr] \u003d getattr(image, attr, None) or 0"},{"line_number":598,"context_line":"        else:"},{"line_number":599,"context_line":"            # NOTE(xarses): Anything that is caught with the default value"},{"line_number":600,"context_line":"            # will result in an additional lookup to glance for said attr."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_6405f8ba","line":597,"range":{"start_line":597,"start_character":35,"end_line":597,"end_character":40},"updated":"2016-04-13 14:11:58.000000000","message":"we can just do this as well ?\n\n output[attr] \u003d getattr(image, attr, 0)\n\nif the size attribute is not there, set it to 0. Instead making an additional lookup to glance.","commit_id":"8020e9a0e1e9f84a4b42435c1e81983e402de58e"},{"author":{"_account_id":21395,"name":"Sirisha","email":"sirisha.1@tcs.com","username":"Sirisha"},"change_message_id":"516db4905f79113c224627eab1cef1206090536f","unresolved":false,"context_lines":[{"line_number":594,"context_line":"                output[attr] \u003d getattr(image, attr, None)"},{"line_number":595,"context_line":"        # NOTE(mdorman): \u0027size\u0027 attribute must not be \u0027None\u0027, so use 0 instead"},{"line_number":596,"context_line":"        elif attr \u003d\u003d \u0027size\u0027:"},{"line_number":597,"context_line":"            output[attr] \u003d getattr(image, attr, None) or 0"},{"line_number":598,"context_line":"        else:"},{"line_number":599,"context_line":"            # NOTE(xarses): Anything that is caught with the default value"},{"line_number":600,"context_line":"            # will result in an additional lookup to glance for said attr."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_399787ed","line":597,"range":{"start_line":597,"start_character":35,"end_line":597,"end_character":40},"in_reply_to":"5a18252c_6405f8ba","updated":"2016-04-14 04:27:21.000000000","message":"Even if we set it to 0 there is an additional lookup to glance","commit_id":"8020e9a0e1e9f84a4b42435c1e81983e402de58e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"71e6d893e0c22e74920945f59ee9c914140af7a7","unresolved":false,"context_lines":[{"line_number":594,"context_line":"                output[attr] \u003d getattr(image, attr, None)"},{"line_number":595,"context_line":"        # NOTE(mdorman): \u0027size\u0027 attribute must not be \u0027None\u0027, so use 0 instead"},{"line_number":596,"context_line":"        elif attr \u003d\u003d \u0027size\u0027:"},{"line_number":597,"context_line":"            output[attr] \u003d getattr(image, attr, None) or 0"},{"line_number":598,"context_line":"        else:"},{"line_number":599,"context_line":"            # NOTE(xarses): Anything that is caught with the default value"},{"line_number":600,"context_line":"            # will result in an additional lookup to glance for said attr."}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_7960d1a5","line":597,"updated":"2016-04-14 10:03:21.000000000","message":"putting a default value in getattr will hide you the fact that you had a real stacktrace on glanceclient expecting last_request_id...\n\nGiven it raises an AttributeError, sure, you\u0027ll mask that like the other lines did, but I don\u0027t really like that...","commit_id":"9505bda1a4cf2bbfb330715d3f86f98a20fdf225"},{"author":{"_account_id":21395,"name":"Sirisha","email":"sirisha.1@tcs.com","username":"Sirisha"},"change_message_id":"e1f89f6aa840a2eda1e568213fd654cbf1ba47fe","unresolved":false,"context_lines":[{"line_number":594,"context_line":"                output[attr] \u003d getattr(image, attr, None)"},{"line_number":595,"context_line":"        # NOTE(mdorman): \u0027size\u0027 attribute must not be \u0027None\u0027, so use 0 instead"},{"line_number":596,"context_line":"        elif attr \u003d\u003d \u0027size\u0027:"},{"line_number":597,"context_line":"            output[attr] \u003d getattr(image, attr, None) or 0"},{"line_number":598,"context_line":"        else:"},{"line_number":599,"context_line":"            # NOTE(xarses): Anything that is caught with the default value"},{"line_number":600,"context_line":"            # will result in an additional lookup to glance for said attr."}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_efcfb853","line":597,"in_reply_to":"5a18252c_7960d1a5","updated":"2016-04-15 06:29:39.000000000","message":"Yes, We are hiding it because even if the error is resolved at glance client end, as the image is in saving state the size attribute is not returned from glance at that point of time we will get size not found Attribute Error in stack trace so in that case we should return None.","commit_id":"9505bda1a4cf2bbfb330715d3f86f98a20fdf225"}]}