)]}'
{"nova/pci/manager.py":[{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"257a0a12001d339e210e706f6623db7879ddfb6e","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                self._allocate_instance(instance, devs)"},{"line_number":271,"context_line":"                self.allocations[uuid] +\u003d devs"},{"line_number":272,"context_line":"        if sign \u003d\u003d -1 and uuid in self.claims:"},{"line_number":273,"context_line":"            self._free_instance(instance)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def clean_usage(self, instances, migrations, orphans):"},{"line_number":276,"context_line":"        \"\"\"Remove all usages for instances not passed in the parameter."}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_acb66ef6","line":273,"range":{"start_line":273,"start_character":40,"end_line":273,"end_character":41},"updated":"2016-04-15 05:34:35.000000000","message":"the logic is mess here, need be cleaned up. i try to fix some missing logic for resize/migration, refer to this patch:\nhttps://review.openstack.org/#/c/154365/\n\nfree instance should not call from here. when resize/migration abort, or fail, the pci manager should free the devices in clean_usage.\n\ni not very strongly against to fix the multiple allocation error here, just recall i might need this fix or do it in another way in 154365 to fix this. \n\nF.Y.I","commit_id":"5ce6ac46c7e044609a2de7088a181d156b48aa2b"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"367c03b11d720b3a9cd3e04fbc197596493e6ef4","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                self._allocate_instance(instance, devs)"},{"line_number":271,"context_line":"                self.allocations[uuid] +\u003d devs"},{"line_number":272,"context_line":"        if sign \u003d\u003d -1 and uuid in self.claims:"},{"line_number":273,"context_line":"            self._free_instance(instance)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def clean_usage(self, instances, migrations, orphans):"},{"line_number":276,"context_line":"        \"\"\"Remove all usages for instances not passed in the parameter."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_dc307c0a","line":273,"range":{"start_line":273,"start_character":40,"end_line":273,"end_character":41},"in_reply_to":"5a18252c_acb66ef6","updated":"2016-04-15 12:45:27.000000000","message":"Thanks for the info.\n\nI agree, this should be fixed in a separate patch.","commit_id":"5ce6ac46c7e044609a2de7088a181d156b48aa2b"}]}