)]}'
{"nova/tests/unit/api/openstack/compute/test_server_start_stop.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"2c54ba1ea1c904d09b7dad66192f055548289701","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def test_start(self, instance_get_mock, start_mock):"},{"line_number":62,"context_line":"        instance_get_mock.return_value \u003d fake_instance_get(\u0027test_inst\u0027)"},{"line_number":63,"context_line":"        body \u003d dict(start\u003d\"\")"},{"line_number":64,"context_line":"        self.controller._start_server(self.req, \u0027test_inst\u0027, body)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @mock.patch.object(db, \u0027instance_get_by_uuid\u0027)"},{"line_number":67,"context_line":"    def test_start_policy_failed(self, instance_get_mock):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_0300a833","line":64,"range":{"start_line":64,"start_character":48,"end_line":64,"end_character":59},"updated":"2016-04-18 00:44:51.000000000","message":"It should not be changed. \u0027uuids.instance\u0027 would be better.","commit_id":"dd7e6d673090a17d5c8835cb874e164b80f92a8b"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"79761a7310b250aa3c9f243f39f132b3aeaacc15","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def test_start(self, instance_get_mock, start_mock):"},{"line_number":62,"context_line":"        instance_get_mock.return_value \u003d fake_instance_get(\u0027test_inst\u0027)"},{"line_number":63,"context_line":"        body \u003d dict(start\u003d\"\")"},{"line_number":64,"context_line":"        self.controller._start_server(self.req, \u0027test_inst\u0027, body)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @mock.patch.object(db, \u0027instance_get_by_uuid\u0027)"},{"line_number":67,"context_line":"    def test_start_policy_failed(self, instance_get_mock):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f293b3a1","line":64,"range":{"start_line":64,"start_character":48,"end_line":64,"end_character":59},"in_reply_to":"1a122d0e_0300a833","updated":"2016-04-18 02:42:29.000000000","message":"Hmm, thanks for point this out, It must be a rebase problem, I copied the whole code from a Mitaka patch :)","commit_id":"dd7e6d673090a17d5c8835cb874e164b80f92a8b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e5be32ede4851cede3e3d04f239afd0d523b0643","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @mock.patch.object(compute_api.API, \u0027start\u0027,"},{"line_number":82,"context_line":"                       side_effect\u003dexception.InstanceNotReady("},{"line_number":83,"context_line":"                           instance_id\u003d\u0027test_inst\u0027))"},{"line_number":84,"context_line":"    @mock.patch.object(db, \u0027instance_get_by_uuid\u0027)"},{"line_number":85,"context_line":"    def test_start_not_ready(self, instance_get_mock, start_mock):"},{"line_number":86,"context_line":"        instance_get_mock.return_value \u003d fake_instance_get(uuids.instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_65f66dfa","line":83,"range":{"start_line":83,"start_character":39,"end_line":83,"end_character":50},"updated":"2016-04-19 14:22:35.000000000","message":"I think we shall use a valid uuid here, like uuids.instance","commit_id":"27567c6f28eb1323296346d1df7b41fc91445f2a"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"fc54b3b8514e5f7617893571296dc94db5b8db83","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @mock.patch.object(compute_api.API, \u0027start\u0027,"},{"line_number":82,"context_line":"                       side_effect\u003dexception.InstanceNotReady("},{"line_number":83,"context_line":"                           instance_id\u003d\u0027test_inst\u0027))"},{"line_number":84,"context_line":"    @mock.patch.object(db, \u0027instance_get_by_uuid\u0027)"},{"line_number":85,"context_line":"    def test_start_not_ready(self, instance_get_mock, start_mock):"},{"line_number":86,"context_line":"        instance_get_mock.return_value \u003d fake_instance_get(uuids.instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_dc7f33a9","line":83,"range":{"start_line":83,"start_character":39,"end_line":83,"end_character":50},"in_reply_to":"1a122d0e_65f66dfa","updated":"2016-04-20 07:29:12.000000000","message":"Done","commit_id":"27567c6f28eb1323296346d1df7b41fc91445f2a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e5be32ede4851cede3e3d04f239afd0d523b0643","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @mock.patch.object(compute_api.API, \u0027start\u0027,"},{"line_number":92,"context_line":"                       side_effect\u003dexception.InstanceIsLocked("},{"line_number":93,"context_line":"                           instance_uuid\u003d\u0027test_inst\u0027))"},{"line_number":94,"context_line":"    @mock.patch.object(db, \u0027instance_get_by_uuid\u0027)"},{"line_number":95,"context_line":"    def test_start_locked_server(self, instance_get_mock, start_mock):"},{"line_number":96,"context_line":"        instance_get_mock.return_value \u003d fake_instance_get(uuids.instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_c5df8167","line":93,"range":{"start_line":93,"start_character":42,"end_line":93,"end_character":51},"updated":"2016-04-19 14:22:35.000000000","message":"ditto","commit_id":"27567c6f28eb1323296346d1df7b41fc91445f2a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e5be32ede4851cede3e3d04f239afd0d523b0643","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                           instance_uuid\u003duuids.instance))"},{"line_number":157,"context_line":"    @mock.patch.object(db, \u0027instance_get_by_uuid\u0027)"},{"line_number":158,"context_line":"    def test_stop_invalid_state(self, instance_get_mock, stop_mock):"},{"line_number":159,"context_line":"        instance_get_mock.return_value \u003d fake_instance_get(uuids.instance)"},{"line_number":160,"context_line":"        body \u003d dict(start\u003d\"\")"},{"line_number":161,"context_line":"        self.assertRaises(webob.exc.HTTPConflict,"},{"line_number":162,"context_line":"            self.controller._stop_server, self.req, uuids.instance, body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_2533d5ac","line":159,"updated":"2016-04-19 14:22:35.000000000","message":"Do I see correctly that almost every test case has this extra mock in place? If yes, can we do this mocking in the setUp to avoid repetition?","commit_id":"27567c6f28eb1323296346d1df7b41fc91445f2a"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"fc54b3b8514e5f7617893571296dc94db5b8db83","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                           instance_uuid\u003duuids.instance))"},{"line_number":157,"context_line":"    @mock.patch.object(db, \u0027instance_get_by_uuid\u0027)"},{"line_number":158,"context_line":"    def test_stop_invalid_state(self, instance_get_mock, stop_mock):"},{"line_number":159,"context_line":"        instance_get_mock.return_value \u003d fake_instance_get(uuids.instance)"},{"line_number":160,"context_line":"        body \u003d dict(start\u003d\"\")"},{"line_number":161,"context_line":"        self.assertRaises(webob.exc.HTTPConflict,"},{"line_number":162,"context_line":"            self.controller._stop_server, self.req, uuids.instance, body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_bc7cf7b5","line":159,"in_reply_to":"1a122d0e_2533d5ac","updated":"2016-04-20 07:29:12.000000000","message":"Done","commit_id":"27567c6f28eb1323296346d1df7b41fc91445f2a"}]}
