)]}'
{"nova/conductor/tasks/live_migrate.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"31c56abed531127a3afa08d23e8c929054edbfda","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import oslo_messaging as messaging"},{"line_number":15,"context_line":"import six"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import nova.conf"},{"line_number":18,"context_line":"from nova.compute import power_state"},{"line_number":19,"context_line":"from nova.conductor.tasks import base"},{"line_number":20,"context_line":"from nova import exception"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_634a3cc7","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":16},"updated":"2016-04-18 00:35:11.000000000","message":"This should be moved just after line 19(from nova.conductor.tasks import base).","commit_id":"8fe5a8b756be68ddf69d276f44552c3992c9a8a8"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"0db3553005b6f42f858da50e394e0f685b1938f8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import oslo_messaging as messaging"},{"line_number":15,"context_line":"import six"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import nova.conf"},{"line_number":18,"context_line":"from nova.compute import power_state"},{"line_number":19,"context_line":"from nova.conductor.tasks import base"},{"line_number":20,"context_line":"from nova import exception"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_9274ff9c","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":16},"in_reply_to":"1a122d0e_634a3cc7","updated":"2016-04-18 03:23:41.000000000","message":"Done","commit_id":"8fe5a8b756be68ddf69d276f44552c3992c9a8a8"}],"nova/conf/conductor.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"31c56abed531127a3afa08d23e8c929054edbfda","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def register_opts(conf):"},{"line_number":64,"context_line":"    conf.register_group(conductor_group)"},{"line_number":65,"context_line":"    conf.register_opts(ALL_OPTS, group\u003dconductor_group)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_63219cfb","line":65,"updated":"2016-04-18 00:35:11.000000000","message":"Add \u0027conf.register_opts(migrate_opt)\u0027.","commit_id":"8fe5a8b756be68ddf69d276f44552c3992c9a8a8"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"0db3553005b6f42f858da50e394e0f685b1938f8","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def register_opts(conf):"},{"line_number":64,"context_line":"    conf.register_group(conductor_group)"},{"line_number":65,"context_line":"    conf.register_opts(ALL_OPTS, group\u003dconductor_group)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_d26e77c8","line":65,"in_reply_to":"1a122d0e_63219cfb","updated":"2016-04-18 03:23:41.000000000","message":"Added to ALL_OPTS","commit_id":"8fe5a8b756be68ddf69d276f44552c3992c9a8a8"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"31c56abed531127a3afa08d23e8c929054edbfda","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def list_opts():"},{"line_number":69,"context_line":"    return {conductor_group: ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_c35fd070","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":37},"updated":"2016-04-18 00:35:11.000000000","message":"migrate_opt should be added.","commit_id":"8fe5a8b756be68ddf69d276f44552c3992c9a8a8"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"0db3553005b6f42f858da50e394e0f685b1938f8","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def list_opts():"},{"line_number":69,"context_line":"    return {conductor_group: ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_f26573e1","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":37},"in_reply_to":"1a122d0e_c35fd070","updated":"2016-04-18 03:23:41.000000000","message":"As above.","commit_id":"8fe5a8b756be68ddf69d276f44552c3992c9a8a8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9275050449b2a367133b87e835666b5f3256e7d9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    help\u003d\u0027Number of workers for OpenStack Conductor service. \u0027"},{"line_number":47,"context_line":"         \u0027The default will be the number of CPUs available.\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"migrate_opt \u003d cfg.IntOpt("},{"line_number":50,"context_line":"    \u0027migrate_max_retries\u0027,"},{"line_number":51,"context_line":"    default\u003d-1,"},{"line_number":52,"context_line":"    help\u003d\u0027Number of times to retry live-migration before failing. \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_ed583633","line":49,"updated":"2016-04-21 09:46:12.000000000","message":"I think we might want to move this into the compute options, really, but lets leave it here for now.","commit_id":"fd7bc953a1a746760956a9788b6cfdf33d81d9cf"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9275050449b2a367133b87e835666b5f3256e7d9","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def list_opts():"},{"line_number":70,"context_line":"    return {\"DEFAULT\": [migrate_opt],"},{"line_number":71,"context_line":"            conductor_group: ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_6d2ee68c","line":71,"updated":"2016-04-21 09:46:12.000000000","message":"Nit: not sure this is safe now, but this patch is not change whats already there, so lets leave that.","commit_id":"fd7bc953a1a746760956a9788b6cfdf33d81d9cf"}]}
