)]}'
{"nova/tests/unit/objects/test_quotas.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5b5f21ee27851dd378cda26d28075417ba77cdca","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    @mock.patch.object(QUOTAS, \u0027commit\u0027)"},{"line_number":120,"context_line":"    def test_commit_none_reservations(self, commit_mock):"},{"line_number":121,"context_line":"        quotas \u003d quotas_obj.Quotas.from_reservations(self.context, None)"},{"line_number":122,"context_line":"        quotas.commit()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @mock.patch.object(QUOTAS, \u0027rollback\u0027)"},{"line_number":125,"context_line":"    def test_rollback(self, rollback_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_36949241","line":122,"updated":"2016-04-20 00:39:04.000000000","message":"It would be better to add \u0027commit_mock.assert_not_called()\u0027.","commit_id":"95620635adf22df11d31b33f0d77d655afa1ee3d"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"99994907a266234ec870353ea65a0089794288c0","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    @mock.patch.object(QUOTAS, \u0027commit\u0027)"},{"line_number":120,"context_line":"    def test_commit_none_reservations(self, commit_mock):"},{"line_number":121,"context_line":"        quotas \u003d quotas_obj.Quotas.from_reservations(self.context, None)"},{"line_number":122,"context_line":"        quotas.commit()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @mock.patch.object(QUOTAS, \u0027rollback\u0027)"},{"line_number":125,"context_line":"    def test_rollback(self, rollback_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_95d9135a","line":122,"in_reply_to":"1a122d0e_36949241","updated":"2016-04-20 06:33:05.000000000","message":"Done","commit_id":"95620635adf22df11d31b33f0d77d655afa1ee3d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5b5f21ee27851dd378cda26d28075417ba77cdca","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    @mock.patch.object(QUOTAS, \u0027rollback\u0027)"},{"line_number":136,"context_line":"    def test_rollback_none_reservations(self, rollback_mock):"},{"line_number":137,"context_line":"        quotas \u003d quotas_obj.Quotas.from_reservations(self.context, None)"},{"line_number":138,"context_line":"        quotas.rollback()"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @mock.patch(\u0027nova.db.quota_create\u0027)"},{"line_number":141,"context_line":"    def test_create_limit(self, mock_create):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_d690be45","line":138,"updated":"2016-04-20 00:39:04.000000000","message":"It would be better to add \u0027rollback_mock.assert_not_called()\u0027.","commit_id":"95620635adf22df11d31b33f0d77d655afa1ee3d"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"99994907a266234ec870353ea65a0089794288c0","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    @mock.patch.object(QUOTAS, \u0027rollback\u0027)"},{"line_number":136,"context_line":"    def test_rollback_none_reservations(self, rollback_mock):"},{"line_number":137,"context_line":"        quotas \u003d quotas_obj.Quotas.from_reservations(self.context, None)"},{"line_number":138,"context_line":"        quotas.rollback()"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @mock.patch(\u0027nova.db.quota_create\u0027)"},{"line_number":141,"context_line":"    def test_create_limit(self, mock_create):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_b5d40f20","line":138,"in_reply_to":"1a122d0e_d690be45","updated":"2016-04-20 06:33:05.000000000","message":"Done","commit_id":"95620635adf22df11d31b33f0d77d655afa1ee3d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bf7b139b0fa168833948a9d94a5bdde52559cfc7","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def test_commit_none_reservations(self, commit_mock):"},{"line_number":121,"context_line":"        quotas \u003d quotas_obj.Quotas.from_reservations(self.context, None)"},{"line_number":122,"context_line":"        quotas.commit()"},{"line_number":123,"context_line":"        commit_mock.assert_not_called()"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @mock.patch.object(QUOTAS, \u0027rollback\u0027)"},{"line_number":126,"context_line":"    def test_rollback(self, rollback_mock):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_97c9d1ae","line":123,"range":{"start_line":123,"start_character":20,"end_line":123,"end_character":37},"updated":"2016-06-25 13:21:49.000000000","message":"This was added in mock 3.5:\n\nhttps://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_not_called\n\nWhich we don\u0027t test against:\n\nhttps://github.com/openstack/requirements/blob/master/upper-constraints.txt#L159\n\nSo you should be using self.assertFalse(commit_mock.called) for now.","commit_id":"52a570eb7ca3c793cc281dcd4c0fe49f954dba89"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"96da48bb4da1d0b46fa09dca1a12e7d2cff3a249","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def test_commit_none_reservations(self, commit_mock):"},{"line_number":121,"context_line":"        quotas \u003d quotas_obj.Quotas.from_reservations(self.context, None)"},{"line_number":122,"context_line":"        quotas.commit()"},{"line_number":123,"context_line":"        commit_mock.assert_not_called()"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @mock.patch.object(QUOTAS, \u0027rollback\u0027)"},{"line_number":126,"context_line":"    def test_rollback(self, rollback_mock):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_8071f8aa","line":123,"range":{"start_line":123,"start_character":20,"end_line":123,"end_character":37},"in_reply_to":"3aaa91ec_97c9d1ae","updated":"2016-06-29 07:59:37.000000000","message":"Done","commit_id":"52a570eb7ca3c793cc281dcd4c0fe49f954dba89"}]}