)]}'
{"nova/api/openstack/compute/rescue.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"be2bda19d733f5bc48f49a5b6e5136975eee432f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        super(RescueController, self).__init__(*args, **kwargs)"},{"line_number":43,"context_line":"        self.compute_api \u003d compute.API(skip_policy_check\u003dTrue)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _rescue_image_validation(self, image_ref):"},{"line_number":46,"context_line":"        image_uuid \u003d image_ref.split(\u0027/\u0027).pop()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        if not uuidutils.is_uuid_like(image_uuid):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_08d4dce9","line":45,"updated":"2016-04-19 20:55:07.000000000","message":"@mriedem: Yes. I suppose a follow-up patch could add a custom validation rule for (uri-containing-uuid or uuid) to the JSON schema document.","commit_id":"f215772c55a0e51008fef903a50570bd1c0d2b29"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8425fe0e3ac3b9941421810c4ace93b60c661e35","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        super(RescueController, self).__init__(*args, **kwargs)"},{"line_number":43,"context_line":"        self.compute_api \u003d compute.API(skip_policy_check\u003dTrue)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _rescue_image_validation(self, image_ref):"},{"line_number":46,"context_line":"        image_uuid \u003d image_ref.split(\u0027/\u0027).pop()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        if not uuidutils.is_uuid_like(image_uuid):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_2919e722","line":45,"updated":"2016-04-19 16:44:05.000000000","message":"We use jsonschema validation in the v2.1 API so you should probably be changing the parameter type used in the validation for image_ref:\n\nhttps://github.com/openstack/nova/blob/master/nova/api/validation/parameter_types.py#L296","commit_id":"f215772c55a0e51008fef903a50570bd1c0d2b29"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4680f4df2927c60b2271bed94945c944a4d3c21c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        super(RescueController, self).__init__(*args, **kwargs)"},{"line_number":43,"context_line":"        self.compute_api \u003d compute.API(skip_policy_check\u003dTrue)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _rescue_image_validation(self, image_ref):"},{"line_number":46,"context_line":"        image_uuid \u003d image_ref.split(\u0027/\u0027).pop()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        if not uuidutils.is_uuid_like(image_uuid):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_67b49e34","line":45,"in_reply_to":"1a122d0e_08d4dce9","updated":"2016-04-19 21:36:19.000000000","message":"Yeah, we gave up to implement json-schema for this image_ref pattern when we implemented. It would be great if we can implement this pattern for users with consistent error message.","commit_id":"f215772c55a0e51008fef903a50570bd1c0d2b29"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"92e68ade1e942072273b9a3623dfd0896dce355d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        super(RescueController, self).__init__(*args, **kwargs)"},{"line_number":43,"context_line":"        self.compute_api \u003d compute.API(skip_policy_check\u003dTrue)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _rescue_image_validation(self, image_ref):"},{"line_number":46,"context_line":"        image_uuid \u003d image_ref.split(\u0027/\u0027).pop()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        if not uuidutils.is_uuid_like(image_uuid):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_e9d08f21","line":45,"in_reply_to":"1a122d0e_2919e722","updated":"2016-04-19 16:44:57.000000000","message":"Oh but I guess we can\u0027t because this can be a uuid or a full url...dang.","commit_id":"f215772c55a0e51008fef903a50570bd1c0d2b29"}],"nova/tests/unit/api/openstack/compute/test_rescue.py":[{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"d0a1c3ca73f2ed913a7a2365e688a4ed21fcf2e4","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                          self.fake_req, UUID, body\u003dbody)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @mock.patch(\u0027nova.compute.api.API.rescue\u0027)"},{"line_number":141,"context_line":"    def test_rescue_with_bad_image_specified(self, mock_compute_api_rescue):"},{"line_number":142,"context_line":"        body \u003d {\"rescue\": {\"adminPass\": \"ABC123\","},{"line_number":143,"context_line":"                           \"rescue_image_ref\": \"img-id\"}}"},{"line_number":144,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_48e9ea13","line":141,"updated":"2016-04-18 22:04:14.000000000","message":"I think tests should be added using the full href url, like for example: https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/test_serversV21.py#L1612","commit_id":"91c8156396a66dab74febc4f6f3dbaaa725b05e8"}]}