)]}'
{"nova/scheduler/filters/aggregate_image_properties_isolation.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"23906cac215fdccb30b2914309a0a982057e057c","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# Copyright (c) 2013 Cloudwatt"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_2037d4e4","line":1,"updated":"2016-05-05 23:21:01.000000000","message":"Whitespace damage?","commit_id":"7ca34fbfe7c628fb8739dbf40d33e3c4a77f683d"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"8008d8138e712dea792e34bc96dae29b2a6797df","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# Copyright (c) 2013 Cloudwatt"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_cd5546c7","line":1,"in_reply_to":"dab17558_2037d4e4","updated":"2016-05-06 13:17:42.000000000","message":"Done","commit_id":"7ca34fbfe7c628fb8739dbf40d33e3c4a77f683d"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"23906cac215fdccb30b2914309a0a982057e057c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                LOG.warning(_LW(\"Host \u0027%(host)s\u0027 has no metadata for \""},{"line_number":55,"context_line":"                           \"\u0027%(key)s\u0027\") % {\"host\": host_state.host,"},{"line_number":56,"context_line":"                                           \"key\": key})"},{"line_number":57,"context_line":"                continue"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"            # NOTE(sbauza): Aggregate metadata is only strings, we need to"},{"line_number":60,"context_line":"            # stringify the property to match with the option"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_a04e2494","line":57,"updated":"2016-05-05 23:21:01.000000000","message":"Isn\u0027t this message backwards? The host has metadata that the image doesn\u0027t? Or am I misreading this?\n\nHow common is this log line in the worst case? i.e. all hosts have a metadata item (or several) which are never specified with images. Aren\u0027t we going to be spamming the heck out of the logs at that point?","commit_id":"7ca34fbfe7c628fb8739dbf40d33e3c4a77f683d"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"8008d8138e712dea792e34bc96dae29b2a6797df","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                LOG.warning(_LW(\"Host \u0027%(host)s\u0027 has no metadata for \""},{"line_number":55,"context_line":"                           \"\u0027%(key)s\u0027\") % {\"host\": host_state.host,"},{"line_number":56,"context_line":"                                           \"key\": key})"},{"line_number":57,"context_line":"                continue"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"            # NOTE(sbauza): Aggregate metadata is only strings, we need to"},{"line_number":60,"context_line":"            # stringify the property to match with the option"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_ed3bea9a","line":57,"in_reply_to":"dab17558_a04e2494","updated":"2016-05-06 13:17:42.000000000","message":"Heh, yeah, I think you\u0027re right about the backwards message. But the expectation here is that all of the host metadata corresponds to image metadata. In the original code, if there was a mismatch, an unhandled AttributeError would be raised. So I think that this should be exceedingly rare, or we would have had a much bigger problem already.","commit_id":"7ca34fbfe7c628fb8739dbf40d33e3c4a77f683d"}]}