)]}'
{"nova/storage/linuxscsi.py":[{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"13026eb92602bdd3e4229dd32d8ea324291d7677","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            LOG.debug(_(\"Found multipath device \u003d %(mdev)s\") % locals())"},{"line_number":124,"context_line":"            device_lines \u003d lines[3:]"},{"line_number":125,"context_line":"            for dev_line in device_lines:"},{"line_number":126,"context_line":"                if dev_line.find(\"policy\") \u003d\u003d -1:"},{"line_number":127,"context_line":"                    new_line \u003d dev_line.lstrip(\u0027 |-`\u0027)"},{"line_number":128,"context_line":"                    dev_info \u003d new_line.split()"},{"line_number":129,"context_line":"                    address \u003d dev_info[0].split(\":\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FpDU%3D","line":126,"updated":"2013-05-28 18:43:44.000000000","message":"continue\n\nThen you don\u0027t need to indent the rest","commit_id":"83617138a040cd555be522ccf1fb6a836e9d7ac2"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"13026eb92602bdd3e4229dd32d8ea324291d7677","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            for dev_line in device_lines:"},{"line_number":126,"context_line":"                if dev_line.find(\"policy\") \u003d\u003d -1:"},{"line_number":127,"context_line":"                    new_line \u003d dev_line.lstrip(\u0027 |-`\u0027)"},{"line_number":128,"context_line":"                    dev_info \u003d new_line.split()"},{"line_number":129,"context_line":"                    address \u003d dev_info[0].split(\":\")"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"                    dev \u003d {\u0027device\u0027: \u0027/dev/%s\u0027 % dev_info[1],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FpDA%3D","line":128,"updated":"2013-05-28 18:43:44.000000000","message":"You should keep updating dev_line for clarity\nrather than introducing a new variable (new_line)","commit_id":"83617138a040cd555be522ccf1fb6a836e9d7ac2"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"13026eb92602bdd3e4229dd32d8ea324291d7677","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                    dev \u003d {\u0027device\u0027: \u0027/dev/%s\u0027 % dev_info[1],"},{"line_number":132,"context_line":"                           \u0027host\u0027: address[0], \u0027channel\u0027: address[1],"},{"line_number":133,"context_line":"                           \u0027id\u0027: address[2], \u0027lun\u0027: address[3]"},{"line_number":134,"context_line":"                           }"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"                    devices.append(dev)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FpC8%3D","line":134,"updated":"2013-05-28 18:43:44.000000000","message":"Better to not put the space before }","commit_id":"83617138a040cd555be522ccf1fb6a836e9d7ac2"}],"nova/tests/test_linuxscsi.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"b72abbce97584354e37ca893bdc0ee219a1e1f8a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.assertEqual(\"0\", info[\u0027devices\u0027][0][\u0027channel\u0027])"},{"line_number":91,"context_line":"        self.assertEqual(\"2\", info[\u0027devices\u0027][0][\u0027id\u0027])"},{"line_number":92,"context_line":"        self.assertEqual(\"0\", info[\u0027devices\u0027][0][\u0027lun\u0027])"},{"line_number":93,"context_line":"        "},{"line_number":94,"context_line":"        self.assertEqual(\"/dev/sdf\", info[\u0027devices\u0027][2][\u0027device\u0027])"},{"line_number":95,"context_line":"        self.assertEqual(\"6\", info[\u0027devices\u0027][2][\u0027host\u0027])"},{"line_number":96,"context_line":"        self.assertEqual(\"0\", info[\u0027devices\u0027][2][\u0027channel\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fpg8%3D","line":93,"updated":"2013-05-28 16:21:32.000000000","message":"trailing whitespace","commit_id":"83617138a040cd555be522ccf1fb6a836e9d7ac2"},{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"b72abbce97584354e37ca893bdc0ee219a1e1f8a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        self.assertEqual(\"3\", info[\u0027devices\u0027][2][\u0027id\u0027])"},{"line_number":98,"context_line":"        self.assertEqual(\"0\", info[\u0027devices\u0027][2][\u0027lun\u0027])"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"                "},{"line_number":101,"context_line":"    def test_find_multipath_device_ds8000(self):"},{"line_number":102,"context_line":"        def fake_execute(*cmd, **kwargs):"},{"line_number":103,"context_line":"            out \u003d (\"36005076303ffc48e0000000000000101 dm-2 IBM,2107900\\n\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fpg4%3D","line":100,"updated":"2013-05-28 16:21:32.000000000","message":"trailing whitespace","commit_id":"83617138a040cd555be522ccf1fb6a836e9d7ac2"},{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"b72abbce97584354e37ca893bdc0ee219a1e1f8a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.assertEqual(\"0\", info[\u0027devices\u0027][0][\u0027channel\u0027])"},{"line_number":119,"context_line":"        self.assertEqual(\"2\", info[\u0027devices\u0027][0][\u0027id\u0027])"},{"line_number":120,"context_line":"        self.assertEqual(\"0\", info[\u0027devices\u0027][0][\u0027lun\u0027])"},{"line_number":121,"context_line":"        "},{"line_number":122,"context_line":"        self.assertEqual(\"/dev/sdc\", info[\u0027devices\u0027][1][\u0027device\u0027])"},{"line_number":123,"context_line":"        self.assertEqual(\"6\", info[\u0027devices\u0027][1][\u0027host\u0027])"},{"line_number":124,"context_line":"        self.assertEqual(\"1\", info[\u0027devices\u0027][1][\u0027channel\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fpg0%3D","line":121,"updated":"2013-05-28 16:21:32.000000000","message":"trailing whitespace","commit_id":"83617138a040cd555be522ccf1fb6a836e9d7ac2"}]}