)]}'
{"nova/tests/unit/objects/test_pci_device.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"af8fbcc2f42a46eb2b5fa8cacd6a5abcd8102684","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def _create_fake_pci_device(self, get_mock, ctxt\u003dNone):"},{"line_number":116,"context_line":"        if not ctxt:"},{"line_number":117,"context_line":"            ctxt \u003d context.get_admin_context()"},{"line_number":118,"context_line":"        get_mock.return_value \u003d fake_db_dev"},{"line_number":119,"context_line":"        self.pci_device \u003d pci_device.PciDevice.get_by_dev_addr(ctxt, 1, \u0027a\u0027)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def test_create_pci_device(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_73e125fe","line":118,"updated":"2016-04-19 09:28:59.000000000","message":"I think the original test asserted that the db function is called with 1, and \u0027a\u0027 as parameters but the new test doesn\u0027t assert that","commit_id":"cfb666f12f0395bcddb413d89793750ccc3c7ab3"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"45fefc310c191e94b74b00f7cbc5e2e581f1c451","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def _create_fake_pci_device(self, get_mock, ctxt\u003dNone):"},{"line_number":116,"context_line":"        if not ctxt:"},{"line_number":117,"context_line":"            ctxt \u003d context.get_admin_context()"},{"line_number":118,"context_line":"        get_mock.return_value \u003d fake_db_dev"},{"line_number":119,"context_line":"        self.pci_device \u003d pci_device.PciDevice.get_by_dev_addr(ctxt, 1, \u0027a\u0027)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def test_create_pci_device(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f3737513","line":118,"in_reply_to":"1a122d0e_73e125fe","updated":"2016-04-19 09:32:42.000000000","message":"Hmm, understand, I will add them","commit_id":"cfb666f12f0395bcddb413d89793750ccc3c7ab3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"af8fbcc2f42a46eb2b5fa8cacd6a5abcd8102684","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    @mock.patch.object(db, \u0027pci_device_get_by_addr\u0027)"},{"line_number":162,"context_line":"    def test_get_by_dev_addr(self, get_mock):"},{"line_number":163,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":164,"context_line":"        get_mock.return_value \u003d fake_db_dev"},{"line_number":165,"context_line":"        self.pci_device \u003d pci_device.PciDevice.get_by_dev_addr(ctxt, 1, \u0027a\u0027)"},{"line_number":166,"context_line":"        self.assertEqual(self.pci_device.product_id, \u0027p\u0027)"},{"line_number":167,"context_line":"        self.assertEqual(self.pci_device.obj_what_changed(), set())"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f3ed35f0","line":164,"updated":"2016-04-19 09:28:59.000000000","message":"ditto","commit_id":"cfb666f12f0395bcddb413d89793750ccc3c7ab3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"af8fbcc2f42a46eb2b5fa8cacd6a5abcd8102684","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    @mock.patch.object(db, \u0027pci_device_get_by_id\u0027)"},{"line_number":170,"context_line":"    def test_get_by_dev_id(self, get_mock):"},{"line_number":171,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":172,"context_line":"        get_mock.return_value \u003d fake_db_dev"},{"line_number":173,"context_line":"        self.pci_device \u003d pci_device.PciDevice.get_by_dev_id(ctxt, 1)"},{"line_number":174,"context_line":"        self.assertEqual(self.pci_device.product_id, \u0027p\u0027)"},{"line_number":175,"context_line":"        self.assertEqual(self.pci_device.obj_what_changed(), set())"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_53bb49e5","line":172,"updated":"2016-04-19 09:28:59.000000000","message":"ditto","commit_id":"cfb666f12f0395bcddb413d89793750ccc3c7ab3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"af8fbcc2f42a46eb2b5fa8cacd6a5abcd8102684","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        expected_updates \u003d dict(status\u003dfields.PciDeviceStatus.ALLOCATED,"},{"line_number":213,"context_line":"                                instance_uuid\u003d\u0027fake-uuid-2\u0027)"},{"line_number":214,"context_line":"        update_mock.return_value \u003d return_dev"},{"line_number":215,"context_line":"        self.assertEqual(self.pci_device.status,"},{"line_number":216,"context_line":"                         fields.PciDeviceStatus.AVAILABLE)"},{"line_number":217,"context_line":"        self.assertEqual(self.pci_device.instance_uuid,"},{"line_number":218,"context_line":"                         \u0027fake-uuid-3\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_d396394b","line":215,"updated":"2016-04-19 09:28:59.000000000","message":"why don\u0027t we need to call the pci_device.save() any more?","commit_id":"cfb666f12f0395bcddb413d89793750ccc3c7ab3"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"45fefc310c191e94b74b00f7cbc5e2e581f1c451","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        expected_updates \u003d dict(status\u003dfields.PciDeviceStatus.ALLOCATED,"},{"line_number":213,"context_line":"                                instance_uuid\u003d\u0027fake-uuid-2\u0027)"},{"line_number":214,"context_line":"        update_mock.return_value \u003d return_dev"},{"line_number":215,"context_line":"        self.assertEqual(self.pci_device.status,"},{"line_number":216,"context_line":"                         fields.PciDeviceStatus.AVAILABLE)"},{"line_number":217,"context_line":"        self.assertEqual(self.pci_device.instance_uuid,"},{"line_number":218,"context_line":"                         \u0027fake-uuid-3\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_13227100","line":215,"in_reply_to":"1a122d0e_d396394b","updated":"2016-04-19 09:32:42.000000000","message":"My bad","commit_id":"cfb666f12f0395bcddb413d89793750ccc3c7ab3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be181ad26b59820d5168a6df22561aa1561e45c9","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        self.inst.pci_devices \u003d pci_device.PciDeviceList()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @mock.patch.object(db, \u0027pci_device_get_by_addr\u0027)"},{"line_number":115,"context_line":"    def _create_fake_pci_device(self, get_mock, ctxt\u003dNone):"},{"line_number":116,"context_line":"        if not ctxt:"},{"line_number":117,"context_line":"            ctxt \u003d context.get_admin_context()"},{"line_number":118,"context_line":"        get_mock.return_value \u003d fake_db_dev"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_1b8c9c34","line":115,"range":{"start_line":115,"start_character":38,"end_line":115,"end_character":46},"updated":"2016-11-16 05:29:10.000000000","message":"for consistency please use mock_get. (mock_*)","commit_id":"1490b2b5bd880759a1be5bde73a6ac29751263cc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be181ad26b59820d5168a6df22561aa1561e45c9","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                         set([\u0027vendor_id\u0027, \u0027product_id\u0027, \u0027parent_addr\u0027]))"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    @mock.patch.object(db, \u0027pci_device_get_by_addr\u0027)"},{"line_number":163,"context_line":"    def test_get_by_dev_addr(self, get_mock):"},{"line_number":164,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":165,"context_line":"        get_mock.return_value \u003d fake_db_dev"},{"line_number":166,"context_line":"        self.pci_device \u003d pci_device.PciDevice.get_by_dev_addr(ctxt, 1, \u0027a\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_3b831806","line":163,"range":{"start_line":163,"start_character":35,"end_line":163,"end_character":43},"updated":"2016-11-16 05:29:10.000000000","message":"ditto","commit_id":"1490b2b5bd880759a1be5bde73a6ac29751263cc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be181ad26b59820d5168a6df22561aa1561e45c9","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        get_mock.assert_called_once_with(ctxt, 1, \u0027a\u0027)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    @mock.patch.object(db, \u0027pci_device_get_by_id\u0027)"},{"line_number":172,"context_line":"    def test_get_by_dev_id(self, get_mock):"},{"line_number":173,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":174,"context_line":"        get_mock.return_value \u003d fake_db_dev"},{"line_number":175,"context_line":"        self.pci_device \u003d pci_device.PciDevice.get_by_dev_id(ctxt, 1)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_7b7d901b","line":172,"range":{"start_line":172,"start_character":33,"end_line":172,"end_character":41},"updated":"2016-11-16 05:29:10.000000000","message":"ditto","commit_id":"1490b2b5bd880759a1be5bde73a6ac29751263cc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be181ad26b59820d5168a6df22561aa1561e45c9","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            self.assertEqual({}, dev.extra_info)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    @mock.patch.object(db, \u0027pci_device_update\u0027)"},{"line_number":201,"context_line":"    def test_save(self, update_mock):"},{"line_number":202,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":203,"context_line":"        self._create_fake_pci_device(ctxt\u003dctxt)"},{"line_number":204,"context_line":"        return_dev \u003d dict(fake_db_dev, status\u003dfields.PciDeviceStatus.AVAILABLE,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_bb772839","line":201,"range":{"start_line":201,"start_character":24,"end_line":201,"end_character":35},"updated":"2016-11-16 05:29:10.000000000","message":"ditto","commit_id":"1490b2b5bd880759a1be5bde73a6ac29751263cc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be181ad26b59820d5168a6df22561aa1561e45c9","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        self.assertEqual(self.extra_info, \u0027{}\u0027)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    @mock.patch.object(db, \u0027pci_device_destroy\u0027)"},{"line_number":235,"context_line":"    def test_save_removed(self, destroy_mock):"},{"line_number":236,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":237,"context_line":"        self._create_fake_pci_device(ctxt\u003dctxt)"},{"line_number":238,"context_line":"        self.pci_device.status \u003d fields.PciDeviceStatus.REMOVED"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_1b93bc50","line":235,"range":{"start_line":235,"start_character":32,"end_line":235,"end_character":44},"updated":"2016-11-16 05:29:10.000000000","message":"ditto","commit_id":"1490b2b5bd880759a1be5bde73a6ac29751263cc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be181ad26b59820d5168a6df22561aa1561e45c9","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        self.pci_device.status \u003d fields.PciDeviceStatus.REMOVED"},{"line_number":239,"context_line":"        self.pci_device.save()"},{"line_number":240,"context_line":"        self.assertEqual(self.pci_device.status,"},{"line_number":241,"context_line":"                         fields.PciDeviceStatus.DELETED)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def test_save_deleted(self):"},{"line_number":244,"context_line":"        def _fake_destroy(ctxt, node_id, addr):"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_7bcbd053","line":241,"range":{"start_line":241,"start_character":55,"end_line":241,"end_character":56},"updated":"2016-11-16 05:29:10.000000000","message":"should check for method call also-\nmock_destroy.assert_called_once_with(ctxt, 1, \u0027a\u0027)","commit_id":"1490b2b5bd880759a1be5bde73a6ac29751263cc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be181ad26b59820d5168a6df22561aa1561e45c9","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        self.assertIsInstance(pci_device_list[0], pci_device.PciDevice)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    @mock.patch.object(db, \u0027pci_device_get_all_by_node\u0027)"},{"line_number":418,"context_line":"    def test_get_by_compute_node(self, get_mock):"},{"line_number":419,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":420,"context_line":"        get_mock.return_value \u003d fake_pci_devs"},{"line_number":421,"context_line":"        devs \u003d pci_device.PciDeviceList.get_by_compute_node(ctxt, 1)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_dbc0642d","line":418,"range":{"start_line":418,"start_character":39,"end_line":418,"end_character":47},"updated":"2016-11-16 05:29:10.000000000","message":"ditto","commit_id":"1490b2b5bd880759a1be5bde73a6ac29751263cc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be181ad26b59820d5168a6df22561aa1561e45c9","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        devs \u003d pci_device.PciDeviceList.get_by_compute_node(ctxt, 1)"},{"line_number":422,"context_line":"        for i in range(len(fake_pci_devs)):"},{"line_number":423,"context_line":"            self.assertIsInstance(devs[i], pci_device.PciDevice)"},{"line_number":424,"context_line":"            self.assertEqual(fake_pci_devs[i][\u0027vendor_id\u0027], devs[i].vendor_id)"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    @mock.patch.object(db, \u0027pci_device_get_all_by_instance_uuid\u0027)"},{"line_number":427,"context_line":"    def test_get_by_instance_uuid(self, get_mock):"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_bbc5683d","line":424,"range":{"start_line":424,"start_character":77,"end_line":424,"end_character":78},"updated":"2016-11-16 05:29:10.000000000","message":"ditto, should check call is made or not","commit_id":"1490b2b5bd880759a1be5bde73a6ac29751263cc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be181ad26b59820d5168a6df22561aa1561e45c9","unresolved":false,"context_lines":[{"line_number":424,"context_line":"            self.assertEqual(fake_pci_devs[i][\u0027vendor_id\u0027], devs[i].vendor_id)"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    @mock.patch.object(db, \u0027pci_device_get_all_by_instance_uuid\u0027)"},{"line_number":427,"context_line":"    def test_get_by_instance_uuid(self, get_mock):"},{"line_number":428,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":429,"context_line":"        fake_db_1 \u003d dict(fake_db_dev, address\u003d\u0027a1\u0027,"},{"line_number":430,"context_line":"                         status\u003dfields.PciDeviceStatus.ALLOCATED,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_1be1fcd0","line":427,"range":{"start_line":427,"start_character":40,"end_line":427,"end_character":48},"updated":"2016-11-16 05:29:10.000000000","message":"ditto","commit_id":"1490b2b5bd880759a1be5bde73a6ac29751263cc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be181ad26b59820d5168a6df22561aa1561e45c9","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        for i in range(len(fake_pci_devs)):"},{"line_number":439,"context_line":"            self.assertIsInstance(devs[i], pci_device.PciDevice)"},{"line_number":440,"context_line":"        self.assertEqual(devs[0].vendor_id, \u0027v\u0027)"},{"line_number":441,"context_line":"        self.assertEqual(devs[1].vendor_id, \u0027v\u0027)"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"class TestPciDeviceListObject(test_objects._LocalTest,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_3bff9868","line":441,"range":{"start_line":441,"start_character":46,"end_line":441,"end_character":48},"updated":"2016-11-16 05:29:10.000000000","message":"ditto- assert_called_once_with","commit_id":"1490b2b5bd880759a1be5bde73a6ac29751263cc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be181ad26b59820d5168a6df22561aa1561e45c9","unresolved":false,"context_lines":[{"line_number":493,"context_line":"        self.inst.pci_devices \u003d pci_device.PciDeviceList()"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    @mock.patch.object(db, \u0027pci_device_get_by_addr\u0027)"},{"line_number":496,"context_line":"    def _create_fake_pci_device(self, get_mock, ctxt\u003dNone):"},{"line_number":497,"context_line":"        if not ctxt:"},{"line_number":498,"context_line":"            ctxt \u003d context.get_admin_context()"},{"line_number":499,"context_line":"        get_mock.return_value \u003d fake_db_dev"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_9bf42c88","line":496,"range":{"start_line":496,"start_character":38,"end_line":496,"end_character":46},"updated":"2016-11-16 05:29:10.000000000","message":"here too","commit_id":"1490b2b5bd880759a1be5bde73a6ac29751263cc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be181ad26b59820d5168a6df22561aa1561e45c9","unresolved":false,"context_lines":[{"line_number":497,"context_line":"        if not ctxt:"},{"line_number":498,"context_line":"            ctxt \u003d context.get_admin_context()"},{"line_number":499,"context_line":"        get_mock.return_value \u003d fake_db_dev"},{"line_number":500,"context_line":"        self.pci_device \u003d pci_device.PciDevice.get_by_dev_addr(ctxt, 1, \u0027a\u0027)"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def _get_children_by_parent_address(self, addr):"},{"line_number":503,"context_line":"        vf_devs \u003d []"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_7bf91080","line":500,"range":{"start_line":500,"start_character":74,"end_line":500,"end_character":76},"updated":"2016-11-16 05:29:10.000000000","message":"ditto- assert_called_once_with","commit_id":"1490b2b5bd880759a1be5bde73a6ac29751263cc"}]}