)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"24d9db6a3a4b4a80a92151ba5907580625c5ab37","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-04-19 14:31:17 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added user_id to check if admin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie6ffe88e59b1f272ef83a692b33d25c1117b1a5b"},{"line_number":10,"context_line":"Closes-Bug: #968696"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_705bdb2e","line":8,"updated":"2016-04-19 09:07:10.000000000","message":"I think you need to explain what is the problem you are solving here and why you choose this solution","commit_id":"cc23c28cc0b610ea759e356b164f0872e6adadeb"}],"nova/context.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"2af6f0031ba7fb9be28e0313a7d957db818174eb","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        self.user_auth_plugin \u003d user_auth_plugin"},{"line_number":152,"context_line":"        if self.is_admin is None:"},{"line_number":153,"context_line":"            self.is_admin \u003d policy.check_is_admin(self.roles, self)"},{"line_number":154,"context_line":"        elif self.is_admin and \u0027admin\u0027 not in self.roles:"},{"line_number":155,"context_line":"            self.roles.append(\u0027admin\u0027)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def get_auth_plugin(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_97f6128d","line":154,"updated":"2016-04-20 17:28:17.000000000","message":"self.is_admin can be set in the if above this, so shouldn\u0027t this \"elif\" really be an \"if\" to allow for the case that the 1st \"if\" clause sets self.is_admin\u003dTrue?","commit_id":"85958636d4861944b3b4aac86f1059b96fef7652"}],"nova/policy.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"2af6f0031ba7fb9be28e0313a7d957db818174eb","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    return result"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def check_is_admin(roles, context\u003dNone):"},{"line_number":112,"context_line":"    \"\"\"Whether or not user is \u0027admin\u0027 according to policy setting."},{"line_number":113,"context_line":"       Can use roles or user_id from context to determine if user is admin."},{"line_number":114,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_f792e6f4","line":111,"updated":"2016-04-20 17:28:17.000000000","message":"why are you adding a new roles arg here? You never use it below. And I\u0027m not sure what you trying to do here but it seems like a new method might be needed so you don\u0027t have to update every caller of this method to handle the new signature.","commit_id":"85958636d4861944b3b4aac86f1059b96fef7652"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"2af6f0031ba7fb9be28e0313a7d957db818174eb","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    init()"},{"line_number":117,"context_line":"    # the target is user-self"},{"line_number":118,"context_line":"    target \u003d credentials"},{"line_number":119,"context_line":"    if context is None:"},{"line_number":120,"context_line":"        credentials \u003d context.to_dict()"},{"line_number":121,"context_line":"    else:"},{"line_number":122,"context_line":"        credentials \u003d {\u0027roles\u0027: context.roles,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_778256c9","line":119,"updated":"2016-04-20 17:28:17.000000000","message":"I think you mean \"is not\"? If context is None, then the following line will blow up.","commit_id":"85958636d4861944b3b4aac86f1059b96fef7652"}]}