)]}'
{"nova/cache_utils.py":[{"author":{"_account_id":20223,"name":"zhaolihui","email":"zhaolh@awcloud.com","username":"zhaolihui"},"change_message_id":"7b5af2b62f98c11dae5ecb7d062120b045e43ebb","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    # and has [cache]/enabled flag on then we let oslo_cache configure"},{"line_number":80,"context_line":"    # the region from the configuration settings"},{"line_number":81,"context_line":"    elif CONF.cache.enabled and CONF.cache.memcache_servers:"},{"line_number":82,"context_line":"        if not CONF.cache.backend:"},{"line_number":83,"context_line":"            LOG.warning(_LW(\"Cache enabled but no backend specified.\"))"},{"line_number":84,"context_line":"        return CacheClient("},{"line_number":85,"context_line":"                _get_default_cache_region(expiration_time\u003dexpiration_time))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_3516b5f1","line":82,"range":{"start_line":82,"start_character":15,"end_line":82,"end_character":33},"updated":"2016-05-03 11:57:38.000000000","message":"The backend option is no use only for log.","commit_id":"70a7348f036b1182ab4965b080b1a1ce8f6ce50c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3dde094279d842287ec7218d6e79963af64fab7a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    # and has [cache]/enabled flag on then we let oslo_cache configure"},{"line_number":80,"context_line":"    # the region from the configuration settings"},{"line_number":81,"context_line":"    elif CONF.cache.enabled and CONF.cache.memcache_servers:"},{"line_number":82,"context_line":"        if not CONF.cache.backend:"},{"line_number":83,"context_line":"            LOG.warning(_LW(\"Cache enabled but no backend specified.\"))"},{"line_number":84,"context_line":"        return CacheClient("},{"line_number":85,"context_line":"                _get_default_cache_region(expiration_time\u003dexpiration_time))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_68ecd429","line":82,"in_reply_to":"1a122d0e_3516b5f1","updated":"2016-05-03 12:29:37.000000000","message":"It is not used here, but within oslo_cache.","commit_id":"70a7348f036b1182ab4965b080b1a1ce8f6ce50c"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"b603f66f47227345f8698878efc1e3e6103ef604","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Super simple fake memcache client or wrapper for oslo_cache?.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_cache import core as cache"},{"line_number":20,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_88db3ded","line":17,"range":{"start_line":17,"start_character":40,"end_line":17,"end_character":63},"updated":"2016-05-18 10:06:06.000000000","message":"Why are you asking in a docstring ?","commit_id":"368ac346f1710c28130dfc03bc1e11cc6dd5995a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3489f4e6d0a16edb339bc7f66902d96a03f52f14","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Super simple fake memcache client or wrapper for oslo_cache?.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_cache import core as cache"},{"line_number":20,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_354ae8ac","line":17,"in_reply_to":"bab6814e_88db3ded","updated":"2016-05-20 08:51:08.000000000","message":"You are right, I should just propose my new version.","commit_id":"368ac346f1710c28130dfc03bc1e11cc6dd5995a"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"b603f66f47227345f8698878efc1e3e6103ef604","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # If the operator has [cache]/enabled flag on then we let oslo_cache"},{"line_number":46,"context_line":"    # configure the region from configuration settings."},{"line_number":47,"context_line":"    if CONF.cache.enabled:"},{"line_number":48,"context_line":"        if CONF.cache.backend \u003d\u003d \u0027dogpile.cache.null\u0027:"},{"line_number":49,"context_line":"            LOG.warning(_LW(\"Cache enabled with backend dogpile.cache.null.\"))"},{"line_number":50,"context_line":"        return CacheClient("},{"line_number":51,"context_line":"                _get_default_cache_region(expiration_time\u003dexpiration_time))"},{"line_number":52,"context_line":"    # If [cache]/enabled flag is off, we use the dictionary backend"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_4b578f02","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":78},"updated":"2016-05-18 10:06:06.000000000","message":"I think you should extract that code snippet to an external method.","commit_id":"368ac346f1710c28130dfc03bc1e11cc6dd5995a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3489f4e6d0a16edb339bc7f66902d96a03f52f14","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    # configure the region from configuration settings."},{"line_number":47,"context_line":"    if CONF.cache.enabled:"},{"line_number":48,"context_line":"        if CONF.cache.backend \u003d\u003d \u0027dogpile.cache.null\u0027:"},{"line_number":49,"context_line":"            LOG.warning(_LW(\"Cache enabled with backend dogpile.cache.null.\"))"},{"line_number":50,"context_line":"        return CacheClient("},{"line_number":51,"context_line":"                _get_default_cache_region(expiration_time\u003dexpiration_time))"},{"line_number":52,"context_line":"    # If [cache]/enabled flag is off, we use the dictionary backend"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_d5cf1c27","line":49,"in_reply_to":"bab6814e_4b578f02","updated":"2016-05-20 08:51:08.000000000","message":"Done","commit_id":"368ac346f1710c28130dfc03bc1e11cc6dd5995a"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"9e3c2adee9d7b43c672367231e03593c5f197b68","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _warn_if_null_backend():"},{"line_number":33,"context_line":"    if CONF.cache.backend \u003d\u003d \u0027dogpile.cache.null\u0027:"},{"line_number":34,"context_line":"        LOG.warning(_LW(\"Cache enabled with backend dogpile.cache.null.\"))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def get_memcached_client(expiration_time\u003d0):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_93d0ccca","line":34,"updated":"2016-05-23 06:18:24.000000000","message":"I feel this should be more actionable. Is it reasonable to run like this? What are the implications? An operator isn\u0027t going to have read the oslo cache code to understand the implications.","commit_id":"59192cfbf9482fe3798cdcd4c2044d8c85f66e95"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1ebfbef91a5d960b52905444d08614d0f04ea1e2","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _warn_if_null_backend():"},{"line_number":33,"context_line":"    if CONF.cache.backend \u003d\u003d \u0027dogpile.cache.null\u0027:"},{"line_number":34,"context_line":"        LOG.warning(_LW(\"Cache enabled with backend dogpile.cache.null.\"))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def get_memcached_client(expiration_time\u003d0):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_5fb665f9","line":34,"in_reply_to":"bab6814e_93d0ccca","updated":"2016-05-23 08:02:12.000000000","message":"It depends on the application using this code, which is why I refrained from making this more severe. \n\navailability_zones.py e.g. looks like it will run just fine, there will only be a bit less performance without caching.\n\nnova-consoleauth OTOH will be mostly non-functional, it will happily create tokens, but consider them invalid when it cannot find them in its cache, see the linked bug.","commit_id":"59192cfbf9482fe3798cdcd4c2044d8c85f66e95"}]}