)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b8829f5dda22a3a373c72b6044a0980c8f5e2fa2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brian Elliott \u003cbdelliott@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-19 18:36:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"xenapi: Fix xmlrpclib marashalling error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix an error that occurs when trying to marshal an"},{"line_number":10,"context_line":"oslo_i18n._message.Message object via xmlrpclib."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_a1dfcb0b","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":34},"updated":"2016-04-19 18:43:42.000000000","message":"marshalling","commit_id":"9cad5948eb1cb0b411dac611a97cd0ca797cb34d"}],"nova/virt/xenapi/client/session.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b8829f5dda22a3a373c72b6044a0980c8f5e2fa2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from oslo_utils import versionutils"},{"line_number":30,"context_line":"from six.moves import range"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"try:"},{"line_number":33,"context_line":"    import xmlrpclib"},{"line_number":34,"context_line":"except ImportError:"},{"line_number":35,"context_line":"    import six.moves.xmlrpc_client as xmlrpclib"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"import nova.conf"},{"line_number":38,"context_line":"from nova import context"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_21cd7b66","line":35,"range":{"start_line":32,"start_character":0,"end_line":35,"end_character":47},"updated":"2016-04-19 18:43:42.000000000","message":"Do we mock this all out in unit tests? If not, we could add a simple test to make sure that passing self.nova_version to xmlrpclib doesn\u0027t explode.","commit_id":"9cad5948eb1cb0b411dac611a97cd0ca797cb34d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9f070796cd0828b899dbc42df0e720737cd2972c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from oslo_utils import versionutils"},{"line_number":30,"context_line":"from six.moves import range"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"try:"},{"line_number":33,"context_line":"    import xmlrpclib"},{"line_number":34,"context_line":"except ImportError:"},{"line_number":35,"context_line":"    import six.moves.xmlrpc_client as xmlrpclib"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"import nova.conf"},{"line_number":38,"context_line":"from nova import context"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_f4da1fe7","line":35,"range":{"start_line":32,"start_character":0,"end_line":35,"end_character":47},"updated":"2016-04-19 19:13:23.000000000","message":"Can we test this by sending nova_version to xmlrpclib?","commit_id":"fd9bedb7a907dece1b4114be782e6baa89182f42"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"08333d3070f6e6cba77320f7621f9422da0fcaed","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from oslo_utils import versionutils"},{"line_number":30,"context_line":"from six.moves import range"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"try:"},{"line_number":33,"context_line":"    import xmlrpclib"},{"line_number":34,"context_line":"except ImportError:"},{"line_number":35,"context_line":"    import six.moves.xmlrpc_client as xmlrpclib"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"import nova.conf"},{"line_number":38,"context_line":"from nova import context"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_bbc08b51","line":35,"range":{"start_line":32,"start_character":0,"end_line":35,"end_character":47},"in_reply_to":"1a122d0e_f4da1fe7","updated":"2016-04-19 23:59:36.000000000","message":"Actually self.nova_version \u003d ... evaluates to a \u0027oslo_i18n._message.Message\u0027 instance for the running service, but is just a unicode string when I run tests.\n\nI don\u0027t really understand this code, but it seems like the i18n stuff is stubbed out somehow in the unit tests so I\u0027m not sure how to write a test for the behavior?","commit_id":"fd9bedb7a907dece1b4114be782e6baa89182f42"}]}