)]}'
{"nova/objects/instance.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"d59c70cca3ef38b0e17b0889dba35d04a864bc24","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                       expected_attrs\u003dNone):"},{"line_number":270,"context_line":"        db_inst_list \u003d db.instance_get_all_by_filters("},{"line_number":271,"context_line":"            context, filters, sort_key, sort_dir, limit, marker,"},{"line_number":272,"context_line":"            expected_attrs)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        return _make_instance_list(cls(), db_inst_list, expected_attrs)"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2FitI%3D","line":272,"updated":"2013-05-30 21:21:47.000000000","message":"I get nit-picky when using kwargs as positional arguments.. but not enough to ask you to change this. :)   On the other hand, columns_to_join\u003dexpected_attrs makes it more obvious that the DB call is expecting column names right now.","commit_id":"a8160924f71a55b93de8505d7866bfe61d57d453"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"6138b1edd58c43e8aa82f91492a51ab59159eb57","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                       expected_attrs\u003dNone):"},{"line_number":272,"context_line":"        db_inst_list \u003d db.instance_get_all_by_filters("},{"line_number":273,"context_line":"            context, filters, sort_key, sort_dir, limit, marker,"},{"line_number":274,"context_line":"            columns_to_join\u003dexpected_attrs)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        return _make_instance_list(context, cls(), db_inst_list,"},{"line_number":277,"context_line":"                                   expected_attrs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPH%2F%2Fc2Q%3D","line":274,"updated":"2013-06-03 17:17:15.000000000","message":"You fixed this one!  (Thanks)","commit_id":"99e522fca43cb07023b8246d148474dbf69bac9f"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"6138b1edd58c43e8aa82f91492a51ab59159eb57","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            columns_to_join\u003dexpected_attrs)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        return _make_instance_list(context, cls(), db_inst_list,"},{"line_number":277,"context_line":"                                   expected_attrs)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    @base.remotable_classmethod"},{"line_number":280,"context_line":"    def get_by_host(cls, context, host, expected_attrs\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPH%2F%2Fc2I%3D","line":277,"updated":"2013-06-03 17:17:15.000000000","message":"But not this one! (Sad face)","commit_id":"99e522fca43cb07023b8246d148474dbf69bac9f"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"625cf57d873d4c306e4b9d736dedf28a703cdc13","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"def _make_instance_list(context, inst_list, db_inst_list, expected_attrs):"},{"line_number":242,"context_line":"    inst_list.instances \u003d []"},{"line_number":243,"context_line":"    for db_inst in db_inst_list:"},{"line_number":244,"context_line":"        inst_obj \u003d Instance._from_db_object(Instance(), db_inst,"},{"line_number":245,"context_line":"                                            expected_attrs\u003dexpected_attrs)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAPX%2F%2F9%2FE%3D","line":242,"updated":"2013-06-04 22:43:17.000000000","message":"Does this make this dirty?  Ie, do we need to reset_changes()?","commit_id":"dc187958b6f0b3beb805edf97c33ce22bcc3b59b"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"99751808b2dcade0e2f563852f61d8ff667f97a8","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"def _make_instance_list(context, inst_list, db_inst_list, expected_attrs):"},{"line_number":242,"context_line":"    inst_list.instances \u003d []"},{"line_number":243,"context_line":"    for db_inst in db_inst_list:"},{"line_number":244,"context_line":"        inst_obj \u003d Instance._from_db_object(Instance(), db_inst,"},{"line_number":245,"context_line":"                                            expected_attrs\u003dexpected_attrs)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAPX%2F%2F9Gk%3D","line":242,"updated":"2013-06-05 09:02:18.000000000","message":"From previous PS:  Doesn\u0027t this make the list dirty... ie, won\u0027t you need a reset_changes() ?","commit_id":"67a73ed92bfb69f5757325004b7c690e7ae2ce10"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"74654fdff63f3c6511c78ad9db6cd1aeb0435637","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"def _make_instance_list(context, inst_list, db_inst_list, expected_attrs):"},{"line_number":242,"context_line":"    inst_list.instances \u003d []"},{"line_number":243,"context_line":"    for db_inst in db_inst_list:"},{"line_number":244,"context_line":"        inst_obj \u003d Instance._from_db_object(Instance(), db_inst,"},{"line_number":245,"context_line":"                                            expected_attrs\u003dexpected_attrs)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAPX%2F%2F8Wg%3D","line":242,"in_reply_to":"AAAAPX%2F%2F9Gk%3D","updated":"2013-06-05 16:14:53.000000000","message":"All of the stuff in this helper does, yeah, good call :)","commit_id":"67a73ed92bfb69f5757325004b7c690e7ae2ce10"}],"nova/tests/objects/test_instance.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"a7fd95bd4225f92abf9a3dd53158eeb10d3e4b32","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_get_by_host(self):"},{"line_number":225,"context_line":"        fakes \u003d [self.fake_instance(1),"},{"line_number":226,"context_line":"                 self.fake_instance(2)]"},{"line_number":227,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":228,"context_line":"        self.mox.StubOutWithMock(db, \u0027instance_get_all_by_host\u0027)"},{"line_number":229,"context_line":"        db.instance_get_all_by_host(ctxt, \u0027foo\u0027, None).AndReturn(fakes)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2Fj7E%3D","line":226,"updated":"2013-05-30 14:42:19.000000000","message":"Unnecessary newline since the list is so short, and inconsistent with the test above.  (But consistent with the ones below.)","commit_id":"2489ca09a69e170896784d9247b47b8f520f2e16"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"027a026b1fcf2ac2389fd2e246273bd57cde0f3e","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        inst_list \u003d instance.InstanceList.get_by_filters("},{"line_number":231,"context_line":"            ctxt, {\u0027foo\u0027: \u0027bar\u0027}, \u0027uuid\u0027, \u0027asc\u0027, expected_attrs\u003d[\u0027metadata\u0027])"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        for i in range(0, len(fakes)):"},{"line_number":234,"context_line":"            self.assertTrue(isinstance(inst_list.objects[i],"},{"line_number":235,"context_line":"                                       instance.Instance))"},{"line_number":236,"context_line":"            self.assertEqual(inst_list.objects[i].uuid, fakes[i][\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPX%2F%2F17E%3D","line":233,"updated":"2013-06-07 19:09:34.000000000","message":"Nit: 0 is the default start for range.  Ditto elsewhere that it shows up in this file.","commit_id":"e86d5b063bbb741d411bf4b50b5cc8a9829960db"}]}