)]}'
{"nova/tests/unit/compute/test_host_api.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b0932ff4bce0c7072691a8ad2674a92e63db8fce","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        @mock.patch.object(self.host_api.db, \u0027service_get_all\u0027)"},{"line_number":209,"context_line":"        def _do_test(mock_service_get_all):"},{"line_number":210,"context_line":"            mock_service_get_all.retuen_value \u003d services"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            # Test no filters"},{"line_number":213,"context_line":"            result \u003d self.host_api.service_get_all(self.ctxt, set_zones\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_86a978e2","line":210,"range":{"start_line":210,"start_character":33,"end_line":210,"end_character":45},"updated":"2016-04-22 02:51:58.000000000","message":"typo","commit_id":"e9f71acf061d2498b10c46ea82b7636b76fbe7f8"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9db2879e6eedcbaaf39f57f31de04f4e705a761d","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        @mock.patch.object(self.host_api.db, \u0027service_get_all\u0027)"},{"line_number":209,"context_line":"        def _do_test(mock_service_get_all):"},{"line_number":210,"context_line":"            mock_service_get_all.retuen_value \u003d services"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            # Test no filters"},{"line_number":213,"context_line":"            result \u003d self.host_api.service_get_all(self.ctxt, set_zones\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_6ace6884","line":210,"range":{"start_line":210,"start_character":33,"end_line":210,"end_character":45},"in_reply_to":"1a122d0e_04bd3fd7","updated":"2016-04-23 16:47:19.000000000","message":"Keen eyes, nice point :-)","commit_id":"e9f71acf061d2498b10c46ea82b7636b76fbe7f8"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"4b2fdb809cb6b9ac218bcd310d295b8e2c3dc314","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        @mock.patch.object(self.host_api.db, \u0027service_get_all\u0027)"},{"line_number":209,"context_line":"        def _do_test(mock_service_get_all):"},{"line_number":210,"context_line":"            mock_service_get_all.retuen_value \u003d services"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            # Test no filters"},{"line_number":213,"context_line":"            result \u003d self.host_api.service_get_all(self.ctxt, set_zones\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f17bc427","line":210,"range":{"start_line":210,"start_character":33,"end_line":210,"end_character":45},"in_reply_to":"1a122d0e_26586456","updated":"2016-04-22 04:03:06.000000000","message":"If result is [] (blank list), the inside of \u0027for\u0027 statement in _compare_objs method is not executed.\nSo the unit test did not fail.","commit_id":"e9f71acf061d2498b10c46ea82b7636b76fbe7f8"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c013b68379440a6a61c62997f00567816edef84d","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        @mock.patch.object(self.host_api.db, \u0027service_get_all\u0027)"},{"line_number":209,"context_line":"        def _do_test(mock_service_get_all):"},{"line_number":210,"context_line":"            mock_service_get_all.retuen_value \u003d services"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            # Test no filters"},{"line_number":213,"context_line":"            result \u003d self.host_api.service_get_all(self.ctxt, set_zones\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_26586456","line":210,"range":{"start_line":210,"start_character":33,"end_line":210,"end_character":45},"in_reply_to":"1a122d0e_86a978e2","updated":"2016-04-22 03:32:30.000000000","message":"Thank you for pointing it out.\nIt is a typo certainly.\nBut I cannot see why the unit test did not fail.","commit_id":"e9f71acf061d2498b10c46ea82b7636b76fbe7f8"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"382729d4c8cdd19f9bb54fd32125003838092fc0","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        @mock.patch.object(self.host_api.db, \u0027service_get_all\u0027)"},{"line_number":209,"context_line":"        def _do_test(mock_service_get_all):"},{"line_number":210,"context_line":"            mock_service_get_all.retuen_value \u003d services"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            # Test no filters"},{"line_number":213,"context_line":"            result \u003d self.host_api.service_get_all(self.ctxt, set_zones\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_04bd3fd7","line":210,"range":{"start_line":210,"start_character":33,"end_line":210,"end_character":45},"in_reply_to":"1a122d0e_f17bc427","updated":"2016-04-22 17:50:00.000000000","message":"Thanks for looking into that. I wonder if we should do a check in _compare_objs to raise an error if list is empty to guard against these.","commit_id":"e9f71acf061d2498b10c46ea82b7636b76fbe7f8"}]}