)]}'
{"nova/tests/unit/api/openstack/compute/test_certificates.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5e3e3766c4944f9f3f914614e28983bb5472e3f5","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.assertEqual(view[\u0027private_key\u0027], pk)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @mock.patch.object(rpcapi.CertAPI, \u0027fetch_ca\u0027, return_value\u003d\u0027fakeroot\u0027)"},{"line_number":54,"context_line":"    def test_certificates_show_root(self, mock_fetch_ca):"},{"line_number":55,"context_line":"        res_dict \u003d self.controller.show(self.req, \u0027root\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        response \u003d {\u0027certificate\u0027: {\u0027data\u0027: \u0027fakeroot\u0027, \u0027private_key\u0027: None}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_bf6fa090","line":54,"updated":"2016-04-28 19:42:01.000000000","message":"Actually, to make this equivalent I think you\u0027d need to do something like:\n\n mock_fetch_ca.assert_called_once_with(mock.ANY, project_id\u003d\u0027fake\u0027)","commit_id":"ec4b44d8d07a6c29888f7c43d8013f9f86bd69d3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6e1655285641411a9953d13287576458ca0486b8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.assertEqual(view[\u0027private_key\u0027], pk)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @mock.patch.object(rpcapi.CertAPI, \u0027fetch_ca\u0027, return_value\u003d\u0027fakeroot\u0027)"},{"line_number":54,"context_line":"    def test_certificates_show_root(self, mock_fetch_ca):"},{"line_number":55,"context_line":"        res_dict \u003d self.controller.show(self.req, \u0027root\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        response \u003d {\u0027certificate\u0027: {\u0027data\u0027: \u0027fakeroot\u0027, \u0027private_key\u0027: None}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_906bb3f0","line":54,"in_reply_to":"1a122d0e_70fff765","updated":"2016-04-28 21:42:55.000000000","message":"No because the return value is set by the test in the mock (see L53). But indeed the pre-mock test was checking the expected call whereas this patch isn\u0027t","commit_id":"ec4b44d8d07a6c29888f7c43d8013f9f86bd69d3"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"6503acc7aad8cc83c5a727f91ce1ed913dfda7f8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.assertEqual(view[\u0027private_key\u0027], pk)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @mock.patch.object(rpcapi.CertAPI, \u0027fetch_ca\u0027, return_value\u003d\u0027fakeroot\u0027)"},{"line_number":54,"context_line":"    def test_certificates_show_root(self, mock_fetch_ca):"},{"line_number":55,"context_line":"        res_dict \u003d self.controller.show(self.req, \u0027root\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        response \u003d {\u0027certificate\u0027: {\u0027data\u0027: \u0027fakeroot\u0027, \u0027private_key\u0027: None}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_6e7eee19","line":54,"in_reply_to":"1a122d0e_906bb3f0","updated":"2016-04-29 11:08:18.000000000","message":"Melanie, Thank you for your review.\nI will fix it.","commit_id":"ec4b44d8d07a6c29888f7c43d8013f9f86bd69d3"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"f056879435bca588df22fa542a43e0dcf2cf8693","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.assertEqual(view[\u0027private_key\u0027], pk)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @mock.patch.object(rpcapi.CertAPI, \u0027fetch_ca\u0027, return_value\u003d\u0027fakeroot\u0027)"},{"line_number":54,"context_line":"    def test_certificates_show_root(self, mock_fetch_ca):"},{"line_number":55,"context_line":"        res_dict \u003d self.controller.show(self.req, \u0027root\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        response \u003d {\u0027certificate\u0027: {\u0027data\u0027: \u0027fakeroot\u0027, \u0027private_key\u0027: None}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_70fff765","line":54,"in_reply_to":"1a122d0e_bf6fa090","updated":"2016-04-28 21:33:45.000000000","message":"and woudn\u0027t you also need to check the return value of \u0027fakeroot\u0027?","commit_id":"ec4b44d8d07a6c29888f7c43d8013f9f86bd69d3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5e3e3766c4944f9f3f914614e28983bb5472e3f5","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @mock.patch.object(rpcapi.CertAPI, \u0027generate_x509_cert\u0027,"},{"line_number":71,"context_line":"                       return_value\u003d(\u0027fakepk\u0027, \u0027fakecert\u0027))"},{"line_number":72,"context_line":"    def test_certificates_create_certificate(self, mock_generate_x509_cert):"},{"line_number":73,"context_line":"        res_dict \u003d self.controller.create(self.req)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        response \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_3f0a70d2","line":72,"updated":"2016-04-28 19:42:01.000000000","message":"Similar comment","commit_id":"ec4b44d8d07a6c29888f7c43d8013f9f86bd69d3"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"6503acc7aad8cc83c5a727f91ce1ed913dfda7f8","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @mock.patch.object(rpcapi.CertAPI, \u0027generate_x509_cert\u0027,"},{"line_number":71,"context_line":"                       return_value\u003d(\u0027fakepk\u0027, \u0027fakecert\u0027))"},{"line_number":72,"context_line":"    def test_certificates_create_certificate(self, mock_generate_x509_cert):"},{"line_number":73,"context_line":"        res_dict \u003d self.controller.create(self.req)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        response \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_4e79722e","line":72,"in_reply_to":"1a122d0e_3f0a70d2","updated":"2016-04-29 11:08:18.000000000","message":"I will also fix it.","commit_id":"ec4b44d8d07a6c29888f7c43d8013f9f86bd69d3"}]}