)]}'
{"nova/compute/api.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"f043c8f85127f12177bb6d22202c609f54b835d0","unresolved":false,"context_lines":[{"line_number":1991,"context_line":"                                       old_instance_type, 1, -1)"},{"line_number":1992,"context_line":""},{"line_number":1993,"context_line":"    @staticmethod"},{"line_number":1994,"context_line":"    def _reserve_quota_delta(context, expire\u003dNone, project_id\u003dNone, **deltas):"},{"line_number":1995,"context_line":"        return QUOTAS.reserve(context, expire, project_id,"},{"line_number":1996,"context_line":"                              **deltas) if deltas \\"},{"line_number":1997,"context_line":"            else None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FnmA%3D","line":1994,"updated":"2013-05-29 07:08:14.000000000","message":"This should be (context, deltas, expire\u003dNone, project_id\u003dNone).\n\nIt\u0027s cleaner... and the **deltas here should be causing a bug... because you only fixed the 1 call to it... but there are multiple calls in this file that pass a dictionary of deltas.","commit_id":"20fa69dfdc2c36e0ae89cb4ada6880fd9062c2d2"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"f043c8f85127f12177bb6d22202c609f54b835d0","unresolved":false,"context_lines":[{"line_number":1994,"context_line":"    def _reserve_quota_delta(context, expire\u003dNone, project_id\u003dNone, **deltas):"},{"line_number":1995,"context_line":"        return QUOTAS.reserve(context, expire, project_id,"},{"line_number":1996,"context_line":"                              **deltas) if deltas \\"},{"line_number":1997,"context_line":"            else None"},{"line_number":1998,"context_line":""},{"line_number":1999,"context_line":"    @wrap_check_policy"},{"line_number":2000,"context_line":"    @check_instance_lock"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FnmM%3D","line":1997,"updated":"2013-05-29 07:08:14.000000000","message":"We try to avoid use of \\.  This is probably now better done as:\n---\nif not deltas:\n    return\nreturn QUOTAS.reserve()\n---","commit_id":"20fa69dfdc2c36e0ae89cb4ada6880fd9062c2d2"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"f043c8f85127f12177bb6d22202c609f54b835d0","unresolved":false,"context_lines":[{"line_number":2052,"context_line":"        try:"},{"line_number":2053,"context_line":"            reservations \u003d self._reserve_quota_delta(context, None,"},{"line_number":2054,"context_line":"                                                     instance[\u0027project_id\u0027],"},{"line_number":2055,"context_line":"                                                     **deltas)"},{"line_number":2056,"context_line":"        except exception.OverQuota as exc:"},{"line_number":2057,"context_line":"            quotas \u003d exc.kwargs[\u0027quotas\u0027]"},{"line_number":2058,"context_line":"            usages \u003d exc.kwargs[\u0027usages\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fnl0%3D","line":2055,"updated":"2013-05-29 07:08:14.000000000","message":"(context, deltas, project_id\u003dinstance[\u0027project_id\u0027])  with the above  fix I mentioned.","commit_id":"20fa69dfdc2c36e0ae89cb4ada6880fd9062c2d2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c2da098cf37ba5f2d80bb92e684c033838d9cf77","unresolved":false,"context_lines":[{"line_number":1987,"context_line":"                                       old_instance_type, 1, -1)"},{"line_number":1988,"context_line":""},{"line_number":1989,"context_line":"    @staticmethod"},{"line_number":1990,"context_line":"    def _reserve_quota_delta(context, deltas, expire\u003dNone, project_id\u003dNone):"},{"line_number":1991,"context_line":"        if not deltas:"},{"line_number":1992,"context_line":"            return"},{"line_number":1993,"context_line":"        return QUOTAS.reserve(context, expire, project_id, **deltas)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fkf8%3D","line":1990,"updated":"2013-05-30 10:42:22.000000000","message":"don\u0027t really need expire here I guess?","commit_id":"44533695e0f0483d5150df1dc5d671b62b128ac2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c2da098cf37ba5f2d80bb92e684c033838d9cf77","unresolved":false,"context_lines":[{"line_number":2094,"context_line":"        # With cells, the best we can do right now is commit the reservations"},{"line_number":2095,"context_line":"        # immediately..."},{"line_number":2096,"context_line":"        if CONF.cells.enable and reservations:"},{"line_number":2097,"context_line":"            QUOTAS.commit(context, reservations, instance[\u0027project_id\u0027])"},{"line_number":2098,"context_line":"            reservations \u003d []"},{"line_number":2099,"context_line":""},{"line_number":2100,"context_line":"        args \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FkfY%3D","line":2097,"updated":"2013-05-30 10:42:22.000000000","message":"is there a test for this one?","commit_id":"44533695e0f0483d5150df1dc5d671b62b128ac2"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"20867503ef42c631964f46365b99fa980922b183","unresolved":false,"context_lines":[{"line_number":2096,"context_line":"        # With cells, the best we can do right now is commit the reservations"},{"line_number":2097,"context_line":"        # immediately..."},{"line_number":2098,"context_line":"        if CONF.cells.enable and reservations:"},{"line_number":2099,"context_line":"            QUOTAS.commit(context, reservations, instance[\u0027project_id\u0027])"},{"line_number":2100,"context_line":"            reservations \u003d []"},{"line_number":2101,"context_line":""},{"line_number":2102,"context_line":"        args \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2F%2Ftk%3D","line":2099,"updated":"2013-06-04 08:11:20.000000000","message":"Since it\u0027s a keyword arg, I would prefer to see: project_id\u003d  on that 3rd arg.","commit_id":"07e35fb6a59af604a813228466ad0d89d4f99cd6"},{"author":{"_account_id":7490,"name":"Navneet Kumar","email":"navneetk@thoughtworks.com","username":"navneetk"},"change_message_id":"780d687d337256cb8d2e681243760f113633ae02","unresolved":false,"context_lines":[{"line_number":2096,"context_line":"        # With cells, the best we can do right now is commit the reservations"},{"line_number":2097,"context_line":"        # immediately..."},{"line_number":2098,"context_line":"        if CONF.cells.enable and reservations:"},{"line_number":2099,"context_line":"            QUOTAS.commit(context, reservations, instance[\u0027project_id\u0027])"},{"line_number":2100,"context_line":"            reservations \u003d []"},{"line_number":2101,"context_line":""},{"line_number":2102,"context_line":"        args \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2F%2FnY%3D","line":2099,"in_reply_to":"AAAAPX%2F%2F%2Ftk%3D","updated":"2013-06-04 09:01:50.000000000","message":"Done","commit_id":"07e35fb6a59af604a813228466ad0d89d4f99cd6"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c2da098cf37ba5f2d80bb92e684c033838d9cf77","unresolved":false,"context_lines":[{"line_number":6301,"context_line":""},{"line_number":6302,"context_line":"        CONF.cells.enable \u003d True"},{"line_number":6303,"context_line":"        self.mox.StubOutWithMock(nova.quota.QUOTAS, \u0027commit\u0027)"},{"line_number":6304,"context_line":"        nova.quota.QUOTAS.commit(mox.IgnoreArg(), mox.IgnoreArg(),"},{"line_number":6305,"context_line":"                                 user_project_id)"},{"line_number":6306,"context_line":"        self.mox.ReplayAll()"},{"line_number":6307,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fkfk%3D","line":6304,"updated":"2013-05-30 10:42:22.000000000","message":"Seems a bit bad not to check these args, but not 100% sure.","commit_id":"44533695e0f0483d5150df1dc5d671b62b128ac2"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b219f17538323ddd6943620a5dadc5305ea5c28a","unresolved":false,"context_lines":[{"line_number":6532,"context_line":""},{"line_number":6533,"context_line":"        self.compute_api._reserve_quota_delta(self.context,"},{"line_number":6534,"context_line":"                                              deltas,"},{"line_number":6535,"context_line":"                                              project_id\u003duser_project_id). \\"},{"line_number":6536,"context_line":"            AndReturn(reservations)"},{"line_number":6537,"context_line":""},{"line_number":6538,"context_line":"        CONF.cells.enable \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2F%2Bmg%3D","line":6535,"updated":"2013-06-04 17:59:52.000000000","message":"femtonit: eliminate the space between the \u0027.\u0027 and the \u0027\\\u0027","commit_id":"90453d5c60e7a9d023c916ad257c03f47a4e4031"}]}