)]}'
{"nova/tests/test_db_api.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"3688383baa95099e803c9a5d30738130bbe982c1","unresolved":false,"context_lines":[{"line_number":4150,"context_line":"            \u0027rpc_virtual_host\u0027: \u0027virthost\u0027"},{"line_number":4151,"context_line":"        }"},{"line_number":4152,"context_line":""},{"line_number":4153,"context_line":"    _ignored_keys \u003d [\u0027id\u0027, \u0027deleted\u0027, \u0027deleted_at\u0027, \u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":4154,"context_line":""},{"line_number":4155,"context_line":"    def _cell_value_modify(self, value, step):"},{"line_number":4156,"context_line":"        if isinstance(value, str):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FnD4%3D","line":4153,"updated":"2013-05-29 12:36:44.000000000","message":"is better when such things are on top","commit_id":"97e34e9d768becb22f0cd568eeb832e0ce01d3d4"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"882c01ebbefa65e2538d0937c37c214622b93684","unresolved":false,"context_lines":[{"line_number":4150,"context_line":"            \u0027rpc_virtual_host\u0027: \u0027virthost\u0027"},{"line_number":4151,"context_line":"        }"},{"line_number":4152,"context_line":""},{"line_number":4153,"context_line":"    _ignored_keys \u003d [\u0027id\u0027, \u0027deleted\u0027, \u0027deleted_at\u0027, \u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":4154,"context_line":""},{"line_number":4155,"context_line":"    def _cell_value_modify(self, value, step):"},{"line_number":4156,"context_line":"        if isinstance(value, str):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fm4A%3D","line":4153,"in_reply_to":"AAAAPH%2F%2FnD4%3D","updated":"2013-05-29 13:27:56.000000000","message":"Done","commit_id":"97e34e9d768becb22f0cd568eeb832e0ce01d3d4"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"3688383baa95099e803c9a5d30738130bbe982c1","unresolved":false,"context_lines":[{"line_number":4163,"context_line":"    def _create_cells(self):"},{"line_number":4164,"context_line":"        test_values \u003d []"},{"line_number":4165,"context_line":"        for x in xrange(1, 4):"},{"line_number":4166,"context_line":"            d \u003d dict([(k, self._cell_value_modify(v, x))"},{"line_number":4167,"context_line":"                        for k, v in self._get_cell_base_values().iteritems()])"},{"line_number":4168,"context_line":"            db.cell_create(self.ctxt, d)"},{"line_number":4169,"context_line":"            test_values.append(d)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FnFo%3D","line":4166,"updated":"2013-05-29 12:36:44.000000000","message":"\"d\" is not good name for such variable. how about \"values\"?","commit_id":"97e34e9d768becb22f0cd568eeb832e0ce01d3d4"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"882c01ebbefa65e2538d0937c37c214622b93684","unresolved":false,"context_lines":[{"line_number":4163,"context_line":"    def _create_cells(self):"},{"line_number":4164,"context_line":"        test_values \u003d []"},{"line_number":4165,"context_line":"        for x in xrange(1, 4):"},{"line_number":4166,"context_line":"            d \u003d dict([(k, self._cell_value_modify(v, x))"},{"line_number":4167,"context_line":"                        for k, v in self._get_cell_base_values().iteritems()])"},{"line_number":4168,"context_line":"            db.cell_create(self.ctxt, d)"},{"line_number":4169,"context_line":"            test_values.append(d)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fm34%3D","line":4166,"in_reply_to":"AAAAPH%2F%2FnFo%3D","updated":"2013-05-29 13:27:56.000000000","message":"Done","commit_id":"97e34e9d768becb22f0cd568eeb832e0ce01d3d4"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"3688383baa95099e803c9a5d30738130bbe982c1","unresolved":false,"context_lines":[{"line_number":4213,"context_line":"        new_cells \u003d self._create_cells()"},{"line_number":4214,"context_line":"        cells \u003d db.cell_get_all(self.ctxt)"},{"line_number":4215,"context_line":"        self.assertEqual(len(new_cells), len(cells))"},{"line_number":4216,"context_line":"        d1 \u003d dict([(o[\u0027name\u0027], o) for o in new_cells])"},{"line_number":4217,"context_line":"        for o1 in cells:"},{"line_number":4218,"context_line":"            self._assertEqualObjects(o1, d1[o1[\u0027name\u0027]], self._ignored_keys)"},{"line_number":4219,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FnEE%3D","line":4216,"updated":"2013-05-29 12:36:44.000000000","message":"same here. maybe is better to rename\n\no -\u003e cell\n\nd1 -\u003e something sensible","commit_id":"97e34e9d768becb22f0cd568eeb832e0ce01d3d4"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"882c01ebbefa65e2538d0937c37c214622b93684","unresolved":false,"context_lines":[{"line_number":4213,"context_line":"        new_cells \u003d self._create_cells()"},{"line_number":4214,"context_line":"        cells \u003d db.cell_get_all(self.ctxt)"},{"line_number":4215,"context_line":"        self.assertEqual(len(new_cells), len(cells))"},{"line_number":4216,"context_line":"        d1 \u003d dict([(o[\u0027name\u0027], o) for o in new_cells])"},{"line_number":4217,"context_line":"        for o1 in cells:"},{"line_number":4218,"context_line":"            self._assertEqualObjects(o1, d1[o1[\u0027name\u0027]], self._ignored_keys)"},{"line_number":4219,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fm30%3D","line":4216,"in_reply_to":"AAAAPH%2F%2FnEE%3D","updated":"2013-05-29 13:27:56.000000000","message":"Done","commit_id":"97e34e9d768becb22f0cd568eeb832e0ce01d3d4"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"47267fb1d0c48b36832f026e00249acb350f2a3b","unresolved":false,"context_lines":[{"line_number":4157,"context_line":"            return value + str(step)"},{"line_number":4158,"context_line":"        if isinstance(value, float):"},{"line_number":4159,"context_line":"            return value + step + 0.6"},{"line_number":4160,"context_line":"        if isinstance(value, int) is int:"},{"line_number":4161,"context_line":"            return value + step"},{"line_number":4162,"context_line":""},{"line_number":4163,"context_line":"    def _create_cells(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fja0%3D","line":4160,"updated":"2013-05-30 17:16:59.000000000","message":"seems like a typo/bug","commit_id":"6a82802abfc213a47d9648f6376916cdabd3a721"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e7f3e677d17da9be6ec33104bae1d26bf2dcc9c6","unresolved":false,"context_lines":[{"line_number":4157,"context_line":"            return value + str(step)"},{"line_number":4158,"context_line":"        if isinstance(value, float):"},{"line_number":4159,"context_line":"            return value + step + 0.6"},{"line_number":4160,"context_line":"        if isinstance(value, int) is int:"},{"line_number":4161,"context_line":"            return value + step"},{"line_number":4162,"context_line":""},{"line_number":4163,"context_line":"    def _create_cells(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fhx0%3D","line":4160,"in_reply_to":"AAAAPH%2F%2Fja0%3D","updated":"2013-05-31 07:21:12.000000000","message":"Done","commit_id":"6a82802abfc213a47d9648f6376916cdabd3a721"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"854fb6060a936214601dc92f826e90417529c560","unresolved":false,"context_lines":[{"line_number":4580,"context_line":"            return value + str(step)"},{"line_number":4581,"context_line":"        if isinstance(value, float):"},{"line_number":4582,"context_line":"            return value + step + 0.6"},{"line_number":4583,"context_line":"        if isinstance(value, int):"},{"line_number":4584,"context_line":"            return value + step"},{"line_number":4585,"context_line":""},{"line_number":4586,"context_line":"    def _create_cells(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2Fhoc%3D","line":4583,"updated":"2013-05-31 09:03:43.000000000","message":"bool isinstance int also","commit_id":"99ba145756229d8dc0e415cd28c4a7353e9c0683"},{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"571d453447ced21df12f098202b0bc22acd91316","unresolved":false,"context_lines":[{"line_number":4578,"context_line":"    def _cell_value_modify(self, value, step):"},{"line_number":4579,"context_line":"        if isinstance(value, str):"},{"line_number":4580,"context_line":"            return value + str(step)"},{"line_number":4581,"context_line":"        if isinstance(value, float):"},{"line_number":4582,"context_line":"            return value + step + 0.6"},{"line_number":4583,"context_line":"        if isinstance(value, bool):"},{"line_number":4584,"context_line":"            return bool(step % 2)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2FdY8%3D","line":4581,"updated":"2013-06-03 14:44:30.000000000","message":"I would use elif instead of if for the next 3.  I know it doesn\u0027t *really* matter because the return statements guarantee no fallthrough, but it makes the code more readable.","commit_id":"5245867d1acdfe413361d5d832f9b6d359d6dc0f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5fbd898d3d7be17c58cf247d2f4227962506ffaf","unresolved":false,"context_lines":[{"line_number":4578,"context_line":"    def _cell_value_modify(self, value, step):"},{"line_number":4579,"context_line":"        if isinstance(value, str):"},{"line_number":4580,"context_line":"            return value + str(step)"},{"line_number":4581,"context_line":"        if isinstance(value, float):"},{"line_number":4582,"context_line":"            return value + step + 0.6"},{"line_number":4583,"context_line":"        if isinstance(value, bool):"},{"line_number":4584,"context_line":"            return bool(step % 2)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2FdWs%3D","line":4581,"in_reply_to":"AAAAPH%2F%2FdY8%3D","updated":"2013-06-03 15:02:11.000000000","message":"Done","commit_id":"5245867d1acdfe413361d5d832f9b6d359d6dc0f"}]}