)]}'
{"nova/tests/unit/test_pipelib.py":[{"author":{"_account_id":17898,"name":"Jinquan Ni","email":"ni.jinquan@zte.com.cn","username":"jinquanni"},"change_message_id":"300bfda533f6b680edd6f972bf635f301dd5b97b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def test_launch_vpn_instance(self):"},{"line_number":45,"context_line":"        @mock.patch.object(self.cloudpipe.compute_api, \u0027create\u0027,"},{"line_number":46,"context_line":"                           return_value\u003dlambda *a, **kw: (None, \"r-fakeres\"))"},{"line_number":47,"context_line":"        def _do_test(mock_create):"},{"line_number":48,"context_line":"            with utils.tempdir() as tmpdir:"},{"line_number":49,"context_line":"                self.flags(ca_path\u003dtmpdir, keys_path\u003dtmpdir, group\u003d\u0027crypto\u0027)"},{"line_number":50,"context_line":"                crypto.ensure_ca_filesystem()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_6209d631","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":20},"updated":"2016-05-06 07:56:23.000000000","message":"We don\u0027t need add this new method. The @mock.patch.object can use on \u0027test_launch_vpn_instance\u0027 directly.","commit_id":"2580a6db050763903120c658a8acb836d2cd3770"},{"author":{"_account_id":17898,"name":"Jinquan Ni","email":"ni.jinquan@zte.com.cn","username":"jinquanni"},"change_message_id":"c63c4f08e451c327666fa49ff867976dc123c92d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def test_launch_vpn_instance(self):"},{"line_number":45,"context_line":"        @mock.patch.object(self.cloudpipe.compute_api, \u0027create\u0027,"},{"line_number":46,"context_line":"                           return_value\u003dlambda *a, **kw: (None, \"r-fakeres\"))"},{"line_number":47,"context_line":"        def _do_test(mock_create):"},{"line_number":48,"context_line":"            with utils.tempdir() as tmpdir:"},{"line_number":49,"context_line":"                self.flags(ca_path\u003dtmpdir, keys_path\u003dtmpdir, group\u003d\u0027crypto\u0027)"},{"line_number":50,"context_line":"                crypto.ensure_ca_filesystem()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_0560d434","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":20},"in_reply_to":"dab17558_05d3b439","updated":"2016-05-06 08:24:28.000000000","message":"get it, my mistake,sorry.","commit_id":"2580a6db050763903120c658a8acb836d2cd3770"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"b46b5eaff738c1198e2f3f8660ac513a658b77a1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def test_launch_vpn_instance(self):"},{"line_number":45,"context_line":"        @mock.patch.object(self.cloudpipe.compute_api, \u0027create\u0027,"},{"line_number":46,"context_line":"                           return_value\u003dlambda *a, **kw: (None, \"r-fakeres\"))"},{"line_number":47,"context_line":"        def _do_test(mock_create):"},{"line_number":48,"context_line":"            with utils.tempdir() as tmpdir:"},{"line_number":49,"context_line":"                self.flags(ca_path\u003dtmpdir, keys_path\u003dtmpdir, group\u003d\u0027crypto\u0027)"},{"line_number":50,"context_line":"                crypto.ensure_ca_filesystem()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_05d3b439","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":20},"in_reply_to":"dab17558_6209d631","updated":"2016-05-06 08:11:43.000000000","message":"self.cloudpipe.compute_api can be the following classes.\n\n* nova.compute.cells_api.ComputeCellsAPI\n* nova.compute.api.API\n\nSo I used \u0027@mock.patch.object\u0027 inside of test_launch_vpn_instance method.","commit_id":"2580a6db050763903120c658a8acb836d2cd3770"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8aa2a94e076028bf83da439de78cd3833a59aafb","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            self.assertTrue(ret)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_launch_vpn_instance(self):"},{"line_number":45,"context_line":"        @mock.patch.object(self.cloudpipe.compute_api, \u0027create\u0027,"},{"line_number":46,"context_line":"                           return_value\u003dlambda *a, **kw: (None, \"r-fakeres\"))"},{"line_number":47,"context_line":"        def _do_test(mock_create):"},{"line_number":48,"context_line":"            with utils.tempdir() as tmpdir:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_d35790c8","line":45,"updated":"2016-05-24 16:18:31.000000000","message":"You can move the decorator to the test_launch_vpn_instance and then drop the extra nesting created by _do_test","commit_id":"32ca314cc07a89e7962fb42379b9ddbe7cb4487e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"561f2769909e997f4bfad442311f5564fa8a4e73","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            self.assertTrue(ret)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_launch_vpn_instance(self):"},{"line_number":45,"context_line":"        @mock.patch.object(self.cloudpipe.compute_api, \u0027create\u0027,"},{"line_number":46,"context_line":"                           return_value\u003dlambda *a, **kw: (None, \"r-fakeres\"))"},{"line_number":47,"context_line":"        def _do_test(mock_create):"},{"line_number":48,"context_line":"            with utils.tempdir() as tmpdir:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_6c2a1b80","line":45,"in_reply_to":"9abb7d3a_6ab05f44","updated":"2016-05-30 15:51:34.000000000","message":"I see.","commit_id":"32ca314cc07a89e7962fb42379b9ddbe7cb4487e"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"098d0e014bd630dc302d81c9f233abc154635e14","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            self.assertTrue(ret)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_launch_vpn_instance(self):"},{"line_number":45,"context_line":"        @mock.patch.object(self.cloudpipe.compute_api, \u0027create\u0027,"},{"line_number":46,"context_line":"                           return_value\u003dlambda *a, **kw: (None, \"r-fakeres\"))"},{"line_number":47,"context_line":"        def _do_test(mock_create):"},{"line_number":48,"context_line":"            with utils.tempdir() as tmpdir:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_6ab05f44","line":45,"in_reply_to":"bab6814e_d35790c8","updated":"2016-05-30 00:38:15.000000000","message":"@Gibi,\n\nPlease check my comment in PS2.","commit_id":"32ca314cc07a89e7962fb42379b9ddbe7cb4487e"}]}