)]}'
{"nova/api/metadata/vendordata_json.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a13809cfd0a8173dd671dd38dd0b83278aa1c992","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        super(JsonFileVendorData, self).__init__(*args, **kwargs)"},{"line_number":34,"context_line":"        data \u003d {}"},{"line_number":35,"context_line":"        fpath \u003d CONF.vendordata_jsonfile_path"},{"line_number":36,"context_line":"        logprefix \u003d \"vendordata_jsonfile_path[%s]:\" % fpath"},{"line_number":37,"context_line":"        if fpath:"},{"line_number":38,"context_line":"            try:"},{"line_number":39,"context_line":"                with open(fpath, \"r\") as fp:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_a0408a08","line":36,"range":{"start_line":36,"start_character":20,"end_line":36,"end_character":45},"updated":"2016-05-04 16:05:14.000000000","message":"yeah, that\u0027s OK to do IMO","commit_id":"24b25e0cce3916037db084c48c3a3fbae918a4ea"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"daeabcd25cee6e464796c1f4b55c457722ab20ec","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        super(JsonFileVendorData, self).__init__(*args, **kwargs)"},{"line_number":34,"context_line":"        data \u003d {}"},{"line_number":35,"context_line":"        fpath \u003d CONF.vendordata_jsonfile_path"},{"line_number":36,"context_line":"        logprefix \u003d \"vendordata_jsonfile_path[%s]:\" % fpath"},{"line_number":37,"context_line":"        if fpath:"},{"line_number":38,"context_line":"            try:"},{"line_number":39,"context_line":"                with open(fpath, \"r\") as fp:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_8e74e1fd","line":36,"range":{"start_line":36,"start_character":20,"end_line":36,"end_character":45},"in_reply_to":"1a122d0e_a0408a08","updated":"2016-05-06 09:49:38.000000000","message":"+1","commit_id":"24b25e0cce3916037db084c48c3a3fbae918a4ea"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"5d628feecb549a906f4878bbebb80abd77bc4755","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        super(JsonFileVendorData, self).__init__(*args, **kwargs)"},{"line_number":34,"context_line":"        data \u003d {}"},{"line_number":35,"context_line":"        fpath \u003d CONF.vendordata_jsonfile_path"},{"line_number":36,"context_line":"        logprefix \u003d \"vendordata_jsonfile_path[%s]:\" % fpath"},{"line_number":37,"context_line":"        if fpath:"},{"line_number":38,"context_line":"            try:"},{"line_number":39,"context_line":"                with open(fpath, \"r\") as fp:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_86348afb","line":36,"range":{"start_line":36,"start_character":21,"end_line":36,"end_character":45},"updated":"2016-05-09 08:56:55.000000000","message":"I\u0027m still fine with this approach.","commit_id":"cc312c87784e2489b130665844c66f176752e8fe"}],"nova/conf/api.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d660f9febdfac7a268da7f4f52fce3c1ad932203","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            [])"},{"line_number":66,"context_line":"# Please note that final empty list in the line above is just to allow adding"},{"line_number":67,"context_line":"# additional options in later patches without changing the last line. Once they"},{"line_number":68,"context_line":"# are all moved, the empty list will be removed."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_e1975ae9","line":68,"updated":"2016-04-22 15:51:56.000000000","message":"Funky, not a bad idea.","commit_id":"ad90d0c410f1f35375e5b5bdf1c0e373831c1294"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d660f9febdfac7a268da7f4f52fce3c1ad932203","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def register_opts(conf):"},{"line_number":72,"context_line":"    conf.register_opts(auth_opts)"},{"line_number":73,"context_line":"    conf.register_opts(metadata_opts)"},{"line_number":74,"context_line":"    conf.register_opt(file_opt)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_a1e0c297","line":72,"updated":"2016-04-22 15:51:56.000000000","message":"Nit, most other places do conf.register_opts(ALL_OPTS) or ALL_DEFAULT_OPS, if we have any sub groups.","commit_id":"ad90d0c410f1f35375e5b5bdf1c0e373831c1294"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a13809cfd0a8173dd671dd38dd0b83278aa1c992","unresolved":false,"context_lines":[{"line_number":62,"context_line":"ALL_OPTS \u003d (auth_opts +"},{"line_number":63,"context_line":"            metadata_opts +"},{"line_number":64,"context_line":"            [file_opt] +"},{"line_number":65,"context_line":"            [])"},{"line_number":66,"context_line":"# Please note that final empty list in the line above is just to allow adding"},{"line_number":67,"context_line":"# additional options in later patches without changing the last line. Once they"},{"line_number":68,"context_line":"# are all moved, the empty list will be removed."}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_60d2f235","line":65,"range":{"start_line":65,"start_character":12,"end_line":65,"end_character":14},"updated":"2016-05-04 16:05:14.000000000","message":"that\u0027s a nice thing","commit_id":"24b25e0cce3916037db084c48c3a3fbae918a4ea"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"156e1eb329f0cd79913c15ba813a44c292468555","unresolved":false,"context_lines":[{"line_number":71,"context_line":"def register_opts(conf):"},{"line_number":72,"context_line":"    conf.register_opts(auth_opts)"},{"line_number":73,"context_line":"    conf.register_opts(metadata_opts)"},{"line_number":74,"context_line":"    conf.register_opt(file_opt)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_f1b0b2df","line":74,"updated":"2016-05-09 09:20:35.000000000","message":"I still think this should be conf.register_opts(ALL_OPTS) to match the other places, but I don\u0027t want the whole chain to get reset again.","commit_id":"cc312c87784e2489b130665844c66f176752e8fe"}],"nova/conf/neutron.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d660f9febdfac7a268da7f4f52fce3c1ad932203","unresolved":false,"context_lines":[{"line_number":50,"context_line":"def register_opts(conf):"},{"line_number":51,"context_line":"    conf.register_group(neutron_group)"},{"line_number":52,"context_line":"    conf.register_opts(neutron_opts, group\u003dneutron_group)"},{"line_number":53,"context_line":"    conf.register_opts(metadata_proxy_opts, group\u003dneutron_group)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"ALL_OPTS \u003d (neutron_opts + metadata_proxy_opts)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_843af4cb","line":53,"updated":"2016-04-22 15:51:56.000000000","message":"Nit: most other places do: conf.register_opts(ALL_OPTS, group\u003dneutron_group)","commit_id":"ad90d0c410f1f35375e5b5bdf1c0e373831c1294"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"5d628feecb549a906f4878bbebb80abd77bc4755","unresolved":false,"context_lines":[{"line_number":45,"context_line":"         help\u003d\u0027Shared secret to validate proxies Neutron metadata requests\u0027),"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"ALL_OPTS \u003d (neutron_opts + metadata_proxy_opts)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_c647b275","line":48,"range":{"start_line":48,"start_character":24,"end_line":48,"end_character":27},"updated":"2016-05-09 08:56:55.000000000","message":"yeah, it\u0027s better than the \"list(itertools.chain())\"","commit_id":"cc312c87784e2489b130665844c66f176752e8fe"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"156e1eb329f0cd79913c15ba813a44c292468555","unresolved":false,"context_lines":[{"line_number":45,"context_line":"         help\u003d\u0027Shared secret to validate proxies Neutron metadata requests\u0027),"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"ALL_OPTS \u003d (neutron_opts + metadata_proxy_opts)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_918b261e","line":48,"range":{"start_line":48,"start_character":24,"end_line":48,"end_character":27},"in_reply_to":"dab17558_c647b275","updated":"2016-05-09 09:20:35.000000000","message":"+1 this is what I am hoping we move them all to.\n\nNot sure I buy why it needs to be done in this particular patch, but lets not get bogged down on that.","commit_id":"cc312c87784e2489b130665844c66f176752e8fe"}]}