)]}'
{"nova/api/openstack/__init__.py":[{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"4726fd75523fc8d0164d8f9968ad7fcf0f36fb28","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from nova.api.openstack import extensions"},{"line_number":29,"context_line":"from nova.api.openstack import wsgi"},{"line_number":30,"context_line":"import nova.conf"},{"line_number":31,"context_line":"from nova import exception"},{"line_number":32,"context_line":"from nova.i18n import _"},{"line_number":33,"context_line":"from nova.i18n import _LC"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_97ea29ab","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":16},"updated":"2016-05-03 14:26:33.000000000","message":"You should import as it was done the line after","commit_id":"dd92c21b42ef1e010d3bf93f9b187fb232c3efda"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5d6912e895ecab66ba377aa8a412ad45a483410d","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from nova.api.openstack import extensions"},{"line_number":29,"context_line":"from nova.api.openstack import wsgi"},{"line_number":30,"context_line":"import nova.conf"},{"line_number":31,"context_line":"from nova import exception"},{"line_number":32,"context_line":"from nova.i18n import _"},{"line_number":33,"context_line":"from nova.i18n import _LC"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_2e3b35ed","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":16},"in_reply_to":"1a122d0e_46142e9e","updated":"2016-05-06 09:53:34.000000000","message":"+1 markus and ed","commit_id":"dd92c21b42ef1e010d3bf93f9b187fb232c3efda"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"0166237914b81f3c1f3cd3274a6ae801e7b0fc8a","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from nova.api.openstack import extensions"},{"line_number":29,"context_line":"from nova.api.openstack import wsgi"},{"line_number":30,"context_line":"import nova.conf"},{"line_number":31,"context_line":"from nova import exception"},{"line_number":32,"context_line":"from nova.i18n import _"},{"line_number":33,"context_line":"from nova.i18n import _LC"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_efbd8168","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":16},"in_reply_to":"1a122d0e_97ea29ab","updated":"2016-05-03 16:19:07.000000000","message":"Do you mean you want to see \"from nova import conf\"? This is considered too vague, as later lines will simply have \u0027conf\u0027, which could be anything. That\u0027s why this format has been adopted as standard among all the patches in the \u0027centralize-config-options-newton\u0027 series.","commit_id":"dd92c21b42ef1e010d3bf93f9b187fb232c3efda"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"230493c5fe099d8a8c19fa3e54ec931bfa98eb94","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from nova.api.openstack import extensions"},{"line_number":29,"context_line":"from nova.api.openstack import wsgi"},{"line_number":30,"context_line":"import nova.conf"},{"line_number":31,"context_line":"from nova import exception"},{"line_number":32,"context_line":"from nova.i18n import _"},{"line_number":33,"context_line":"from nova.i18n import _LC"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_46142e9e","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":16},"in_reply_to":"1a122d0e_efbd8168","updated":"2016-05-04 16:46:10.000000000","message":"@Gábor: The \"import nova.conf\" way is the way we\u0027ve done it in all the other changes for this bp, no need to change that in the middle of the implementation.","commit_id":"dd92c21b42ef1e010d3bf93f9b187fb232c3efda"}],"nova/conf/osapi_v21.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"036b6d03255c16c2d4df1621821a31eaf4554abd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"api_opts \u003d ["},{"line_number":20,"context_line":"        cfg.ListOpt(\u0027extensions_blacklist\u0027,"},{"line_number":21,"context_line":"                    default\u003d[],"},{"line_number":22,"context_line":"                    help\u003d\u0027DEPRECATED: A list of v2.1 API extensions to never \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_111c5612","line":19,"updated":"2016-05-09 09:15:40.000000000","message":"We could also just remove them as they got deprecated in Liberty with commit 11507ee but I\u0027m also fine with a follow up patch for this. I have no strong feelings here.","commit_id":"0bfbc4c26216ddaec36029125cd9d84827bb144f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e9afc3c69f43c8011a7fff61195d7c342786caa4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"api_opts \u003d ["},{"line_number":20,"context_line":"        cfg.ListOpt(\u0027extensions_blacklist\u0027,"},{"line_number":21,"context_line":"                    default\u003d[],"},{"line_number":22,"context_line":"                    help\u003d\u0027DEPRECATED: A list of v2.1 API extensions to never \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_b1dd8a16","line":19,"in_reply_to":"dab17558_111c5612","updated":"2016-05-09 09:21:19.000000000","message":"it should be a follow up patch.","commit_id":"0bfbc4c26216ddaec36029125cd9d84827bb144f"}],"nova/tests/functional/api_sample_tests/api_sample_base.py":[{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"4726fd75523fc8d0164d8f9968ad7fcf0f36fb28","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import testscenarios"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from nova.api.openstack import API_V21_CORE_EXTENSIONS  # noqa"},{"line_number":20,"context_line":"import nova.conf"},{"line_number":21,"context_line":"from nova import test"},{"line_number":22,"context_line":"from nova.tests.functional import api_paste_fixture"},{"line_number":23,"context_line":"from nova.tests.functional import api_samples_test_base"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_376b5587","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":16},"updated":"2016-05-03 14:26:33.000000000","message":"I think you should use import as it was used after this line.","commit_id":"dd92c21b42ef1e010d3bf93f9b187fb232c3efda"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5d6912e895ecab66ba377aa8a412ad45a483410d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import testscenarios"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from nova.api.openstack import API_V21_CORE_EXTENSIONS  # noqa"},{"line_number":20,"context_line":"import nova.conf"},{"line_number":21,"context_line":"from nova import test"},{"line_number":22,"context_line":"from nova.tests.functional import api_paste_fixture"},{"line_number":23,"context_line":"from nova.tests.functional import api_samples_test_base"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_f94c5978","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":16},"in_reply_to":"1a122d0e_376b5587","updated":"2016-05-06 09:53:34.000000000","message":"as previous comments","commit_id":"dd92c21b42ef1e010d3bf93f9b187fb232c3efda"}]}