)]}'
{"nova/conf/api.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"68507268e9b214fdde28ff9c852acaa6b8f7c2bf","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        default\u003dTrue,"},{"line_number":77,"context_line":"        help\u003d\u0027Permit instance snapshot operations.\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# I should import the value directly from nova.compute.vm_states, but that"},{"line_number":80,"context_line":"# creates a circular import. Since this value is not likely to be changed, I\u0027m"},{"line_number":81,"context_line":"# copy/pasting it here."},{"line_number":82,"context_line":"BUILDING \u003d \"building\"  # VM only exists in DB"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_d93b559b","line":79,"updated":"2016-05-06 09:58:26.000000000","message":"Nit: this should start with a NOTE (edleaf) I think?\n\nI am cool with this though, for the reason you state here. We could make vm_states use this constant, but that feels like overkill?","commit_id":"fb3e2a599b5901da7c1cd6b6f7a1d9671bd762cb"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"58d22376fe1b0b47716798450a9703610aa62890","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        default\u003dTrue,"},{"line_number":77,"context_line":"        help\u003d\u0027Permit instance snapshot operations.\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# I should import the value directly from nova.compute.vm_states, but that"},{"line_number":80,"context_line":"# creates a circular import. Since this value is not likely to be changed, I\u0027m"},{"line_number":81,"context_line":"# copy/pasting it here."},{"line_number":82,"context_line":"BUILDING \u003d \"building\"  # VM only exists in DB"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_659b5373","line":79,"in_reply_to":"dab17558_d93b559b","updated":"2016-05-09 13:28:10.000000000","message":"Added the NOTE.\n\nI tried every permutation I could find to resolve the circular dependency, but they always got imported out of order. This was the best compromise.","commit_id":"fb3e2a599b5901da7c1cd6b6f7a1d9671bd762cb"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a3090b4b111f2c55466ad4082db3febc563025cf","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        help\u003d\u0027Permit instance snapshot operations.\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# I should import the value directly from nova.compute.vm_states, but that"},{"line_number":80,"context_line":"# creates a circular import. Since this value is not likely to be changed, I\u0027m"},{"line_number":81,"context_line":"# copy/pasting it here."},{"line_number":82,"context_line":"BUILDING \u003d \"building\"  # VM only exists in DB"},{"line_number":83,"context_line":"osapi_hide_opt \u003d cfg.ListOpt(\u0027osapi_hide_server_address_states\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_2c3bfdd2","line":80,"range":{"start_line":80,"start_character":2,"end_line":80,"end_character":27},"updated":"2016-05-09 09:43:36.000000000","message":"What creates the circular dependency? Module [1] which contains all the constants doesn\u0027t import anything else. I assume my Python knowledge has a deficiency here. \n\n[1] https://github.com/openstack/nova/blob/master/nova/compute/vm_states.py","commit_id":"77c2c71a1c36e31838c138ac8d431d0a510eabaf"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"ec53e4d935ca28a18d2f18af18a78497409bd434","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        help\u003d\u0027Permit instance snapshot operations.\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# I should import the value directly from nova.compute.vm_states, but that"},{"line_number":80,"context_line":"# creates a circular import. Since this value is not likely to be changed, I\u0027m"},{"line_number":81,"context_line":"# copy/pasting it here."},{"line_number":82,"context_line":"BUILDING \u003d \"building\"  # VM only exists in DB"},{"line_number":83,"context_line":"osapi_hide_opt \u003d cfg.ListOpt(\u0027osapi_hide_server_address_states\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_0536c751","line":80,"range":{"start_line":80,"start_character":2,"end_line":80,"end_character":27},"in_reply_to":"dab17558_2c3bfdd2","updated":"2016-05-09 13:35:41.000000000","message":"I have to import that module to access those constants. That file is OK, but the module itself triggers import references that cause the circular import.","commit_id":"77c2c71a1c36e31838c138ac8d431d0a510eabaf"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a3090b4b111f2c55466ad4082db3febc563025cf","unresolved":false,"context_lines":[{"line_number":80,"context_line":"# creates a circular import. Since this value is not likely to be changed, I\u0027m"},{"line_number":81,"context_line":"# copy/pasting it here."},{"line_number":82,"context_line":"BUILDING \u003d \"building\"  # VM only exists in DB"},{"line_number":83,"context_line":"osapi_hide_opt \u003d cfg.ListOpt(\u0027osapi_hide_server_address_states\u0027,"},{"line_number":84,"context_line":"                default\u003d[BUILDING],"},{"line_number":85,"context_line":"                help\u003d\u0027List of instance states that should hide network info\u0027)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_8cbdc9d9","line":83,"range":{"start_line":83,"start_character":30,"end_line":83,"end_character":62},"updated":"2016-05-09 09:43:36.000000000","message":"This got introduced with commit b3bbd09 3.5 years ago to fix bug 1089092. I assume this isn\u0027t something we need to expose to the ops and that a deprecation could be reasonable.","commit_id":"77c2c71a1c36e31838c138ac8d431d0a510eabaf"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"ec53e4d935ca28a18d2f18af18a78497409bd434","unresolved":false,"context_lines":[{"line_number":80,"context_line":"# creates a circular import. Since this value is not likely to be changed, I\u0027m"},{"line_number":81,"context_line":"# copy/pasting it here."},{"line_number":82,"context_line":"BUILDING \u003d \"building\"  # VM only exists in DB"},{"line_number":83,"context_line":"osapi_hide_opt \u003d cfg.ListOpt(\u0027osapi_hide_server_address_states\u0027,"},{"line_number":84,"context_line":"                default\u003d[BUILDING],"},{"line_number":85,"context_line":"                help\u003d\u0027List of instance states that should hide network info\u0027)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_a5153b9c","line":83,"range":{"start_line":83,"start_character":30,"end_line":83,"end_character":62},"in_reply_to":"dab17558_8cbdc9d9","updated":"2016-05-09 13:35:41.000000000","message":"Sure, but this is simply a move of the options. Any deprecation or other changes should be in a follow-up patch.","commit_id":"77c2c71a1c36e31838c138ac8d431d0a510eabaf"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"7cedad95f5b8761c254edbb35707590d618c9a8f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"# creates a circular import. Since this value is not likely to be changed, I\u0027m"},{"line_number":81,"context_line":"# copy/pasting it here."},{"line_number":82,"context_line":"BUILDING \u003d \"building\"  # VM only exists in DB"},{"line_number":83,"context_line":"osapi_hide_opt \u003d cfg.ListOpt(\u0027osapi_hide_server_address_states\u0027,"},{"line_number":84,"context_line":"                default\u003d[BUILDING],"},{"line_number":85,"context_line":"                help\u003d\u0027List of instance states that should hide network info\u0027)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_eef9da81","line":83,"range":{"start_line":83,"start_character":30,"end_line":83,"end_character":62},"in_reply_to":"dab17558_a5153b9c","updated":"2016-05-09 16:18:17.000000000","message":"For sure! After reading my comment again I see that it could be read that I want to have the deprecation in this change, but that\u0027s not the case. Definitely a follow-up patch.","commit_id":"77c2c71a1c36e31838c138ac8d431d0a510eabaf"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a3090b4b111f2c55466ad4082db3febc563025cf","unresolved":false,"context_lines":[{"line_number":81,"context_line":"# copy/pasting it here."},{"line_number":82,"context_line":"BUILDING \u003d \"building\"  # VM only exists in DB"},{"line_number":83,"context_line":"osapi_hide_opt \u003d cfg.ListOpt(\u0027osapi_hide_server_address_states\u0027,"},{"line_number":84,"context_line":"                default\u003d[BUILDING],"},{"line_number":85,"context_line":"                help\u003d\u0027List of instance states that should hide network info\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"fping_path_opt \u003d cfg.StrOpt(\"fping_path\","},{"line_number":88,"context_line":"               default\u003d\"/usr/sbin/fping\","}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_b1c74a11","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":77},"updated":"2016-05-09 09:43:36.000000000","message":"The formatting is a little off here, but as you make that right in review [1] I don\u0027t see a reason to block this here. Same below in line 88-89.\n\n[1] https://review.openstack.org/#/c/309197/5/nova/conf/api.py","commit_id":"77c2c71a1c36e31838c138ac8d431d0a510eabaf"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"ec53e4d935ca28a18d2f18af18a78497409bd434","unresolved":false,"context_lines":[{"line_number":81,"context_line":"# copy/pasting it here."},{"line_number":82,"context_line":"BUILDING \u003d \"building\"  # VM only exists in DB"},{"line_number":83,"context_line":"osapi_hide_opt \u003d cfg.ListOpt(\u0027osapi_hide_server_address_states\u0027,"},{"line_number":84,"context_line":"                default\u003d[BUILDING],"},{"line_number":85,"context_line":"                help\u003d\u0027List of instance states that should hide network info\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"fping_path_opt \u003d cfg.StrOpt(\"fping_path\","},{"line_number":88,"context_line":"               default\u003d\"/usr/sbin/fping\","}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_a5341bfb","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":77},"in_reply_to":"dab17558_b1c74a11","updated":"2016-05-09 13:35:41.000000000","message":"Yeah, my bad. Since I\u0027m respinning anyway, I fixed it.","commit_id":"77c2c71a1c36e31838c138ac8d431d0a510eabaf"}]}