)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"10a5e573d8a2afb7e40f0afa9de50be7485e2210","unresolved":false,"context_lines":[{"line_number":384,"context_line":"               help\u003d\u0027Directory where the SMBFS shares are mounted on the \u0027"},{"line_number":385,"context_line":"                    \u0027compute node\u0027),"},{"line_number":386,"context_line":"    cfg.StrOpt(\u0027smbfs_mount_options\u0027,"},{"line_number":387,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":388,"context_line":"               help\u003d\u0027Mount options passed to the SMBFS client. See \u0027"},{"line_number":389,"context_line":"                    \u0027mount.cifs man page for details. Note that the \u0027"},{"line_number":390,"context_line":"                    \u0027libvirt-qemu uid and gid must be specified.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_b481fa4f","line":387,"updated":"2016-05-04 12:04:11.000000000","message":"we should probably drop this, but thats a follow up thing.","commit_id":"b29e7b69264c89c222cf738169598e3e54af94ef"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"b32a77513eced157a0a4bc14fea52244dfdb4437","unresolved":false,"context_lines":[{"line_number":384,"context_line":"               help\u003d\u0027Directory where the SMBFS shares are mounted on the \u0027"},{"line_number":385,"context_line":"                    \u0027compute node\u0027),"},{"line_number":386,"context_line":"    cfg.StrOpt(\u0027smbfs_mount_options\u0027,"},{"line_number":387,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":388,"context_line":"               help\u003d\u0027Mount options passed to the SMBFS client. See \u0027"},{"line_number":389,"context_line":"                    \u0027mount.cifs man page for details. Note that the \u0027"},{"line_number":390,"context_line":"                    \u0027libvirt-qemu uid and gid must be specified.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_8b03fc75","line":387,"in_reply_to":"1a122d0e_b481fa4f","updated":"2016-05-04 12:51:12.000000000","message":"I guess the empty string was made as default value to make the string join operation without checking for None in:\n\n    def _parse_mount_options(self, connection_info):\n        mount_options \u003d \" \".join(\n            [connection_info[\u0027data\u0027].get(\u0027options\u0027) or \u0027\u0027,\n             CONF.libvirt.smbfs_mount_options])\n\nI agree that it would be better to have no default value here and do the None check in \"_parse_mount_options\". I added this to the etherpad [1] for follow up cleanups, no need to do this in this patch.\n\n[1] https://etherpad.openstack.org/p/config-options","commit_id":"b29e7b69264c89c222cf738169598e3e54af94ef"}]}