)]}'
{"nova/api/openstack/compute/contrib/disk_config.py":[{"author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"change_message_id":"3bf781562baa15e114facde9defb6dd35f2a3337","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    elif value \u003d\u003d \u0027MANUAL\u0027:"},{"line_number":41,"context_line":"        return False"},{"line_number":42,"context_line":"    else:"},{"line_number":43,"context_line":"        msg \u003d _(\"RAX-DCF:diskConfig must be either \u0027MANUAL\u0027 or \u0027AUTO\u0027.\")"},{"line_number":44,"context_line":"        raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F9PE%3D","line":43,"updated":"2012-01-17 19:45:06.000000000","message":"Should we toss RAX-DCF:diskConfig in here?","commit_id":"0454c7ccfa988f280dfaf61822ae9d11e6f70a80"},{"author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"change_message_id":"3bf781562baa15e114facde9defb6dd35f2a3337","unresolved":false,"context_lines":[{"line_number":86,"context_line":"class ServerDiskConfigTemplate(xmlutil.TemplateBuilder):"},{"line_number":87,"context_line":"    def construct(self):"},{"line_number":88,"context_line":"        root \u003d xmlutil.TemplateElement(\u0027server\u0027)"},{"line_number":89,"context_line":"        root.set(\u0027{%s}diskConfig\u0027 % XMLNS_DCF, \u0027%s:diskConfig\u0027 % ALIAS)"},{"line_number":90,"context_line":"        return xmlutil.SlaveTemplate(root, 1, nsmap\u003d{ALIAS: XMLNS_DCF})"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F9PA%3D","line":89,"updated":"2012-01-17 19:45:06.000000000","message":"Same as above.","commit_id":"0454c7ccfa988f280dfaf61822ae9d11e6f70a80"},{"author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"change_message_id":"3bf781562baa15e114facde9defb6dd35f2a3337","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def construct(self):"},{"line_number":95,"context_line":"        root \u003d xmlutil.TemplateElement(\u0027servers\u0027)"},{"line_number":96,"context_line":"        elem \u003d xmlutil.SubTemplateElement(root, \u0027server\u0027, selector\u003d\u0027servers\u0027)"},{"line_number":97,"context_line":"        elem.set(\u0027{%s}diskConfig\u0027 % XMLNS_DCF, \u0027%s:diskConfig\u0027 % ALIAS)"},{"line_number":98,"context_line":"        return xmlutil.SlaveTemplate(root, 1, nsmap\u003d{ALIAS: XMLNS_DCF})"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F9O8%3D","line":97,"updated":"2012-01-17 19:45:06.000000000","message":"Same as above.","commit_id":"0454c7ccfa988f280dfaf61822ae9d11e6f70a80"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"41aed85deab1f2411b83693b1f154f643efea269","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # Get DB information for servers"},{"line_number":108,"context_line":"        uuids \u003d [server[\u0027id\u0027] for server in servers]"},{"line_number":109,"context_line":"        db_servers \u003d db.instance_get_all_by_filters(context, {\u0027uuid\u0027: uuids})"},{"line_number":110,"context_line":"        db_servers_by_uuid \u003d dict((s[\u0027uuid\u0027], s) for s in db_servers)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        for server in servers:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F9WA%3D","line":109,"updated":"2012-01-17 16:15:23.000000000","message":"One point: there could be a race condition where a server appears in a list but then gets deleted; there was a patch to work around this issue that was applied to extended_status.py prior to my work.","commit_id":"0454c7ccfa988f280dfaf61822ae9d11e6f70a80"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3e27c0b5cb88dbd0d0167bde913382c97e4da03c","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # Get DB information for servers"},{"line_number":108,"context_line":"        uuids \u003d [server[\u0027id\u0027] for server in servers]"},{"line_number":109,"context_line":"        db_servers \u003d db.instance_get_all_by_filters(context, {\u0027uuid\u0027: uuids})"},{"line_number":110,"context_line":"        db_servers_by_uuid \u003d dict((s[\u0027uuid\u0027], s) for s in db_servers)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        for server in servers:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F9Pc%3D","line":109,"in_reply_to":"AAAAD3%2F%2F9Ps%3D","updated":"2012-01-17 19:38:09.000000000","message":"You mean, fix this up in another merge-prop?  That\u0027d be fine, I suppose...","commit_id":"0454c7ccfa988f280dfaf61822ae9d11e6f70a80"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"08abce15e0e99529234de11ffd1959cb5df4e68d","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # Get DB information for servers"},{"line_number":108,"context_line":"        uuids \u003d [server[\u0027id\u0027] for server in servers]"},{"line_number":109,"context_line":"        db_servers \u003d db.instance_get_all_by_filters(context, {\u0027uuid\u0027: uuids})"},{"line_number":110,"context_line":"        db_servers_by_uuid \u003d dict((s[\u0027uuid\u0027], s) for s in db_servers)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        for server in servers:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F9Ps%3D","line":109,"in_reply_to":"AAAAD3%2F%2F9WA%3D","updated":"2012-01-17 19:33:03.000000000","message":"Good point. Looks like this race condition existed in the original code; what do you think about making a separate bug for that?","commit_id":"0454c7ccfa988f280dfaf61822ae9d11e6f70a80"}]}