)]}'
{"nova/tests/db/test_db_api.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"df5779fe2a67829e170fa8ff705c57667d51d754","unresolved":false,"context_lines":[{"line_number":4629,"context_line":"                         sorted([db.s3_image_get(self.ctxt, ref.id).uuid"},{"line_number":4630,"context_line":"                         for ref in self.images]))"},{"line_number":4631,"context_line":""},{"line_number":4632,"context_line":"    def test_s3_image_get_not_found(self):"},{"line_number":4633,"context_line":"        self.assertRaises(exception.ImageNotFound, db.s3_image_get, self.ctxt,"},{"line_number":4634,"context_line":"                          100500)"},{"line_number":4635,"context_line":"        self.assertRaises(exception.ImageNotFound, db.s3_image_get_by_uuid,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2Fy5Q%3D","line":4632,"updated":"2013-06-10 14:36:11.000000000","message":"I would prefer to see 2 different methods methods: \n\ntest_s3_image_get_not_found and\ntest_s3_image_get_by_uuid_not found","commit_id":"f90ae9493e05522b13c466ea6fba3b0c27a95f9d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"cd1fbd698aa02f248a670d348108a58be7633c38","unresolved":false,"context_lines":[{"line_number":4629,"context_line":"                         sorted([db.s3_image_get(self.ctxt, ref.id).uuid"},{"line_number":4630,"context_line":"                         for ref in self.images]))"},{"line_number":4631,"context_line":""},{"line_number":4632,"context_line":"    def test_s3_image_get_not_found(self):"},{"line_number":4633,"context_line":"        self.assertRaises(exception.ImageNotFound, db.s3_image_get, self.ctxt,"},{"line_number":4634,"context_line":"                          100500)"},{"line_number":4635,"context_line":"        self.assertRaises(exception.ImageNotFound, db.s3_image_get_by_uuid,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2FyyI%3D","line":4632,"in_reply_to":"AAAAPX%2F%2Fy5Q%3D","updated":"2013-06-10 15:12:40.000000000","message":"Done","commit_id":"f90ae9493e05522b13c466ea6fba3b0c27a95f9d"}],"nova/tests/test_db_api.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"6c18a2bb6e811b230a38962d67eb8fb8b7093716","unresolved":false,"context_lines":[{"line_number":4483,"context_line":""},{"line_number":4484,"context_line":"    def setUp(self):"},{"line_number":4485,"context_line":"        super(S3ImageTestCase, self).setUp()"},{"line_number":4486,"context_line":"        self.ctxt \u003d context.get_admin_context()"},{"line_number":4487,"context_line":""},{"line_number":4488,"context_line":"    def _get_test_values(self):"},{"line_number":4489,"context_line":"        return [uuidutils.generate_uuid() for i in xrange(3)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FjaA%3D","line":4486,"updated":"2013-05-30 17:21:36.000000000","message":"Call self._get_test_values() and self._sr_images_create() in setUp() instead of doing this in each test","commit_id":"757fc09ace6e1a1e2b5378cda225467500140c72"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"bf51266b842a0ed73fe08e4624bf337a704bf269","unresolved":false,"context_lines":[{"line_number":4483,"context_line":""},{"line_number":4484,"context_line":"    def setUp(self):"},{"line_number":4485,"context_line":"        super(S3ImageTestCase, self).setUp()"},{"line_number":4486,"context_line":"        self.ctxt \u003d context.get_admin_context()"},{"line_number":4487,"context_line":""},{"line_number":4488,"context_line":"    def _get_test_values(self):"},{"line_number":4489,"context_line":"        return [uuidutils.generate_uuid() for i in xrange(3)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fhmg%3D","line":4486,"in_reply_to":"AAAAPH%2F%2FjaA%3D","updated":"2013-05-31 09:16:10.000000000","message":"and i removed this methods","commit_id":"757fc09ace6e1a1e2b5378cda225467500140c72"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"d7888fe419a5296fa01e33f0032063a2b620c6db","unresolved":false,"context_lines":[{"line_number":4559,"context_line":"        super(S3ImageTestCase, self).setUp()"},{"line_number":4560,"context_line":"        self.ctxt \u003d context.get_admin_context()"},{"line_number":4561,"context_line":"        self.values \u003d [uuidutils.generate_uuid() for i in xrange(3)]"},{"line_number":4562,"context_line":"        self.images \u003d [db.s3_image_create(self.ctxt, uuid)"},{"line_number":4563,"context_line":"                                          for uuid in self.values]"},{"line_number":4564,"context_line":""},{"line_number":4565,"context_line":"    def test_s3_image_create(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fhdw%3D","line":4562,"updated":"2013-05-31 10:37:18.000000000","message":"I think that it makes a sense to to call function s3_image_create in `test_s3_image_create()`, not in `setUp()`.","commit_id":"fa59aa2a2f358f2fb812d1b1e9ae3a4a836d223c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"f81ae4110d321bc36297d09d1d0bdb0d56f0e5ca","unresolved":false,"context_lines":[{"line_number":4559,"context_line":"        super(S3ImageTestCase, self).setUp()"},{"line_number":4560,"context_line":"        self.ctxt \u003d context.get_admin_context()"},{"line_number":4561,"context_line":"        self.values \u003d [uuidutils.generate_uuid() for i in xrange(3)]"},{"line_number":4562,"context_line":"        self.images \u003d [db.s3_image_create(self.ctxt, uuid)"},{"line_number":4563,"context_line":"                                          for uuid in self.values]"},{"line_number":4564,"context_line":""},{"line_number":4565,"context_line":"    def test_s3_image_create(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FhTI%3D","line":4562,"in_reply_to":"AAAAPH%2F%2Fhdw%3D","updated":"2013-05-31 11:45:47.000000000","message":"s3_image_create() must calling before all tests","commit_id":"fa59aa2a2f358f2fb812d1b1e9ae3a4a836d223c"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"5fa5e0dc6913e51445bf88c3f7cf4d0079a5d15b","unresolved":false,"context_lines":[{"line_number":4580,"context_line":"                         for ref in self.images]))"},{"line_number":4581,"context_line":""},{"line_number":4582,"context_line":"    def test_s3_image_get_not_found(self):"},{"line_number":4583,"context_line":"        self.assertRaises(exception.ImageNotFound, db.s3_image_get, self.ctxt,"},{"line_number":4584,"context_line":"                          100500)"},{"line_number":4585,"context_line":""},{"line_number":4586,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2F2E8%3D","line":4583,"updated":"2013-06-07 18:09:39.000000000","message":"This test should also check that s3_image_get_by_uuid raises ImageNotFound in the same way.","commit_id":"dc7764b23dcf2c87d92c2f4adb6cc8d803b672a3"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"afcefa90c2b8c6439e27807135be623be4f7df27","unresolved":false,"context_lines":[{"line_number":4580,"context_line":"                         for ref in self.images]))"},{"line_number":4581,"context_line":""},{"line_number":4582,"context_line":"    def test_s3_image_get_not_found(self):"},{"line_number":4583,"context_line":"        self.assertRaises(exception.ImageNotFound, db.s3_image_get, self.ctxt,"},{"line_number":4584,"context_line":"                          100500)"},{"line_number":4585,"context_line":""},{"line_number":4586,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2Fzo0%3D","line":4583,"in_reply_to":"AAAAPX%2F%2F2E8%3D","updated":"2013-06-10 07:24:06.000000000","message":"Done","commit_id":"dc7764b23dcf2c87d92c2f4adb6cc8d803b672a3"}]}