)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"1212eb9680b4655f0cba20ec6bfee9e75a353a62","unresolved":false,"context_lines":[{"line_number":4407,"context_line":"                    guest.os_loader_type \u003d \"pflash\""},{"line_number":4408,"context_line":"                    if CONF.libvirt.override_master_nvram is not None:"},{"line_number":4409,"context_line":"                        guest.os_nvram \u003d CONF.libvirt.override_master_nvram.\\"},{"line_number":4410,"context_line":"                                         get(guest.os_loader)"},{"line_number":4411,"context_line":"                else:"},{"line_number":4412,"context_line":"                    raise exception.UEFINotSupported()"},{"line_number":4413,"context_line":"            guest.os_mach_type \u003d self._get_machine_type(image_meta, caps)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_a184190b","line":4410,"range":{"start_line":4410,"start_character":60,"end_line":4410,"end_character":61},"updated":"2016-05-04 13:23:16.000000000","message":"I don\u0027t think there\u0027s any compelling reason to add this config parameter. We merely need the fix to config.py","commit_id":"bc6cf6950f7141379eb15de4bb6447281b09605a"},{"author":{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"},"change_message_id":"a5c49ef7aa680fc25823bfd5c8b69764f1103a00","unresolved":false,"context_lines":[{"line_number":4407,"context_line":"                    guest.os_loader_type \u003d \"pflash\""},{"line_number":4408,"context_line":"                    if CONF.libvirt.override_master_nvram is not None:"},{"line_number":4409,"context_line":"                        guest.os_nvram \u003d CONF.libvirt.override_master_nvram.\\"},{"line_number":4410,"context_line":"                                         get(guest.os_loader)"},{"line_number":4411,"context_line":"                else:"},{"line_number":4412,"context_line":"                    raise exception.UEFINotSupported()"},{"line_number":4413,"context_line":"            guest.os_mach_type \u003d self._get_machine_type(image_meta, caps)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_db02be3d","line":4410,"range":{"start_line":4410,"start_character":60,"end_line":4410,"end_character":61},"in_reply_to":"1a122d0e_3a282285","updated":"2016-05-05 02:35:11.000000000","message":"Done","commit_id":"bc6cf6950f7141379eb15de4bb6447281b09605a"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f5fb56dd39070c93891da10c03a527db1e50d044","unresolved":false,"context_lines":[{"line_number":4407,"context_line":"                    guest.os_loader_type \u003d \"pflash\""},{"line_number":4408,"context_line":"                    if CONF.libvirt.override_master_nvram is not None:"},{"line_number":4409,"context_line":"                        guest.os_nvram \u003d CONF.libvirt.override_master_nvram.\\"},{"line_number":4410,"context_line":"                                         get(guest.os_loader)"},{"line_number":4411,"context_line":"                else:"},{"line_number":4412,"context_line":"                    raise exception.UEFINotSupported()"},{"line_number":4413,"context_line":"            guest.os_mach_type \u003d self._get_machine_type(image_meta, caps)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_3adf820d","line":4410,"range":{"start_line":4410,"start_character":60,"end_line":4410,"end_character":61},"in_reply_to":"1a122d0e_3a282285","updated":"2016-05-04 16:40:10.000000000","message":"There\u0027s no reason for nova to be overriding the default location picked by libvirt","commit_id":"bc6cf6950f7141379eb15de4bb6447281b09605a"},{"author":{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"},"change_message_id":"a5c49ef7aa680fc25823bfd5c8b69764f1103a00","unresolved":false,"context_lines":[{"line_number":4407,"context_line":"                    guest.os_loader_type \u003d \"pflash\""},{"line_number":4408,"context_line":"                    if CONF.libvirt.override_master_nvram is not None:"},{"line_number":4409,"context_line":"                        guest.os_nvram \u003d CONF.libvirt.override_master_nvram.\\"},{"line_number":4410,"context_line":"                                         get(guest.os_loader)"},{"line_number":4411,"context_line":"                else:"},{"line_number":4412,"context_line":"                    raise exception.UEFINotSupported()"},{"line_number":4413,"context_line":"            guest.os_mach_type \u003d self._get_machine_type(image_meta, caps)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_db259ec2","line":4410,"range":{"start_line":4410,"start_character":60,"end_line":4410,"end_character":61},"in_reply_to":"1a122d0e_3adf820d","updated":"2016-05-05 02:35:11.000000000","message":"Done","commit_id":"bc6cf6950f7141379eb15de4bb6447281b09605a"},{"author":{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"},"change_message_id":"e833d03a1f1cfb51bea69aba4c39bbe5edd40b5b","unresolved":false,"context_lines":[{"line_number":4407,"context_line":"                    guest.os_loader_type \u003d \"pflash\""},{"line_number":4408,"context_line":"                    if CONF.libvirt.override_master_nvram is not None:"},{"line_number":4409,"context_line":"                        guest.os_nvram \u003d CONF.libvirt.override_master_nvram.\\"},{"line_number":4410,"context_line":"                                         get(guest.os_loader)"},{"line_number":4411,"context_line":"                else:"},{"line_number":4412,"context_line":"                    raise exception.UEFINotSupported()"},{"line_number":4413,"context_line":"            guest.os_mach_type \u003d self._get_machine_type(image_meta, caps)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_3a282285","line":4410,"range":{"start_line":4410,"start_character":60,"end_line":4410,"end_character":61},"in_reply_to":"1a122d0e_a184190b","updated":"2016-05-04 16:31:05.000000000","message":"In libvirt xml document had mention \"the template attribute can be used to per domain override map of master NVRAM stores from the config file\". But It looks not relative to this bug. Maybe this should been commit in other patch. However do you think this feature is necessary?","commit_id":"bc6cf6950f7141379eb15de4bb6447281b09605a"}]}