)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"8a7fdeef4d422bf581ae9bb0478b1c97a60b6aee","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Prateek Arora \u003cparora@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-09 15:47:22 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Separate out the conf entries for iSCSI and FC multipath drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Both FC \u0026 iSCSI drivers decide on multipath based on the"},{"line_number":10,"context_line":"\u0027iscsi_use_multipath\u0027 config parameter. The user ends up being"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9abb7d3a_19603435","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":64},"updated":"2016-05-27 15:57:29.000000000","message":"The first line should be limited to 50 characters","commit_id":"06efbd8ac2737cee790584aadc55da41a88c1e81"}],"nova/conf/libvirt.py":[{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"8a7fdeef4d422bf581ae9bb0478b1c97a60b6aee","unresolved":false,"context_lines":[{"line_number":319,"context_line":"    cfg.BoolOpt(\u0027iscsi_use_multipath\u0027,"},{"line_number":320,"context_line":"                default\u003dFalse,"},{"line_number":321,"context_line":"                help\u003d\u0027Use multipath connection of the iSCSI volume\u0027),"},{"line_number":322,"context_line":"    cfg.BoolOpt(\u0027fc_use_multipath\u0027,"},{"line_number":323,"context_line":"                default\u003dFalse,"},{"line_number":324,"context_line":"                help\u003d\u0027Use multipath connection of the FC volume\u0027),"},{"line_number":325,"context_line":"    cfg.StrOpt(\u0027iscsi_iface\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_59d11ccd","line":322,"range":{"start_line":322,"start_character":17,"end_line":322,"end_character":33},"updated":"2016-05-27 15:57:29.000000000","message":"I don\u0027t think we need this config parameter.","commit_id":"06efbd8ac2737cee790584aadc55da41a88c1e81"},{"author":{"_account_id":20734,"name":"Prateek Arora","email":"1192prateek@gmail.com","username":"prateek_a"},"change_message_id":"00e0c54e560a05ac69797121c01c3da565cc6e35","unresolved":false,"context_lines":[{"line_number":319,"context_line":"    cfg.BoolOpt(\u0027iscsi_use_multipath\u0027,"},{"line_number":320,"context_line":"                default\u003dFalse,"},{"line_number":321,"context_line":"                help\u003d\u0027Use multipath connection of the iSCSI volume\u0027),"},{"line_number":322,"context_line":"    cfg.BoolOpt(\u0027fc_use_multipath\u0027,"},{"line_number":323,"context_line":"                default\u003dFalse,"},{"line_number":324,"context_line":"                help\u003d\u0027Use multipath connection of the FC volume\u0027),"},{"line_number":325,"context_line":"    cfg.StrOpt(\u0027iscsi_iface\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_1669078c","line":322,"range":{"start_line":322,"start_character":17,"end_line":322,"end_character":33},"in_reply_to":"7aa08908_9909ea97","updated":"2016-06-10 08:00:44.000000000","message":"While a separate parameter would have been better but keeping the rules in cite, i think it is a good suggestion to rename the existing one.","commit_id":"06efbd8ac2737cee790584aadc55da41a88c1e81"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c05e415d00235b87c74d9d488cc9e7595c0a0b5f","unresolved":false,"context_lines":[{"line_number":319,"context_line":"    cfg.BoolOpt(\u0027iscsi_use_multipath\u0027,"},{"line_number":320,"context_line":"                default\u003dFalse,"},{"line_number":321,"context_line":"                help\u003d\u0027Use multipath connection of the iSCSI volume\u0027),"},{"line_number":322,"context_line":"    cfg.BoolOpt(\u0027fc_use_multipath\u0027,"},{"line_number":323,"context_line":"                default\u003dFalse,"},{"line_number":324,"context_line":"                help\u003d\u0027Use multipath connection of the FC volume\u0027),"},{"line_number":325,"context_line":"    cfg.StrOpt(\u0027iscsi_iface\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_9909ea97","line":322,"range":{"start_line":322,"start_character":17,"end_line":322,"end_character":33},"in_reply_to":"9abb7d3a_367d1e6f","updated":"2016-06-09 09:23:07.000000000","message":"can\u0027t we instead rename iscsi_use_multipath to something like volume_use_multipath?\n\nPlease note this change in its current form totally violates our upgrade rules. Please read the first paragraph here:\nhttps://governance.openstack.org/reference/tags/assert_follows-standard-deprecation.html#rationale","commit_id":"06efbd8ac2737cee790584aadc55da41a88c1e81"},{"author":{"_account_id":20734,"name":"Prateek Arora","email":"1192prateek@gmail.com","username":"prateek_a"},"change_message_id":"5ad3f48f8c8e744de351c2aa7fbd5301f79bc86e","unresolved":false,"context_lines":[{"line_number":319,"context_line":"    cfg.BoolOpt(\u0027iscsi_use_multipath\u0027,"},{"line_number":320,"context_line":"                default\u003dFalse,"},{"line_number":321,"context_line":"                help\u003d\u0027Use multipath connection of the iSCSI volume\u0027),"},{"line_number":322,"context_line":"    cfg.BoolOpt(\u0027fc_use_multipath\u0027,"},{"line_number":323,"context_line":"                default\u003dFalse,"},{"line_number":324,"context_line":"                help\u003d\u0027Use multipath connection of the FC volume\u0027),"},{"line_number":325,"context_line":"    cfg.StrOpt(\u0027iscsi_iface\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_367d1e6f","line":322,"range":{"start_line":322,"start_character":17,"end_line":322,"end_character":33},"in_reply_to":"9abb7d3a_59d11ccd","updated":"2016-05-30 03:37:15.000000000","message":"There is a parameter called used iscsi_use_multipath and that is used to decide whether fc uses multipath. This is cryptic enough and merits a change.","commit_id":"06efbd8ac2737cee790584aadc55da41a88c1e81"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6bb3c1db216bc56badb377561b6b525fef05e540","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    cfg.IntOpt(\u0027num_iscsi_scan_tries\u0027,"},{"line_number":317,"context_line":"               default\u003d5,"},{"line_number":318,"context_line":"               help\u003d\u0027Number of times to rescan iSCSI target to find volume\u0027),"},{"line_number":319,"context_line":"    cfg.BoolOpt(\u0027volume_use_multipath\u0027,"},{"line_number":320,"context_line":"                default\u003dFalse,"},{"line_number":321,"context_line":"                help\u003d\u0027Use multipath connection of the iSCSI or FC volume\u0027),"},{"line_number":322,"context_line":"    cfg.StrOpt(\u0027iscsi_iface\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_a48372cb","line":319,"range":{"start_line":319,"start_character":17,"end_line":319,"end_character":37},"updated":"2016-07-25 20:07:21.000000000","message":"Wouldn\u0027t renaming this cause backward compatibility issue?","commit_id":"06b9f1c27e861ae172f82084a6a79406e8cb5f92"},{"author":{"_account_id":20734,"name":"Prateek Arora","email":"1192prateek@gmail.com","username":"prateek_a"},"change_message_id":"479ae10ddd3ac2be4aeec52fa60baff4f6a3a84b","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    cfg.IntOpt(\u0027num_iscsi_scan_tries\u0027,"},{"line_number":317,"context_line":"               default\u003d5,"},{"line_number":318,"context_line":"               help\u003d\u0027Number of times to rescan iSCSI target to find volume\u0027),"},{"line_number":319,"context_line":"    cfg.BoolOpt(\u0027volume_use_multipath\u0027,"},{"line_number":320,"context_line":"                default\u003dFalse,"},{"line_number":321,"context_line":"                help\u003d\u0027Use multipath connection of the iSCSI or FC volume\u0027),"},{"line_number":322,"context_line":"    cfg.StrOpt(\u0027iscsi_iface\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_b25a904e","line":319,"range":{"start_line":319,"start_character":17,"end_line":319,"end_character":37},"in_reply_to":"dada55a8_a48372cb","updated":"2016-08-10 07:09:51.000000000","message":"The default value for both parameters would be same. Only while changing we would have a parameter that does what it says would do.","commit_id":"06b9f1c27e861ae172f82084a6a79406e8cb5f92"}]}