)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"30b526be019b9722dc7a60bd732b53b817626f1a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change makes checks before live migration non blocking,"},{"line_number":10,"context_line":"so user receives http accepted and could checks live-migration"},{"line_number":11,"context_line":"result by instance-actions."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4f788d48ec0e166898184842ac55560163c1b343"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_4d3f0125","line":11,"updated":"2016-05-05 13:42:47.000000000","message":"Try:\n\nThis change makes the checks that happen before a live migration non-blocking so that the user can receive an HTTP accepted and later check the results of the live-migration via instance-actions.\n\nOr something in that vein. In the current version the word ordering is a bit misleading.\n\nHowever, from what I can tell you\u0027re not actually changing the HTTP API, you\u0027re just laying the groundwork for future changes?","commit_id":"01e36b36d994180b0506f034a801e09f9c03705c"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"e178b00460dc299e42545fd4a96d338ecaf43a3f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change makes checks before live migration non blocking,"},{"line_number":10,"context_line":"so user receives http accepted and could checks live-migration"},{"line_number":11,"context_line":"result by instance-actions."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4f788d48ec0e166898184842ac55560163c1b343"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_dbb39608","line":11,"in_reply_to":"1a122d0e_4d3f0125","updated":"2016-05-11 09:41:03.000000000","message":"Done","commit_id":"01e36b36d994180b0506f034a801e09f9c03705c"}],"nova/conductor/rpcapi.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"fd700ae180a482b45fe9ed94b7b9bd04e8c4bddf","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        version \u003d \u00271.15\u0027"},{"line_number":304,"context_line":"        if live and self.client.can_send_version(version):"},{"line_number":305,"context_line":"            self.live_migrate_instance(context, instance, scheduler_hint,"},{"line_number":306,"context_line":"                                       block_migration, disk_over_commit,"},{"line_number":307,"context_line":"                                       request_spec)"},{"line_number":308,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_c1991a21","line":305,"updated":"2016-05-05 14:20:28.000000000","message":"The meat of the change is here, which uses a cast rather than a call. I\u0027m very much in favor of this change, but since it changes the way the REST API works there should be a spec. Most likely what will need to happen is a new microversion and this cast can be used only for requests after that microversion.\n\nHowever we will always need to support the old call method, unless there\u0027s consensus that we can break that.","commit_id":"01e36b36d994180b0506f034a801e09f9c03705c"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"e178b00460dc299e42545fd4a96d338ecaf43a3f","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        version \u003d \u00271.15\u0027"},{"line_number":304,"context_line":"        if live and self.client.can_send_version(version):"},{"line_number":305,"context_line":"            self.live_migrate_instance(context, instance, scheduler_hint,"},{"line_number":306,"context_line":"                                       block_migration, disk_over_commit,"},{"line_number":307,"context_line":"                                       request_spec)"},{"line_number":308,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_7ba70abd","line":305,"in_reply_to":"1a122d0e_c1991a21","updated":"2016-05-11 09:41:03.000000000","message":"Done, rest api version is bumped in subsequent patch","commit_id":"01e36b36d994180b0506f034a801e09f9c03705c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"58be54b12a644fb386153bfbe1a407852820520c","unresolved":false,"context_lines":[{"line_number":300,"context_line":"              \u0027request_spec\u0027: request_spec,"},{"line_number":301,"context_line":"              }"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        version \u003d \u00271.15\u0027"},{"line_number":304,"context_line":"        if live and self.client.can_send_version(version):"},{"line_number":305,"context_line":"            self.live_migrate_instance(context, instance, scheduler_hint,"},{"line_number":306,"context_line":"                                       block_migration, disk_over_commit,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_f111c905","line":303,"updated":"2016-06-10 16:45:24.000000000","message":"This can\u0027t be done without the API version bump since this changes the behavior.","commit_id":"6c8e2825d20c5e7cdf8edc3c682cb4ae7aa19e15"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"8c12e537f9f3e308b46f90368e74ba573f3204bc","unresolved":false,"context_lines":[{"line_number":300,"context_line":"              \u0027request_spec\u0027: request_spec,"},{"line_number":301,"context_line":"              }"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        version \u003d \u00271.15\u0027"},{"line_number":304,"context_line":"        if live and self.client.can_send_version(version):"},{"line_number":305,"context_line":"            self.live_migrate_instance(context, instance, scheduler_hint,"},{"line_number":306,"context_line":"                                       block_migration, disk_over_commit,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_20f210d3","line":303,"in_reply_to":"7aa08908_b0587032","updated":"2016-06-20 14:41:24.000000000","message":"The async param just means that live_migrate_instance is called directly instead of hitting this code path. But if async is false then migrate_server is called which just leads here and causes an async cast anyways.","commit_id":"6c8e2825d20c5e7cdf8edc3c682cb4ae7aa19e15"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"279245faf3d2bae25b3b1a718b774a59138e2880","unresolved":false,"context_lines":[{"line_number":300,"context_line":"              \u0027request_spec\u0027: request_spec,"},{"line_number":301,"context_line":"              }"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        version \u003d \u00271.15\u0027"},{"line_number":304,"context_line":"        if live and self.client.can_send_version(version):"},{"line_number":305,"context_line":"            self.live_migrate_instance(context, instance, scheduler_hint,"},{"line_number":306,"context_line":"                                       block_migration, disk_over_commit,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_b0587032","line":303,"in_reply_to":"7aa08908_f111c905","updated":"2016-06-14 09:11:05.000000000","message":"I feel it\u0027s ok to remove this at all, because I\u0027ve added async param.","commit_id":"6c8e2825d20c5e7cdf8edc3c682cb4ae7aa19e15"}]}
