)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"d5f9a29831adaa52e9a18cd843faf87824f69f9a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This change allows and reads the \u0027api_insecure\u0027 parameter from the"},{"line_number":14,"context_line":"ironic section, which then will be passed to the underlying driver."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"DocImpact"},{"line_number":17,"context_line":"Adding new config option into the ironic group."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I40b16593e692e578d8ec34f229a622b73bb41067"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bab6814e_a2d96e24","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":9},"updated":"2016-05-20 14:05:54.000000000","message":"Using \"DocImpact\" in the commit message means that one of the manuals\nhave to be updated [1]. I don\u0027t think that\u0027s the case here, which means\nI suggest to remove this flag.\n\nWe usually notify the ops with a \"reno\" file about this [2][3].\nFor new config options the section \"features\" is appropriate, for change\nconfig options the section \"upgrade\". Under [4] is an explanation how to\ncreate a \"reno\" file. That file should then be part of your patch.\n\n[1] http://lists.openstack.org/pipermail/openstack-dev/2016-March/088382.html\n[2] http://docs.openstack.org/developer/nova/code-review.html#when-a-release-note-is-needed\n[3] http://docs.openstack.org/releasenotes/nova/unreleased.html\n[4] http://docs.openstack.org/developer/reno/usage.html#creating-new-release-notes","commit_id":"5ad35dcba6e24ab439c07c722c4d6ebae46b2b73"}],"nova/tests/unit/virt/ironic/test_client_wrapper.py":[{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"6b05b77ed1bb4210e35c856c4f39ba974bcbea49","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                    \u0027ironic_url\u0027: CONF.ironic.api_endpoint,"},{"line_number":75,"context_line":"                    \u0027max_retries\u0027: CONF.ironic.api_max_retries,"},{"line_number":76,"context_line":"                    \u0027retry_interval\u0027: CONF.ironic.api_retry_interval,"},{"line_number":77,"context_line":"                    \u0027insecure\u0027: CONF.ironic.api_insecure,"},{"line_number":78,"context_line":"                    \u0027os_ironic_api_version\u0027: \u00271.8\u0027}"},{"line_number":79,"context_line":"        mock_ir_cli.assert_called_once_with(CONF.ironic.api_version,"},{"line_number":80,"context_line":"                                            **expected)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_b1d281fe","line":77,"range":{"start_line":77,"start_character":21,"end_line":77,"end_character":29},"updated":"2016-05-19 21:12:16.000000000","message":"actually, insecure is an old parameter. we should use `verify` instead.","commit_id":"b80990d569ba03fd4f57b4090c5ba98776c250a3"},{"author":{"_account_id":15371,"name":"Tom Patzig","email":"tom.patzig@sap.com","username":"tpatzig"},"change_message_id":"472c6ae3391c025237c494824745e4467e93c352","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                    \u0027ironic_url\u0027: CONF.ironic.api_endpoint,"},{"line_number":75,"context_line":"                    \u0027max_retries\u0027: CONF.ironic.api_max_retries,"},{"line_number":76,"context_line":"                    \u0027retry_interval\u0027: CONF.ironic.api_retry_interval,"},{"line_number":77,"context_line":"                    \u0027insecure\u0027: CONF.ironic.api_insecure,"},{"line_number":78,"context_line":"                    \u0027os_ironic_api_version\u0027: \u00271.8\u0027}"},{"line_number":79,"context_line":"        mock_ir_cli.assert_called_once_with(CONF.ironic.api_version,"},{"line_number":80,"context_line":"                                            **expected)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_aca4eaa5","line":77,"range":{"start_line":77,"start_character":21,"end_line":77,"end_character":29},"in_reply_to":"bab6814e_b1d281fe","updated":"2016-05-19 21:31:33.000000000","message":"but isn\u0027t \u0027insecure\u0027 the actual parameter name used in the ironic client...so we have to pass that one.\n\u0027verify\u0027 is also the opposite in the meaning of insecure.","commit_id":"b80990d569ba03fd4f57b4090c5ba98776c250a3"}]}