)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"dd0c296c09a03c76e9f47ad4264ebd172bd5fa13","unresolved":false,"context_lines":[{"line_number":133,"context_line":"               help\u003d\u0027Interval in seconds for gathering volume usages\u0027),"},{"line_number":134,"context_line":"    cfg.IntOpt(\u0027retry_interval_init_host\u0027, default\u003d30,"},{"line_number":135,"context_line":"                help\u003d\"Number of seconds to wait before retrying init_host \""},{"line_number":136,"context_line":"                     \"if error is raised\"),"},{"line_number":137,"context_line":"]"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"timeout_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fft8%3D","line":136,"updated":"2013-05-31 21:02:48.000000000","message":"Do we really need this to be a configuration option?\n\nThere\u0027s another case of a retry loop on startup.  It\u0027s down in the conductor API.  We wait for it to respond on startup.  It does an exponential backoff and caps at a minute, I think.","commit_id":"aec7578845c29088298b8d18fb6802e5d15d1757"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6388b32af6ac0abf7fc5363b6739c79e19e4be2b","unresolved":false,"context_lines":[{"line_number":133,"context_line":"               help\u003d\u0027Interval in seconds for gathering volume usages\u0027),"},{"line_number":134,"context_line":"    cfg.IntOpt(\u0027retry_interval_init_host\u0027, default\u003d30,"},{"line_number":135,"context_line":"                help\u003d\"Number of seconds to wait before retrying init_host \""},{"line_number":136,"context_line":"                     \"if error is raised\"),"},{"line_number":137,"context_line":"]"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"timeout_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FftY%3D","line":136,"in_reply_to":"AAAAPH%2F%2Fft8%3D","updated":"2013-05-31 21:07:10.000000000","message":"I agree, I don\u0027t think having this as configurable is probably needed.  I\u0027ll look for the exponential backoff code, that would be even better.","commit_id":"aec7578845c29088298b8d18fb6802e5d15d1757"},{"author":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"change_message_id":"e2542e48264212acd391fc636dc77ec8b12baca2","unresolved":false,"context_lines":[{"line_number":642,"context_line":"            self._destroy_evacuated_instances(context)"},{"line_number":643,"context_line":"            for instance in instances:"},{"line_number":644,"context_line":"                # Loop over _init_instance() until it succeeds"},{"line_number":645,"context_line":"                while True:"},{"line_number":646,"context_line":"                    try:"},{"line_number":647,"context_line":"                        self._init_instance(context, instance)"},{"line_number":648,"context_line":"                        break"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Ff%2FI%3D","line":645,"updated":"2013-05-31 19:34:09.000000000","message":"can see infinite loop scenarios","commit_id":"aec7578845c29088298b8d18fb6802e5d15d1757"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a6d6deae0cab5929223209198d208f790806c363","unresolved":false,"context_lines":[{"line_number":642,"context_line":"            self._destroy_evacuated_instances(context)"},{"line_number":643,"context_line":"            for instance in instances:"},{"line_number":644,"context_line":"                # Loop over _init_instance() until it succeeds"},{"line_number":645,"context_line":"                while True:"},{"line_number":646,"context_line":"                    try:"},{"line_number":647,"context_line":"                        self._init_instance(context, instance)"},{"line_number":648,"context_line":"                        break"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Ffwc%3D","line":645,"in_reply_to":"AAAAPH%2F%2Ff%2FI%3D","updated":"2013-05-31 20:47:21.000000000","message":"Yes but that\u0027s what we want as this only executes once when nova boots up.","commit_id":"aec7578845c29088298b8d18fb6802e5d15d1757"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"34e2d7c703923f0bd0b780e534ca0e24b44567f3","unresolved":false,"context_lines":[{"line_number":647,"context_line":"                        self._init_instance(context, instance)"},{"line_number":648,"context_line":"                        break"},{"line_number":649,"context_line":"                    except:"},{"line_number":650,"context_line":"                        LOG.exception(_(\"Error raise initing instance %s\"),"},{"line_number":651,"context_line":"                                      instance[\u0027uuid\u0027])"},{"line_number":652,"context_line":"                        greenthread.sleep(CONF.retry_interval_init_host)"},{"line_number":653,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FgM8%3D","line":650,"updated":"2013-05-31 18:15:10.000000000","message":"raised*","commit_id":"aec7578845c29088298b8d18fb6802e5d15d1757"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"9893ec365a495323f249ee4127685f80824ccf21","unresolved":false,"context_lines":[{"line_number":649,"context_line":"                    except:"},{"line_number":650,"context_line":"                        LOG.exception(_(\"Error raise initing instance %s\"),"},{"line_number":651,"context_line":"                                      instance[\u0027uuid\u0027])"},{"line_number":652,"context_line":"                        greenthread.sleep(CONF.retry_interval_init_host)"},{"line_number":653,"context_line":"        finally:"},{"line_number":654,"context_line":"            if CONF.defer_iptables_apply:"},{"line_number":655,"context_line":"                self.driver.filter_defer_apply_off()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FgNA%3D","line":652,"updated":"2013-05-31 18:15:05.000000000","message":"I would rather this wasn\u0027t so brute force ... can you localize it to the spot of this issue, and for the specific error you\u0027re expecting?","commit_id":"aec7578845c29088298b8d18fb6802e5d15d1757"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6388b32af6ac0abf7fc5363b6739c79e19e4be2b","unresolved":false,"context_lines":[{"line_number":649,"context_line":"                    except:"},{"line_number":650,"context_line":"                        LOG.exception(_(\"Error raise initing instance %s\"),"},{"line_number":651,"context_line":"                                      instance[\u0027uuid\u0027])"},{"line_number":652,"context_line":"                        greenthread.sleep(CONF.retry_interval_init_host)"},{"line_number":653,"context_line":"        finally:"},{"line_number":654,"context_line":"            if CONF.defer_iptables_apply:"},{"line_number":655,"context_line":"                self.driver.filter_defer_apply_off()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FftU%3D","line":652,"in_reply_to":"AAAAPH%2F%2Fft0%3D","updated":"2013-05-31 21:07:10.000000000","message":"Done","commit_id":"aec7578845c29088298b8d18fb6802e5d15d1757"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"dd0c296c09a03c76e9f47ad4264ebd172bd5fa13","unresolved":false,"context_lines":[{"line_number":649,"context_line":"                    except:"},{"line_number":650,"context_line":"                        LOG.exception(_(\"Error raise initing instance %s\"),"},{"line_number":651,"context_line":"                                      instance[\u0027uuid\u0027])"},{"line_number":652,"context_line":"                        greenthread.sleep(CONF.retry_interval_init_host)"},{"line_number":653,"context_line":"        finally:"},{"line_number":654,"context_line":"            if CONF.defer_iptables_apply:"},{"line_number":655,"context_line":"                self.driver.filter_defer_apply_off()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fft0%3D","line":652,"in_reply_to":"AAAAPH%2F%2Ffv0%3D","updated":"2013-05-31 21:02:48.000000000","message":"Also, I would just use time.sleep().  It\u0027s monkey patched.","commit_id":"aec7578845c29088298b8d18fb6802e5d15d1757"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a6d6deae0cab5929223209198d208f790806c363","unresolved":false,"context_lines":[{"line_number":649,"context_line":"                    except:"},{"line_number":650,"context_line":"                        LOG.exception(_(\"Error raise initing instance %s\"),"},{"line_number":651,"context_line":"                                      instance[\u0027uuid\u0027])"},{"line_number":652,"context_line":"                        greenthread.sleep(CONF.retry_interval_init_host)"},{"line_number":653,"context_line":"        finally:"},{"line_number":654,"context_line":"            if CONF.defer_iptables_apply:"},{"line_number":655,"context_line":"                self.driver.filter_defer_apply_off()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Ffv8%3D","line":652,"in_reply_to":"AAAAPH%2F%2FgMQ%3D","updated":"2013-05-31 20:47:21.000000000","message":"I don\u0027t think we want to limit the number of retries because then someone is going to have to manually restart the nova-compute nodes manually if it cannot contact quantum. I\u0027ll add to the message that it\u0027s going to be retried.","commit_id":"aec7578845c29088298b8d18fb6802e5d15d1757"},{"author":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"change_message_id":"26f098924d168a33ad3289f4dbbe7b88a8e1162c","unresolved":false,"context_lines":[{"line_number":649,"context_line":"                    except:"},{"line_number":650,"context_line":"                        LOG.exception(_(\"Error raise initing instance %s\"),"},{"line_number":651,"context_line":"                                      instance[\u0027uuid\u0027])"},{"line_number":652,"context_line":"                        greenthread.sleep(CONF.retry_interval_init_host)"},{"line_number":653,"context_line":"        finally:"},{"line_number":654,"context_line":"            if CONF.defer_iptables_apply:"},{"line_number":655,"context_line":"                self.driver.filter_defer_apply_off()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FgMQ%3D","line":652,"in_reply_to":"AAAAPH%2F%2FgNA%3D","updated":"2013-05-31 18:18:01.000000000","message":"Aaron, in addition to Russell\u0027s suggestion, would help to have \n1) a limit on the number of retries\n2) error message state that it is going to re-try","commit_id":"aec7578845c29088298b8d18fb6802e5d15d1757"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a6d6deae0cab5929223209198d208f790806c363","unresolved":false,"context_lines":[{"line_number":649,"context_line":"                    except:"},{"line_number":650,"context_line":"                        LOG.exception(_(\"Error raise initing instance %s\"),"},{"line_number":651,"context_line":"                                      instance[\u0027uuid\u0027])"},{"line_number":652,"context_line":"                        greenthread.sleep(CONF.retry_interval_init_host)"},{"line_number":653,"context_line":"        finally:"},{"line_number":654,"context_line":"            if CONF.defer_iptables_apply:"},{"line_number":655,"context_line":"                self.driver.filter_defer_apply_off()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Ffv0%3D","line":652,"in_reply_to":"AAAAPH%2F%2FgNA%3D","updated":"2013-05-31 20:47:21.000000000","message":"sure i\u0027ll move this up to where the exception is thrown.","commit_id":"aec7578845c29088298b8d18fb6802e5d15d1757"},{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"43b08735ea3398c5719d85b631e57ead21101afb","unresolved":false,"context_lines":[{"line_number":532,"context_line":"                                    \"in %(retry_time)s seconds.\"),"},{"line_number":533,"context_line":"                                    {\u0027instance_uuid\u0027: instance[\u0027uuid\u0027],"},{"line_number":534,"context_line":"                                     \u0027retry_time\u0027: retry_time})"},{"line_number":535,"context_line":"                    time.sleep(retry_time)"},{"line_number":536,"context_line":"            legacy_net_info \u003d self._legacy_nw_info(net_info)"},{"line_number":537,"context_line":"        self.driver.plug_vifs(instance, legacy_net_info)"},{"line_number":538,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2FcYo%3D","line":535,"updated":"2013-06-03 20:05:30.000000000","message":"Do you really want to retry forever?  I think it might make sense to abort after a few minutes.","commit_id":"6fda12bb14ab91592910f9ebbde9ef9f8d588b08"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"99f9da35aa9c2c14395eb4b1fe8dc05130e91142","unresolved":false,"context_lines":[{"line_number":532,"context_line":"                                    \"in %(retry_time)s seconds.\"),"},{"line_number":533,"context_line":"                                    {\u0027instance_uuid\u0027: instance[\u0027uuid\u0027],"},{"line_number":534,"context_line":"                                     \u0027retry_time\u0027: retry_time})"},{"line_number":535,"context_line":"                    time.sleep(retry_time)"},{"line_number":536,"context_line":"            legacy_net_info \u003d self._legacy_nw_info(net_info)"},{"line_number":537,"context_line":"        self.driver.plug_vifs(instance, legacy_net_info)"},{"line_number":538,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2FcOs%3D","line":535,"in_reply_to":"AAAAPH%2F%2FcYo%3D","updated":"2013-06-03 21:28:45.000000000","message":"I want this to continue to retry until it succeeds. This code only runs on startup of the nova-compute. Previously nova-compute would terminate if this wasn\u0027t successful.","commit_id":"6fda12bb14ab91592910f9ebbde9ef9f8d588b08"}]}