)]}'
{"nova/tests/unit/conductor/tasks/test_live_migrate.py":[{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"5596db792f81cdc34a67a5c99d59533eb2279821","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                          self.task._check_instance_is_active)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_check_instance_host_is_up(self):"},{"line_number":119,"context_line":"        with test.nested("},{"line_number":120,"context_line":"            mock.patch.object(objects.Service, \u0027get_by_compute_host\u0027),"},{"line_number":121,"context_line":"            mock.patch.object(self.task.servicegroup_api, \u0027service_is_up\u0027)"},{"line_number":122,"context_line":"        ) as (mock_get, mock_is_up):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_e550c2d6","line":119,"range":{"start_line":119,"start_character":13,"end_line":119,"end_character":24},"updated":"2016-05-31 09:54:15.000000000","message":"Can you get rid of this and move all mock.patch.objects to decorators?","commit_id":"861daaf8930302a3a18a071ac561e9c01b8bb96d"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"5596db792f81cdc34a67a5c99d59533eb2279821","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            mock_is_up.assert_called_once_with(\"service\")"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def test_check_instance_host_is_up_fails_if_not_up(self):"},{"line_number":131,"context_line":"        with test.nested("},{"line_number":132,"context_line":"            mock.patch.object(objects.Service, \u0027get_by_compute_host\u0027),"},{"line_number":133,"context_line":"            mock.patch.object(self.task.servicegroup_api, \u0027service_is_up\u0027)"},{"line_number":134,"context_line":"        ) as (mock_get, mock_is_up):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_4560aea5","line":131,"range":{"start_line":131,"start_character":13,"end_line":131,"end_character":24},"updated":"2016-05-31 09:54:15.000000000","message":"ditto","commit_id":"861daaf8930302a3a18a071ac561e9c01b8bb96d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"857533d86c0b9f1e151c2d4d29947aff20733734","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    @mock.patch.object(objects.Service, \u0027get_by_compute_host\u0027)"},{"line_number":119,"context_line":"    @mock.patch.object(servicegroup.API, \u0027service_is_up\u0027)"},{"line_number":120,"context_line":"    def test_check_instance_host_is_up(self, mock_is_up, mock_get):"},{"line_number":121,"context_line":"        mock_get.return_value \u003d \"service\""},{"line_number":122,"context_line":"        mock_is_up.return_value \u003d True"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.task._check_host_is_up(\"host\")"},{"line_number":125,"context_line":"        mock_get.assert_called_once_with(self.context, \"host\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_845388e1","line":122,"range":{"start_line":121,"start_character":0,"end_line":122,"end_character":38},"updated":"2016-10-07 14:23:09.000000000","message":"nit: you can pass these as arguments to the decorators:\n\n    @mock.patch.object(objects.Service, \u0027get_by_compute_host\u0027,\n        return_value\u003dTrue)","commit_id":"ff486f3a1907acd7da49ada020f187cd3006f32d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"055770c575e6f8e07d8f1794a11dd6b13d095146","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    @mock.patch.object(objects.Service, \u0027get_by_compute_host\u0027)"},{"line_number":119,"context_line":"    @mock.patch.object(servicegroup.API, \u0027service_is_up\u0027)"},{"line_number":120,"context_line":"    def test_check_instance_host_is_up(self, mock_is_up, mock_get):"},{"line_number":121,"context_line":"        mock_get.return_value \u003d \"service\""},{"line_number":122,"context_line":"        mock_is_up.return_value \u003d True"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.task._check_host_is_up(\"host\")"},{"line_number":125,"context_line":"        mock_get.assert_called_once_with(self.context, \"host\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_d7a316ff","line":122,"range":{"start_line":121,"start_character":0,"end_line":122,"end_character":38},"in_reply_to":"1a95cdbc_845388e1","updated":"2017-01-18 18:43:05.000000000","message":"Honestly, I like the setup in the method, because it reads nicely for the (setup, run, assert) phases of a unit test.","commit_id":"ff486f3a1907acd7da49ada020f187cd3006f32d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"857533d86c0b9f1e151c2d4d29947aff20733734","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    @mock.patch.object(servicegroup.API, \u0027service_is_up\u0027)"},{"line_number":130,"context_line":"    def test_check_instance_host_is_up_fails_if_not_up(self, mock_is_up,"},{"line_number":131,"context_line":"                                                       mock_get):"},{"line_number":132,"context_line":"        mock_get.return_value \u003d \"service\""},{"line_number":133,"context_line":"        mock_is_up.return_value \u003d False"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        self.assertRaises(exception.ComputeServiceUnavailable,"},{"line_number":136,"context_line":"                self.task._check_host_is_up, \"host\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_44742067","line":133,"range":{"start_line":132,"start_character":0,"end_line":133,"end_character":39},"updated":"2016-10-07 14:23:09.000000000","message":"ditto","commit_id":"ff486f3a1907acd7da49ada020f187cd3006f32d"}]}