)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"2a5b7a6fd91e34084f59f45ca218cac6d477ac44","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    These exceptions have to be logged and not reraised, as they are false"},{"line_number":13,"context_line":"    alarms."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    Fixes: bug #1186447"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I0647935c4452d4294f49a4c0d08e480584ebec7c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAAPX%2F%2Fvjs%3D","line":15,"updated":"2013-06-11 15:42:31.000000000","message":"Can you fix (remove) this indentation?","commit_id":"cbefba5d1985d85d93d05430699cac0d681df56d"}],"nova/compute/manager.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b3c9a708082697fcb7ab0dadf8a86e289e2974c6","unresolved":false,"context_lines":[{"line_number":962,"context_line":"            if network_info is not None:"},{"line_number":963,"context_line":"                network_info.wait(do_raise\u003dFalse)"},{"line_number":964,"context_line":"            try:"},{"line_number":965,"context_line":"                msg \u003d _(\"Instance disappeared during build\")"},{"line_number":966,"context_line":"                self._deallocate_network(context, instance)"},{"line_number":967,"context_line":"            except Exception:"},{"line_number":968,"context_line":"                msg \u003d _(\u0027Failed to dealloc network \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPX%2F%2FvqI%3D","line":965,"updated":"2013-06-11 15:04:59.000000000","message":"OK, now I understand this code fairly well; I had originally missed that this was part of an enclosing exception handler.  Now all I have is a style nit: put the assignment to \u0027msg\u0027 outside the \u0027try\u0027 block.","commit_id":"cbefba5d1985d85d93d05430699cac0d681df56d"},{"author":{"_account_id":7531,"name":"Sridevi Koushik","email":"sridevi.koushik@rackspace.com","username":"sridevik"},"change_message_id":"cc8f0aac077b31e9ffe5a074587029dfea542dd5","unresolved":false,"context_lines":[{"line_number":962,"context_line":"            if network_info is not None:"},{"line_number":963,"context_line":"                network_info.wait(do_raise\u003dFalse)"},{"line_number":964,"context_line":"            try:"},{"line_number":965,"context_line":"                msg \u003d _(\"Instance disappeared during build\")"},{"line_number":966,"context_line":"                self._deallocate_network(context, instance)"},{"line_number":967,"context_line":"            except Exception:"},{"line_number":968,"context_line":"                msg \u003d _(\u0027Failed to dealloc network \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPX%2F%2FvVM%3D","line":965,"in_reply_to":"AAAAPX%2F%2FvqI%3D","updated":"2013-06-11 16:37:20.000000000","message":"Done","commit_id":"cbefba5d1985d85d93d05430699cac0d681df56d"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b3c9a708082697fcb7ab0dadf8a86e289e2974c6","unresolved":false,"context_lines":[{"line_number":1850,"context_line":"        context \u003d context.elevated()"},{"line_number":1851,"context_line":""},{"line_number":1852,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"},{"line_number":1853,"context_line":"        try:"},{"line_number":1854,"context_line":"            instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"},{"line_number":1855,"context_line":"                                             power_state\u003dcurrent_power_state)"},{"line_number":1856,"context_line":"            LOG.audit(_(\u0027instance snapshotting\u0027), context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPX%2F%2FvpU%3D","line":1853,"updated":"2013-06-11 15:04:59.000000000","message":"So, just asking a question here:\n\nDoes all this code need to be in the \u0027try\u0027 block?  It\u0027s a lot of code, and we try to keep the amount of code in a \u0027try\u0027 block to a minimum.  There is precedent for this sort of thing, I\u0027m just making sure this really does make sense: I wouldn\u0027t want you to replace this one big \u0027try\u0027 with 5 smaller \u0027try\u0027s that all look alike :)","commit_id":"cbefba5d1985d85d93d05430699cac0d681df56d"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e63d6d268237d9202d17ae1f740a3f80d9e9e458","unresolved":false,"context_lines":[{"line_number":1850,"context_line":"        context \u003d context.elevated()"},{"line_number":1851,"context_line":""},{"line_number":1852,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"},{"line_number":1853,"context_line":"        try:"},{"line_number":1854,"context_line":"            instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"},{"line_number":1855,"context_line":"                                             power_state\u003dcurrent_power_state)"},{"line_number":1856,"context_line":"            LOG.audit(_(\u0027instance snapshotting\u0027), context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPX%2F%2FvI4%3D","line":1853,"in_reply_to":"AAAAPX%2F%2FvUo%3D","updated":"2013-06-11 17:36:18.000000000","message":"It\u0027s pretty much as I expected.  Thanks…","commit_id":"cbefba5d1985d85d93d05430699cac0d681df56d"},{"author":{"_account_id":7531,"name":"Sridevi Koushik","email":"sridevi.koushik@rackspace.com","username":"sridevik"},"change_message_id":"cc8f0aac077b31e9ffe5a074587029dfea542dd5","unresolved":false,"context_lines":[{"line_number":1850,"context_line":"        context \u003d context.elevated()"},{"line_number":1851,"context_line":""},{"line_number":1852,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"},{"line_number":1853,"context_line":"        try:"},{"line_number":1854,"context_line":"            instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"},{"line_number":1855,"context_line":"                                             power_state\u003dcurrent_power_state)"},{"line_number":1856,"context_line":"            LOG.audit(_(\u0027instance snapshotting\u0027), context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPX%2F%2FvUo%3D","line":1853,"in_reply_to":"AAAAPX%2F%2FvpU%3D","updated":"2013-06-11 16:37:20.000000000","message":"Kevin/Russell\nThere are 2 exceptions being caught.\nInstanceNotFound and UnexpectedTaskStateError\nThe try block needs to enclose all of the \"_instance_update\" calls because, although the first \"_instance_update\" does not have an \"expected task state\" passed in, it could still throw a InstanceNotFound Exception. So I don\u0027t think of an alternative  other than having different blocks. But I\u0027m guessing doing that will make it more messier.\nWhat are your thoughts?","commit_id":"cbefba5d1985d85d93d05430699cac0d681df56d"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"2a5b7a6fd91e34084f59f45ca218cac6d477ac44","unresolved":false,"context_lines":[{"line_number":1850,"context_line":"        context \u003d context.elevated()"},{"line_number":1851,"context_line":""},{"line_number":1852,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"},{"line_number":1853,"context_line":"        try:"},{"line_number":1854,"context_line":"            instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"},{"line_number":1855,"context_line":"                                             power_state\u003dcurrent_power_state)"},{"line_number":1856,"context_line":"            LOG.audit(_(\u0027instance snapshotting\u0027), context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPX%2F%2Fvgo%3D","line":1853,"in_reply_to":"AAAAPX%2F%2FvpU%3D","updated":"2013-06-11 15:42:31.000000000","message":"yeah, it\u0027s a pretty big try block for sure ...","commit_id":"cbefba5d1985d85d93d05430699cac0d681df56d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d6ce2d3889fdeb1dd263d359c92a23cd17bd7ceb","unresolved":false,"context_lines":[{"line_number":985,"context_line":"        except exception.InstanceNotFound:"},{"line_number":986,"context_line":"            # the instance got deleted during the spawn"},{"line_number":987,"context_line":"            # Make sure the async call finishes"},{"line_number":988,"context_line":"            msg \u003d _(\"Instance disappeared during build\")"},{"line_number":989,"context_line":"            if network_info is not None:"},{"line_number":990,"context_line":"                network_info.wait(do_raise\u003dFalse)"},{"line_number":991,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAPn%2F%2F23o%3D","line":988,"updated":"2013-06-19 17:26:50.000000000","message":"why not set this in line 998. if there is an exception then it is overwritten","commit_id":"b93e4c4c4639b6ab63d964506d3a83d969846fca"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a0afc2966712a7132d41fdd71c183e2bd16fb878","unresolved":false,"context_lines":[{"line_number":985,"context_line":"        except exception.InstanceNotFound:"},{"line_number":986,"context_line":"            # the instance got deleted during the spawn"},{"line_number":987,"context_line":"            # Make sure the async call finishes"},{"line_number":988,"context_line":"            msg \u003d _(\"Instance disappeared during build\")"},{"line_number":989,"context_line":"            if network_info is not None:"},{"line_number":990,"context_line":"                network_info.wait(do_raise\u003dFalse)"},{"line_number":991,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAPn%2F%2F23M%3D","line":988,"in_reply_to":"AAAAPn%2F%2F23o%3D","updated":"2013-06-19 17:29:20.000000000","message":"Which, I believe, is the desired behavior.","commit_id":"b93e4c4c4639b6ab63d964506d3a83d969846fca"},{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"04575dbc3ff3304d5e1c2e450639d35cd292e5cf","unresolved":false,"context_lines":[{"line_number":1960,"context_line":"            # the instance got deleted during the snapshot"},{"line_number":1961,"context_line":"            # Quickly bail out of here"},{"line_number":1962,"context_line":"            msg \u003d _(\"Instance disappeared during build\")"},{"line_number":1963,"context_line":"            LOG.exception(msg, instance\u003dinstance)"},{"line_number":1964,"context_line":"        except exception.UnexpectedTaskStateError as e:"},{"line_number":1965,"context_line":"            actual_task_state \u003d e.kwargs.get(\u0027actual\u0027, None)"},{"line_number":1966,"context_line":"            if actual_task_state \u003d\u003d \u0027deleting\u0027:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAPn%2F%2Fz2Y%3D","line":1963,"updated":"2013-06-20 17:32:18.000000000","message":"So at this point, the snapshot operation wasn\u0027t able to complete and failed. Shouldn\u0027t we be raising something to indicate that?","commit_id":"32ad18e8c20c0863b6e2d7179f5206b3d778874b"},{"author":{"_account_id":7531,"name":"Sridevi Koushik","email":"sridevi.koushik@rackspace.com","username":"sridevik"},"change_message_id":"b683bf2350ef0bda3f2fc0a862e41be06bb30786","unresolved":false,"context_lines":[{"line_number":1960,"context_line":"            # the instance got deleted during the snapshot"},{"line_number":1961,"context_line":"            # Quickly bail out of here"},{"line_number":1962,"context_line":"            msg \u003d _(\"Instance disappeared during build\")"},{"line_number":1963,"context_line":"            LOG.exception(msg, instance\u003dinstance)"},{"line_number":1964,"context_line":"        except exception.UnexpectedTaskStateError as e:"},{"line_number":1965,"context_line":"            actual_task_state \u003d e.kwargs.get(\u0027actual\u0027, None)"},{"line_number":1966,"context_line":"            if actual_task_state \u003d\u003d \u0027deleting\u0027:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAPn%2F%2Fzdc%3D","line":1963,"in_reply_to":"AAAAPn%2F%2Fz2Y%3D","updated":"2013-06-20 20:47:43.000000000","message":"Hi Mathew,\nThe only thing that happens on raising is, it gets caught by the outermost exception wrapper. This annotation sends a notification that \"something went wrong\" with the snapshot. But in reality, the instance was deleted and I don\u0027t see any point in notifying such cases.","commit_id":"32ad18e8c20c0863b6e2d7179f5206b3d778874b"},{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"581d55cf2c78f735254215d7dbb321aade30e1b9","unresolved":false,"context_lines":[{"line_number":1960,"context_line":"            # the instance got deleted during the snapshot"},{"line_number":1961,"context_line":"            # Quickly bail out of here"},{"line_number":1962,"context_line":"            msg \u003d _(\"Instance disappeared during build\")"},{"line_number":1963,"context_line":"            LOG.exception(msg, instance\u003dinstance)"},{"line_number":1964,"context_line":"        except exception.UnexpectedTaskStateError as e:"},{"line_number":1965,"context_line":"            actual_task_state \u003d e.kwargs.get(\u0027actual\u0027, None)"},{"line_number":1966,"context_line":"            if actual_task_state \u003d\u003d \u0027deleting\u0027:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAPn%2F%2FzSw%3D","line":1963,"in_reply_to":"AAAAPn%2F%2Fzdc%3D","updated":"2013-06-20 22:05:17.000000000","message":"Right, but that should notify the API layer at least. I guess if the instance was deleted though, it doesn\u0027t make sense to update the DB record with a fault etc. since the instance is gone...","commit_id":"32ad18e8c20c0863b6e2d7179f5206b3d778874b"},{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"04575dbc3ff3304d5e1c2e450639d35cd292e5cf","unresolved":false,"context_lines":[{"line_number":1965,"context_line":"            actual_task_state \u003d e.kwargs.get(\u0027actual\u0027, None)"},{"line_number":1966,"context_line":"            if actual_task_state \u003d\u003d \u0027deleting\u0027:"},{"line_number":1967,"context_line":"                msg \u003d _(\u0027Instance was deleted during snapshot.\u0027)"},{"line_number":1968,"context_line":"                LOG.debug(msg, instance\u003dinstance)"},{"line_number":1969,"context_line":"            else:"},{"line_number":1970,"context_line":"                raise"},{"line_number":1971,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAPn%2F%2Fz18%3D","line":1968,"updated":"2013-06-20 17:32:18.000000000","message":"same here","commit_id":"32ad18e8c20c0863b6e2d7179f5206b3d778874b"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"eb40b16caa4c7c4a705a0531d9cb094d51afcbde","unresolved":false,"context_lines":[{"line_number":1961,"context_line":"            # the instance got deleted during the snapshot"},{"line_number":1962,"context_line":"            # Quickly bail out of here"},{"line_number":1963,"context_line":"            msg \u003d _(\"Instance disappeared during build\")"},{"line_number":1964,"context_line":"            LOG.exception(msg, instance\u003dinstance)"},{"line_number":1965,"context_line":"        except exception.UnexpectedTaskStateError as e:"},{"line_number":1966,"context_line":"            actual_task_state \u003d e.kwargs.get(\u0027actual\u0027, None)"},{"line_number":1967,"context_line":"            if actual_task_state \u003d\u003d \u0027deleting\u0027:"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAPn%2F%2Fqvc%3D","line":1964,"updated":"2013-06-25 16:36:14.000000000","message":"If this is a false alarm and not fatal, I don\u0027t think LOG.exception() is appropriate.  This will leave a traceback in the log, and I\u0027m not sure that\u0027s what we want.  The patch does LOG.debug() below for the same case.  Should it just be debug here, too?","commit_id":"84a5d4ee4410e243fdfd5c43c7a0281bbe5aca25"},{"author":{"_account_id":7531,"name":"Sridevi Koushik","email":"sridevi.koushik@rackspace.com","username":"sridevik"},"change_message_id":"a9039ffd39350a62d3835a9801eeb94b4eeb6fcd","unresolved":false,"context_lines":[{"line_number":1961,"context_line":"            # the instance got deleted during the snapshot"},{"line_number":1962,"context_line":"            # Quickly bail out of here"},{"line_number":1963,"context_line":"            msg \u003d _(\"Instance disappeared during build\")"},{"line_number":1964,"context_line":"            LOG.exception(msg, instance\u003dinstance)"},{"line_number":1965,"context_line":"        except exception.UnexpectedTaskStateError as e:"},{"line_number":1966,"context_line":"            actual_task_state \u003d e.kwargs.get(\u0027actual\u0027, None)"},{"line_number":1967,"context_line":"            if actual_task_state \u003d\u003d \u0027deleting\u0027:"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAPn%2F%2FiHU%3D","line":1964,"in_reply_to":"AAAAPn%2F%2Fqvc%3D","updated":"2013-06-28 11:54:13.000000000","message":"Done","commit_id":"84a5d4ee4410e243fdfd5c43c7a0281bbe5aca25"}]}